Page MenuHomePhabricator

New icons for repositories
ClosedPublic

Authored by chad on Jun 21 2017, 8:06 PM.

Details

Summary

Had some made, they seem better than my attempt.

Test Plan

review in sandbox.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad created this revision.Jun 21 2017, 8:06 PM
epriestley accepted this revision.Jun 21 2017, 8:55 PM

I have reviewed these icons for literally representing true objects in a factual way.

resources/builtin/repo/building.png
1

what kind of building has 4-story vertical windows NOT VERY AUTHENTIC

resources/builtin/repo/commit.png
1

Inner ring isn't AA'd properly?

resources/builtin/repo/gears.png
1

Inner ring isn't AA'd properly.

This gear is close enough to realistic that I'm not going to complain about it.

resources/builtin/repo/locked.png
1

Inner ring isn't AA'd properly.

resources/builtin/repo/microchip.png
1

I think this is perfectly identifiable, but the pins on a IC like the original are pin-shaped so they can go into sockets or holes in a circuit board or header:

This image reverses the direction of the pins and makes them point inward. It's identifiable as a CPU, but clearly an "artist's interpretation" of a CPU.

FWIW I found this much worse one elsewhere on the internet:

resources/builtin/repo/repo.png
1

This book's pages are wider in the middle of the book than at the beginning and end.

This revision is now accepted and ready to land.Jun 21 2017, 8:55 PM
avivey added a subscriber: avivey.Jun 21 2017, 9:29 PM
avivey added inline comments.
resources/builtin/repo/database.png
1

Unless the lights are flares, I'd expect them to be less round, and flush to the surface of the container, like here:


(Produced using mspaint-3d!)

resources/builtin/repo/desktop.png
1

I hate glare-y screens. How can you see anything? Do you work in a darkroom?

It's good the world of art has people like us to make sure icons directly represent real objects in a 1:1 way.

This revision was automatically updated to reflect the committed changes.
chad added a comment.Jun 22 2017, 5:54 AM

I expect the white AA will be fixed in the next batch of icons. I don't believe it will affect anything.