Some header tag icons are too small
ClosedPublic
Actions

Authored by chad on Aug 25 2017, 2:11 AM.

Tags

None

Referenced Files

	F18842191: D18472.id44377.diff
	Tue, Oct 28, 1:48 PM

	F18828385: D18472.id.diff
	Fri, Oct 24, 4:01 PM

	F18828182: D18472.id44379.diff
	Fri, Oct 24, 2:51 PM

	F18821372: D18472.diff
	Wed, Oct 22, 10:33 PM

	F18194783: D18472.id44377.diff
	Aug 17 2025, 12:15 PM

	F18185373: D18472.id.diff
	Aug 16 2025, 3:54 PM

	F18090612: D18472.id44377.diff
	Aug 6 2025, 4:22 PM

	F18090608: D18472.id.diff
	Aug 6 2025, 4:22 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
avivey

Commits

rPc49896f7c5a7: Some header tag icons are too small

Summary

Ref D17991, this rule got more specific with shade tag re-write, so needs updating for headers.

Test Plan

Review a differential header, first icon is now 15px instead of 12px

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 25 2017, 2:11 AM

Harbormaster completed remote builds in B18164: Diff 44377.Aug 25 2017, 2:11 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2017, 2:11 AM

Harbormaster completed remote builds in B18164: Diff 44377.Aug 25 2017, 2:12 AM

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Aug 25 2017, 2:19 AM

Closed by commit rPc49896f7c5a7: Some header tag icons are too small (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 25 2017, 2:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

4 lines

Diff 44379

View Options

resources/celerity/map.php