Paths

Table of Contentst

Modernize editor selector
ClosedPublic
Actions

Authored by avivey on Jun 19 2017, 10:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 1:29 AM

	Unknown Object (File)
	Sat, Nov 16, 3:09 PM

	Unknown Object (File)
	Tue, Nov 12, 11:52 AM

	Unknown Object (File)
	Thu, Nov 7, 6:52 PM

	Unknown Object (File)
	Tue, Nov 5, 11:55 PM

	Unknown Object (File)
	Tue, Nov 5, 11:55 PM

	Unknown Object (File)
	Tue, Nov 5, 11:55 PM

	Unknown Object (File)
	Mon, Nov 4, 10:28 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley
amckinley
kdhp

Group Reviewers

Blessed Reviewers

Commits

rPHU900873b4a4c5: Modernize editor selector

Summary

FreeBSD doesn't have nano by default, so allow falling back to vi. Also added sensible-editor.
This mostly retains the order we select things, but reduces some lines.

Test Plan

arc diff

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Jun 19 2017, 10:53 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 19 2017, 10:53 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B17536: Diff 43644.Jun 19 2017, 10:53 PM

avivey mentioned this in Z1336: General Chat.Jun 19 2017, 10:59 PM

kdhp accepted this revision.Jun 19 2017, 11:10 PM

epriestley accepted this revision.Jun 20 2017, 12:06 AM

This revision is now accepted and ready to land.Jun 20 2017, 12:06 AM

Closed by commit rPHU900873b4a4c5: Modernize editor selector (authored by avivey, committed by avivey). · Explain WhyJun 20 2017, 12:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

console/

PhutilInteractiveEditor.php

14 lines

Diff 43645

View Options

src/console/PhutilInteractiveEditor.php

Modernize editor selectorClosedPublicActions