Fixes T7843. Moves this to a mostly JS workflow for marking all notifications read on the dropdown or on application search. It works, but sometimes it takes 2-3 clicks and I can't figure out if local env issue or bad JS. Please give it a spin.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7843: Marking all notifications as read - action flow tedious
Mark notifications read on panel and app search page, reload to ensure they're gone.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mark-all-read (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17523 Build 24432: Run Core Tests Build 23507: Run Core Tests Build 23506: Run Core Tests Build 23505: arc lint + arc unit
Event Timeline
Comment Actions
Yeah I can't quite get this stable. Each click seems to update both messages and notifications.
Comment Actions
I give up here. I feel like this should be 3-4 lines of JS but for the life of me I can't find them and then I crash the webserver. Any suggestions?
Comment Actions
Haha, If I click the button too many times my local machine's apache stops responding. I don't know if it's terrorizing the db, or if I'm on a crappy wifi connection in the country.
Comment Actions
I'll take a look at this when I get a chance.
(I like this dialog personally, so maybe I'll build a [√] Don't ask again thing or something, I guess. 🐑)
Comment Actions
I don't think it's strictly necessary, but I think it's fairly user-hostile if there's no confirmation and no undo, since one misclick could cause you to lose data (the state of your notifications). But I'm also not very sympathetic to users asking for this change in the first place so maybe that one click is actually horrible torture.
Comment Actions
(I think we either have "confirm" or "undo" for every other destructive action in the product.)
Comment Actions
Yeah I’ve just never felt I needed to undo an "Mark all as read” action.
The list is still present, so the risk seems…. very low. It’s not like
deleting a comment.