Page MenuHomePhabricator

Remove dialog from "Mark All Read" notifications
AbandonedPublic

Authored by chad on Jun 18 2017, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 1:22 AM
Unknown Object (File)
Fri, Dec 27, 2:34 PM
Unknown Object (File)
Sat, Dec 21, 10:47 AM
Unknown Object (File)
Sun, Dec 15, 7:36 PM
Unknown Object (File)
Sat, Dec 14, 9:16 AM
Unknown Object (File)
Fri, Dec 13, 5:56 PM
Unknown Object (File)
Mon, Dec 9, 7:43 PM
Unknown Object (File)
Nov 26 2024, 10:46 PM
Subscribers
Tokens
"Baby Tequila" token, awarded by avivey.

Details

Summary

Fixes T7843. Moves this to a mostly JS workflow for marking all notifications read on the dropdown or on application search. It works, but sometimes it takes 2-3 clicks and I can't figure out if local env issue or bad JS. Please give it a spin.

Test Plan

Mark notifications read on panel and app search page, reload to ensure they're gone.

Diff Detail

Repository
rP Phabricator
Branch
mark-all-read (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17523
Build 24432: Run Core Tests
Build 23507: Run Core Tests
Build 23506: Run Core Tests
Build 23505: arc lint + arc unit

Event Timeline

chad planned changes to this revision.Jun 18 2017, 7:05 PM

Yeah I can't quite get this stable. Each click seems to update both messages and notifications.

I give up here. I feel like this should be 3-4 lines of JS but for the life of me I can't find them and then I crash the webserver. Any suggestions?

then I crash the webserver

What do you mean by this, specifically?

Haha, If I click the button too many times my local machine's apache stops responding. I don't know if it's terrorizing the db, or if I'm on a crappy wifi connection in the country.

epriestley edited reviewers, added: chad; removed: epriestley.

I'll take a look at this when I get a chance.

(I like this dialog personally, so maybe I'll build a [โˆš] Don't ask again thing or something, I guess. ๐Ÿ‘)

I'm going to take this back and complete. Do you feel a setting needed for this?

I don't think it's strictly necessary, but I think it's fairly user-hostile if there's no confirmation and no undo, since one misclick could cause you to lose data (the state of your notifications). But I'm also not very sympathetic to users asking for this change in the first place so maybe that one click is actually horrible torture.

(I think we either have "confirm" or "undo" for every other destructive action in the product.)

Yeah Iโ€™ve just never felt I needed to undo an "Mark all as readโ€ action.
The list is still present, so the risk seemsโ€ฆ. very low. Itโ€™s not like
deleting a comment.

chad abandoned this revision.
chad edited reviewers, added: epriestley; removed: chad.

I'll add a setting, since we just cleaned up the Notifications panel