Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Mar 22 2021

epriestley renamed T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions from Filesystem class invokes "copy" command on Windows, which fails after "bypass_shell" changes to Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 7:00 PM · Windows, Arcanist
epriestley added a comment to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

D21643 "fixes" this by using copy(). However:

Mar 22 2021, 6:59 PM · Windows, Arcanist
epriestley added a revision to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions: D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".
Mar 22 2021, 6:43 PM · Windows, Arcanist
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Mar 22 2021, 6:14 PM · Windows, Arcanist

Aug 11 2020

epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Aug 11 2020, 5:47 PM · Windows, Arcanist
epriestley triaged T13563: On Windows, Arcanist tries and fails to set stdin nonblocking while reading the stream as Low priority.
Aug 11 2020, 5:06 PM · Windows, Arcanist
epriestley triaged T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions as Normal priority.
Aug 11 2020, 5:02 PM · Windows, Arcanist

Jun 12 2020

epriestley triaged T13549: Use "sapi_windows_set_ctrl_handler()" under PHP 7.4 to handle ^C on Windows as Low priority.
Jun 12 2020, 9:00 PM · Arcanist, Windows

Apr 7 2020

epriestley moved T6925: XHPAST is out of date on Windows from Backlog to Windows on the XHPAST board.
Apr 7 2020, 1:33 PM · Windows, XHPAST

Apr 6 2020

epriestley closed T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable as Resolved.

Character encoding issues aren't stable yet (see also T13500) but I think everything else here is.

Apr 6 2020, 2:25 PM · Windows

Apr 2 2020

epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D21052: Update some ancient "set X=Y" environment code for new Windows execution without a shell.
Apr 2 2020, 8:44 PM · Arcanist, Windows
epriestley added a revision to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: D21052: Update some ancient "set X=Y" environment code for new Windows execution without a shell.
Apr 2 2020, 8:44 PM · Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D21051: Make Windows escaping preserve "%" symbols in arguments.
Apr 2 2020, 7:40 PM · Arcanist, Windows
epriestley added a revision to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: D21051: Make Windows escaping preserve "%" symbols in arguments.
Apr 2 2020, 7:40 PM · Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

See also:

Apr 2 2020, 7:35 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

See also:

Apr 2 2020, 6:12 PM · Arcanist, Windows
epriestley added a project to T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable: Windows.
Apr 2 2020, 6:12 PM · Windows

Dec 28 2018

quark.zju added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I'm not an Windows expert. But to my knowledge there are a couple of things missing here:

Dec 28 2018, 8:14 PM · Arcanist, Windows

Oct 25 2018

epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19758: Work around a Windows escaping issue and security conecern in "hg cat --output ...".
Oct 25 2018, 2:01 AM · Arcanist, Windows

Oct 3 2018

epriestley renamed T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Replace arc.bat with something better to Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]".
Oct 3 2018, 2:52 PM · Arcanist, Windows

Oct 2 2018

epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19729: [Wilds] Pass or skip all remaining Windows unit test failures.
Oct 2 2018, 6:38 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19728: [Wilds] Stop writing temporary files for linter tests.
Oct 2 2018, 6:35 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19727: [Wilds] On Windows: always use stdout/stderr files and always "bypass_shell".
Oct 2 2018, 6:25 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19726: [Wilds] Use "random_bytes()" if it is available (after PHP7).
Oct 2 2018, 6:08 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19725: [Wilds] Sanitize UTF8 output in `tsprintf(...)` under Windows.
Oct 2 2018, 5:57 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): D19724: [Wilds] Fix phutil_is_utf8_slowly() to reject reserved UTF16 surrogate character ranges.
Oct 2 2018, 5:51 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Also, guess what this checkbox does on Windows 10?

Oct 2 2018, 4:57 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Consider this script:

Oct 2 2018, 4:56 PM · Arcanist, Windows
epriestley lowered the priority of T2465: Context not available for revisions created on Windows from High to Low.
Oct 2 2018, 1:05 PM · Windows, Subversion, Arcanist
epriestley moved T9441: Cygwin PHP segfaults with arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:05 PM · Windows, Arcanist
epriestley moved T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:03 PM · Arcanist, Windows
epriestley renamed T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD") from arc patch fails on Windows with SVN to arc patch fails on Windows with SVN (because it uses "cd", not "setCWD").
Oct 2 2018, 1:03 PM · Windows, Arcanist
epriestley moved T8855: Add Powershell support to Arcanist documentation from Backlog to Powershell on the Windows board.
Oct 2 2018, 1:01 PM · Windows, Arcanist
epriestley moved T2465: Context not available for revisions created on Windows from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Subversion, Arcanist
epriestley moved T4964: Windows installer for Arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Wikimedia, Setup, Arcanist
epriestley moved T10910: Creating an arc diff from a working directory that is not the repository root from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Bug Report
epriestley moved T11072: Arcanist reports that it cannot generate a diff from SVN repo even though there are changes in the working copy from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Bug Report
epriestley renamed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) from Arcanist failed patch lint on windows to Arcanist failed patch lint on windows (because "cp" does not exist).
Oct 2 2018, 12:59 PM · Windows, Bug Report
epriestley closed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) as Resolved.

This was almost certainly resolved by D16273.

Oct 2 2018, 12:59 PM · Windows, Bug Report
epriestley moved T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint, Arcanist
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Windows, XHPAST
epriestley moved T5730: `arc lint --everything` reporting all symbols missing in libphutil/ on Windows? from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Lint, Windows, Arcanist
epriestley added a parent task for T3271: Before launching $EDITOR from arc, print that we're doing it: T13098: Plans: Arcanist toolsets and extensions.
Oct 2 2018, 12:56 PM · Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T9444: The function phutil_console_get_terminal_width needs to work with Windows.
Oct 2 2018, 12:54 PM · Arcanist, Windows
epriestley added a parent task for T9444: The function phutil_console_get_terminal_width needs to work with Windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:54 PM · Windows, libphutil
epriestley added a parent task for T5724: ANSI color escape sequences seem broken for arc in git bash on windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:53 PM · Windows, Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T5724: ANSI color escape sequences seem broken for arc in git bash on windows.
Oct 2 2018, 12:53 PM · Arcanist, Windows
epriestley merged T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows into T5724: ANSI color escape sequences seem broken for arc in git bash on windows.
Oct 2 2018, 12:53 PM · Windows, Arcanist
epriestley closed T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows as Invalid.

No clue how to reproduce this.

Oct 2 2018, 12:51 PM · Windows, Bug Report (Needs Information)
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:50 PM · Arcanist, Windows
epriestley closed T8821: arc commands (diff, version) fails on Windows - terrible fix inside as Resolved.

I believe this is essentially just T13209.

Oct 2 2018, 12:50 PM · Windows, libphutil, Arcanist
epriestley closed T8821: arc commands (diff, version) fails on Windows - terrible fix inside, a subtask of T13209: How To Properly Escape Commands on Windows (A Dark Tragedy), as Resolved.
Oct 2 2018, 12:50 PM · Arcanist, Windows
epriestley added a parent task for T8821: arc commands (diff, version) fails on Windows - terrible fix inside: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:49 PM · Windows, libphutil, Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T8821: arc commands (diff, version) fails on Windows - terrible fix inside.
Oct 2 2018, 12:49 PM · Arcanist, Windows
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`, a subtask of T3272: Route ExecFuture stdout/stderr through the filesystem on Windows, as Resolved.
Oct 2 2018, 12:48 PM · Windows, Arcanist
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint` as Resolved.

Changes in T13209 make this the only mode.

Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a parent task for T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`: T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a subtask for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows: T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`.
Oct 2 2018, 12:48 PM · Windows, Arcanist
epriestley closed T3272: Route ExecFuture stdout/stderr through the filesystem on Windows as Resolved.
Oct 2 2018, 12:48 PM · Windows, Arcanist
epriestley closed T3272: Route ExecFuture stdout/stderr through the filesystem on Windows, a subtask of T13209: How To Properly Escape Commands on Windows (A Dark Tragedy), as Resolved.
Oct 2 2018, 12:48 PM · Arcanist, Windows
epriestley added a parent task for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:47 PM · Windows, Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Oct 2 2018, 12:47 PM · Arcanist, Windows
epriestley added a comment to T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.

D11688 implemented this.

Oct 2 2018, 12:47 PM · Windows, Arcanist
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I think I'm done for the night, but we're down to 18 failing tests under Windows.

Oct 2 2018, 2:03 AM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

PHP7 introduces random_bytes(), which is a more accessible pseudorandom source on Windows than the other sources we use.

Oct 2 2018, 1:55 AM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

ArcanistLinterTestCase->lintFile() has a bug where it does this:

Oct 2 2018, 1:27 AM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

A lot of tests fail on Windows if core.autocrlf is set to convert "\n" line endings to "\r\n" line endings on checkout, which is the default behavior. In theory, this is fixable, but I'm not sure it's really worthwhile. At the least, I first want to get things passing without dealing with these tests.

Oct 2 2018, 1:08 AM · Arcanist, Windows

Oct 1 2018

epriestley closed T8298: Fix Windows Escaping as Resolved.

Evolved into T13209.

Oct 1 2018, 11:42 PM · Windows
epriestley closed T8298: Fix Windows Escaping, a subtask of T8291: arc version fails on Windows, as Resolved.
Oct 1 2018, 11:42 PM · Windows, Arcanist
epriestley closed T8298: Fix Windows Escaping, a subtask of T6966: Windows quoting conventions still bad, as Resolved.
Oct 1 2018, 11:42 PM · Windows, Arcanist
epriestley added a parent task for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T13098: Plans: Arcanist toolsets and extensions.
Oct 1 2018, 11:40 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

On startup on Windows, arc currently complains that cURL isn't enabled. It gives you some okay-ish instructions for enabling it.

Oct 1 2018, 11:18 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I'm currently trying to update my Surface Pro so I can look at making arc unit in the wilds branch pass on Windows. I've restarted to install more updates about 5 times, am currently stuck at "Feature update to Windows 10, version 1803 - Downloading - 0%" which appears to just be not working.

Oct 1 2018, 10:56 PM · Arcanist, Windows
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 10:35 PM · Arcanist, Windows
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 9:14 PM · Arcanist, Windows
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 7:42 PM · Arcanist, Windows
epriestley triaged T13209: How To Properly Escape Commands on Windows (A Dark Tragedy) as Normal priority.
Oct 1 2018, 6:38 PM · Arcanist, Windows

Aug 16 2018

epriestley changed the visibility for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Aug 16 2018, 2:39 AM · Windows, Arcanist

Aug 15 2018

epriestley closed T9459: arc upgrade on Windows doesn't understand it's a git repo as Resolved by committing rPHU5b341cc09ca9: Fix Filesytem::walkToRoot() on Windows with default ("/") root.
Aug 15 2018, 11:57 PM · Arcanist, Windows
epriestley added a revision to T9459: arc upgrade on Windows doesn't understand it's a git repo: D19591: Fix Filesytem::walkToRoot() on Windows with default ("/") root.
Aug 15 2018, 5:44 PM · Arcanist, Windows

Jan 4 2018

epriestley merged T6112: Arcanist can not upload binaries when use Mercurial on Windows into T8298: Fix Windows Escaping.
Jan 4 2018, 7:14 PM · Windows

Sep 2 2017

epriestley closed T8291: arc version fails on Windows as Resolved by committing rARCd9cb5b18fbc1: Cheat our way through `arc version` on Windows for the moment.
Sep 2 2017, 1:06 AM · Windows, Arcanist
epriestley added a revision to T8291: arc version fails on Windows: D18518: Cheat our way through `arc version` on Windows for the moment.
Sep 2 2017, 1:04 AM · Windows, Arcanist
epriestley claimed T8291: arc version fails on Windows.

See also PHI52.

Sep 2 2017, 12:06 AM · Windows, Arcanist

Jul 11 2017

chad merged task T11152: Some workflows of arc are broken on Windows into T8291: arc version fails on Windows.
Jul 11 2017, 11:31 PM · Arcanist, Windows, Bug Report
chad merged T11152: Some workflows of arc are broken on Windows into T8291: arc version fails on Windows.
Jul 11 2017, 11:31 PM · Windows, Arcanist
chad merged T12914: Arcanist in Windows: ERROR 8: Undefined offset into T8821: arc commands (diff, version) fails on Windows - terrible fix inside.
Jul 11 2017, 11:30 PM · Windows, libphutil, Arcanist
chad merged T12913: `arc version` throws exception into T8291: arc version fails on Windows.
Jul 11 2017, 11:29 PM · Windows, Arcanist

Jul 9 2017

chad removed the image for Windows.
Jul 9 2017, 7:43 PM

May 11 2017

• david.lebert.60 removed a watcher for Windows: • david.lebert.60.
May 11 2017, 2:53 PM
• david.lebert.60 added a watcher for Windows: • david.lebert.60.
May 11 2017, 2:52 PM

May 8 2017

cxzzero added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

Thanks, let me check that task and I tell you.

May 8 2017, 7:18 PM · Windows, Bug Report (Needs Information)
avivey added a comment to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows.

This might be a variant of T2465. There's some workaround described there that might help.

May 8 2017, 5:59 PM · Windows, Bug Report (Needs Information)
avivey added a project to T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows: Windows.
May 8 2017, 5:56 PM · Windows, Bug Report (Needs Information)

Apr 12 2017

epriestley removed a project from T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD"): Support Impact.
Apr 12 2017, 2:48 PM · Windows, Arcanist

Feb 14 2017

farrago added a comment to T8298: Fix Windows Escaping.

Just a quick note to say that I have been using @BYK 's D15675, D15676 and D15693 for over a month now with no issues, so would be in favour of them being merged in.
Setup:

  • Windows 10 x64,
  • standalone cmd.exe
  • cmd.exe through ConEmu
  • git repos hosteded locally in phabricator (running on Ubuntu server)
  • relatively straightforward use of arc feature, arc diff and arc land
Feb 14 2017, 3:27 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

@chad - How can I be involved with any progress on this front then since now it is planned?

Feb 14 2017, 8:29 AM · Windows
chad added a comment to T8298: Fix Windows Escaping.

See T11429

Feb 14 2017, 7:20 AM · Windows
OCram added a comment to T8298: Fix Windows Escaping.

Do you think there are any intentions to fix this issue for windows users? At least in far future?
Me and my colleges are still working with an old arcanist version 737f5c0d. If this workaround breaks, there would be no way for windows users to work with arcanist. Except using a fork containing D15675.

Feb 14 2017, 7:08 AM · Windows
Next
Phabricator · Built by Phacility