Page MenuHomePhabricator

Update some ancient "set X=Y" environment code for new Windows execution without a shell
ClosedPublic

Authored by epriestley on Apr 2 2020, 8:43 PM.
Tags
None
Referenced Files
F15544304: D21052.id50153.diff
Sat, Apr 26, 4:12 AM
F15538116: D21052.diff
Thu, Apr 24, 5:27 PM
F15519856: D21052.id50155.diff
Sun, Apr 20, 12:16 AM
F15513197: D21052.id.diff
Thu, Apr 17, 5:12 PM
F15510925: D21052.diff
Wed, Apr 16, 10:04 PM
F15490067: D21052.diff
Fri, Apr 11, 2:04 PM
F15464311: D21052.id50153.diff
Wed, Apr 2, 8:19 AM
F15420525: D21052.id.diff
Mar 21 2025, 2:38 PM
Subscribers
None

Details

Summary

Depends on D21051. Ref T13504. Ref T13209. This very old Mercurial code uses "X=Y hg ..." on Linux and "set X=Y & hg ..." on Windows.

The latter construct no longer works because we bypass the shell. The former construct is obsolete.

Additionaly, delete some ancient "branch merge" code which has no callers.

Test Plan

Created a diff in a Mercurial repository on Linux. I minimally vetted this on Windows since I don't have a "hg + Windows" environment at the moment.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 8:51 PM
This revision was automatically updated to reflect the committed changes.