Page MenuHomePhabricator

[Wilds] Stop writing temporary files for linter tests
ClosedPublic

Authored by epriestley on Oct 2 2018, 6:35 PM.

Details

Summary

Ref T13209. See some discussion in T13209#241713.

There's a bug here where 0644 (a numeric literal written in octal) should be '0644' (a string literal). This caused the TempFile to fail to unlink() on Windows.

But with ArcanistWorkingCopyPath we don't have to write an actual file to disk at all, so just don't. Maybe we'll start doing this some of the time later on (e.g., to make it easier to test third-party linters which do not have a "read from stdin" mode), but ideally we shouldn't need to actually write to disk in order to test that linters work, at least in most cases.

Also fix the octal bug itself.

Test Plan

Under Windows, more tests pass and there's no more unlink() permissions error.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 2 2018, 6:35 PM
epriestley requested review of this revision.
amckinley accepted this revision.Oct 2 2018, 7:56 PM
This revision is now accepted and ready to land.Oct 2 2018, 7:56 PM
This revision was automatically updated to reflect the committed changes.