[Wilds] Use "random_bytes()" if it is available (after PHP7)
ClosedPublic
Actions

Authored by epriestley on Oct 2 2018, 6:08 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13209: How To Properly Escape Commands on Windows (A Dark Tragedy)

Commits

rARC5a4c489916e8: [Wilds] Use "random_bytes()" if it is available (after PHP7)

Summary

Ref T13209. In PHP7 and newer, the function random_bytes() gives us simple access to cryptographic randomness across platforms. Prefer it if it's available.

Notably, the other sources often aren't available on Windows, and particularly aren't available on a clean/default install with modern software versions. So the major motivation is to make things work better out-of-the-box on Windows.

Test Plan

On Windows, saw Filesystem unit tests which call readRandomBytes() now pass.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 2 2018, 6:08 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 2 2018, 6:08 PM

Harbormaster failed remote builds in B20977: Diff 47135!

More correct fix for error message.

epriestley marked an inline comment as done.Oct 2 2018, 6:11 PM

epriestley added inline comments.

src/filesystem/Filesystem.php
484	This just printed "s", not "%s". (Since I think it's unlikely that we'll ever have untrusted, non-technical translators work with this codebase I'm generally inclined to think we should just embed strings like this in the text rather than parameterize them. Embedded strings are simpler for us to work with, avoid mistakes like this one, and it seems unlikely that a translator would incorrectly translate this string into another language by mistake.)