Page MenuHomePhabricator
Feed Advanced Search

Jun 27 2017

marcoscorvalan created T12874: HOw to see ALL user Keys uploaded.
Jun 27 2017, 3:18 PM · Feature Request
chad added a comment to T12873: Ability to display custom message during externally linked login prompt.

/config/edit/translation.override/ then add the string, and what you want it to say instead. That's the quickest path here. Merging into the other request.

Jun 27 2017, 10:53 AM · Feature Request
chad merged T12873: Ability to display custom message during externally linked login prompt into T11514: Authentication should have a way to customize the credentials name.
Jun 27 2017, 10:50 AM · Auth, LDAP, Feature Request
chad merged task T12873: Ability to display custom message during externally linked login prompt into T11514: Authentication should have a way to customize the credentials name.
Jun 27 2017, 10:50 AM · Feature Request
chad added a comment to T12873: Ability to display custom message during externally linked login prompt.

Can you be more specific here? If you just want to rename "LDAP Login" you can already do that with the translation framework.

Jun 27 2017, 10:39 AM · Feature Request
StingRayZA created T12873: Ability to display custom message during externally linked login prompt.
Jun 27 2017, 9:18 AM · Feature Request

Jun 23 2017

epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it's currently expected, yes. We don't create branches for dependencies in Git either, currently. I don't think this is terribly unreasonable, but I'm also not sure it's terribly useful (does it just help you keep track of which commits are part of the leaf?) and it makes cleanup more difficult by creating more total branch/bookmark artifacts in the local working copy.

Jun 23 2017, 11:39 PM · Arcanist, Mercurial, Feature Request
cspeckmim added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

For (1), it is expected to not apply bookmarks to dependency changesets that are applied as part of the patch issued? When patched one-by-one they would each obtain their bookmark.

Jun 23 2017, 11:29 PM · Arcanist, Mercurial, Feature Request
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Sorry, I should have led with a screenshot! I'm the biggest nitpicker, I know.

Jun 23 2017, 5:48 PM · Remarkup, Feature Request
epriestley added a comment to T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.

Some of the (3), (2), (1) stuff is that we're trying to pick a single behavior which addresses most use cases reasonably well. For example, if we use "natural" bookmark names that will tend to make things much worse for users in bucket (3).

Jun 23 2017, 4:48 PM · Arcanist, Mercurial, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

Thanks, that's much more clear than the original description!

Jun 23 2017, 4:42 PM · Remarkup, Feature Request
mcorteel added a comment to T12865: Strikethrough for icons in checked remarkup list items.

No they're not. I know it's a tiny difference, but look at this closely (left is my proposal, right is the current state):

Spectacle.eD1745.png (147×463 px, 9 KB)

Jun 23 2017, 4:41 PM · Remarkup, Feature Request
epriestley triaged T12866: Batch repository editing or repository groups for shared access control settings as Low priority.
Jun 23 2017, 4:18 PM · Diffusion, Feature Request
epriestley added a comment to T12865: Strikethrough for icons in checked remarkup list items.

I'm confused here -- the icons are already struck in every browser on my system (Safari, Firefox, Chrome):

Jun 23 2017, 4:18 PM · Remarkup, Feature Request
epriestley added a comment to T12866: Batch repository editing or repository groups for shared access control settings.

See also T10005 (bulk editors for all applications) and T6722.

Jun 23 2017, 1:38 PM · Diffusion, Feature Request
chad merged task T12868: Highlight and link URI's in review titles into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jun 23 2017, 6:29 AM · Diffusion, Differential, Feature Request
jcarrillo7 created T12868: Highlight and link URI's in review titles.
Jun 23 2017, 6:25 AM · Diffusion, Differential, Feature Request

Jun 22 2017

avivey added a parent task for T12866: Batch repository editing or repository groups for shared access control settings: T9287: Working with many repositories.
Jun 22 2017, 7:26 PM · Diffusion, Feature Request
chad updated the task description for T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 7:25 PM · Remarkup, Feature Request
jcarrillo7 updated the task description for T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:20 PM · Diffusion, Feature Request
jcarrillo7 added a project to T12866: Batch repository editing or repository groups for shared access control settings: Diffusion.
Jun 22 2017, 7:19 PM · Diffusion, Feature Request
jcarrillo7 created T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:19 PM · Diffusion, Feature Request
1 added a comment to T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 6:11 PM · Remarkup, Feature Request
mcorteel created T12865: Strikethrough for icons in checked remarkup list items.
Jun 22 2017, 8:24 AM · Remarkup, Feature Request

Jun 21 2017

chad added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Just to clarify, Phacility is the paid hosted version of Phabricator. If you installed Phabricator locally, we cannot help you with this request via Phacility. You'll need to follow Support Resources for your self-hosted installation.

Jun 21 2017, 6:35 PM · Phacility, Feature Request
epriestley added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Great! Please mail support at support@phacility.com and identify which instance you're paying us for, then we're happy to help you. We won't help you here, since this isn't the right way for customers to get support.

Jun 21 2017, 6:27 PM · Phacility, Feature Request
sencho added a comment to T12861: How to intergrate Infer's analysis result into Phabricator?.

Yes,we are Phacility customer And I deployed it on a Ubuntu server,Thank you.

Jun 21 2017, 5:42 PM · Phacility, Feature Request
epriestley merged T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Restricted Project, Diffusion, Feature Request
epriestley merged task T12862: Diffusion: change to a flat project structure view into T10767: fold empty directories in Browse view.
Jun 21 2017, 5:23 PM · Diffusion, Feature Request
epriestley closed T12861: How to intergrate Infer's analysis result into Phabricator? as Invalid.

If you're a Phacility customer, please mail support at support@phacility.com (and identify your instance).

Jun 21 2017, 5:22 PM · Phacility, Feature Request
bhchandra added a project to T12862: Diffusion: change to a flat project structure view: Diffusion.
Jun 21 2017, 5:18 PM · Diffusion, Feature Request
sencho added a project to T12861: How to intergrate Infer's analysis result into Phabricator?: Phacility.
Jun 21 2017, 5:17 PM · Phacility, Feature Request
bhchandra created T12862: Diffusion: change to a flat project structure view.
Jun 21 2017, 5:17 PM · Diffusion, Feature Request
sencho created T12861: How to intergrate Infer's analysis result into Phabricator?.
Jun 21 2017, 5:15 PM · Phacility, Feature Request

Jun 19 2017

vanto- added a comment to T12852: just test.

haha

Jun 19 2017, 7:38 AM
vanto- created T12852: just test.
Jun 19 2017, 7:37 AM

Jun 18 2017

kszatan added a comment to T12813: Integrate Harbormaster with GoCD.

I was going to wait with updating this task until I'm finished but I'm stuck on GoCD side for some time. The extension for Phabricator is 99% ready so anyone interested may give it a try:
https://github.com/kszatan/harbormaster-gocd-buildstep
It's enough to be able to schedule a pipeline in GoCD but nothing more. This issue hampers my progress with notifying Harbormaster about pipeline status. I'll update this task when all is working as planned.

Jun 18 2017, 9:00 PM · Harbormaster, Feature Request
waxmigs2902 added a comment to T10605: Implement setOriginalText() and setReplacementText() in RuboCop driver.

done! cheers

Jun 18 2017, 11:38 AM · Lint, Feature Request

Jun 16 2017

charlax added a comment to T12843: Add support for creating workboard columns from the Conduit API.

Milestones works great for this, but you still have to manually create the workboard (just going into workboard and clicking create - milestones show up).

Jun 16 2017, 1:59 PM · Conduit, Projects, Workboards, Feature Request

Jun 14 2017

jboning updated subscribers of T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

I'm not totally sure about how/why users are expecting the behavior in the third case.

Jun 14 2017, 10:13 PM · Restricted Project, Feature Request
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

I'm not particularly strongly opposed to adding more options here, I just want to avoid the dropdown becoming this:

Jun 14 2017, 10:08 PM · Restricted Project, Feature Request
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

For the compliance case, you should already be able to trigger this stronger rule ("always add the package as a reviewer, even if an owner authored it") with Herald, by writing this rule:

Jun 14 2017, 9:58 PM · Restricted Project, Feature Request
neilfitz added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

As more of a point of philosophy of code review also, I (and, I think, my teammates) would say that diffs should be reviewed by someone who both:

  1. Understands the relevant code
  2. Did not write the code themselves

In other words, the combination of expertise + different perspective is of value beyond each component individually. If you believe that, then B or C should review A's diff in this case.

Jun 14 2017, 9:56 PM · Restricted Project, Feature Request
jboning added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

When you put it that way, it does seem backwards.

Jun 14 2017, 9:31 PM · Restricted Project, Feature Request
epriestley added a comment to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package.

The use case in this task's description does not make sense to me.

Jun 14 2017, 7:28 PM · Restricted Project, Feature Request
jboning added a project to T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package: Restricted Project.

We're interested in this option, since we find that users are often surprised by the existing behaviour. I think this would make sense as a per-package setting, rather than a global one.

Jun 14 2017, 5:57 PM · Restricted Project, Feature Request
20after4 added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

It would be really nice to default newly added fields to hidden. Going through 20+ forms to hide the fields is tedious.

Jun 14 2017, 3:06 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12843: Add support for creating workboard columns from the Conduit API.

We do something similar ourselves for technical interviews, but I just related all the tasks by embedding them in the description of a central task:

Jun 14 2017, 12:15 PM · Conduit, Projects, Workboards, Feature Request
epriestley added a project to T12843: Add support for creating workboard columns from the Conduit API: Conduit.
Jun 14 2017, 12:08 PM · Conduit, Projects, Workboards, Feature Request
epriestley added projects to T12843: Add support for creating workboard columns from the Conduit API: Workboards, Projects.

I think this use case is a reasonable one.

Jun 14 2017, 12:08 PM · Conduit, Projects, Workboards, Feature Request
charlax added a comment to T12843: Add support for creating workboard columns from the Conduit API.

Just discovered I could use the Milestones feature to do that. Will try this out.

Jun 14 2017, 9:51 AM · Conduit, Projects, Workboards, Feature Request
charlax created T12843: Add support for creating workboard columns from the Conduit API.
Jun 14 2017, 9:45 AM · Conduit, Projects, Workboards, Feature Request
cspeckmim created T12842: Some improvements to Mercurial, Arcanist, and Dependent Revisions.
Jun 14 2017, 3:08 AM · Arcanist, Mercurial, Feature Request

Jun 13 2017

epriestley closed T12834: Set new hourly rate for our new colleague as Invalid.
Jun 13 2017, 9:47 AM · Feature Request
banica moved T12834: Set new hourly rate for our new colleague from Needs Information to Backlog on the Feature Request board.
Jun 13 2017, 8:59 AM · Feature Request
banica moved T12834: Set new hourly rate for our new colleague from Backlog to Future on the Feature Request board.
Jun 13 2017, 8:58 AM · Feature Request
banica updated subscribers of T12834: Set new hourly rate for our new colleague.
Jun 13 2017, 8:57 AM · Feature Request
banica added a comment to T12834: Set new hourly rate for our new colleague.

Set new action

Jun 13 2017, 8:54 AM · Feature Request
banica created T12834: Set new hourly rate for our new colleague.
Jun 13 2017, 8:54 AM · Feature Request

Jun 12 2017

avivey added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

Two questions pick at me:

  1. Which editor did the user use to add the ZWS in? Any editor I remember does something to warn you about it.
  2. Why are there Unicode characters for "goat" (🐐) and for "cooked rice" (🍚)?
Jun 12 2017, 10:27 PM · Differential
epriestley added a comment to T11150: ArcanistTextLinter: Support UTF8.

On a purely personal/aesthetic level, the box-drawing character block is total garbage and master ASCII artisans would never use it in serious work. A true connoisseur of the craft should accept nothing more than single-byte ASCII range in their collection.

Jun 12 2017, 2:13 PM · Restricted Project, Lint, Feature Request
epriestley added a comment to T11150: ArcanistTextLinter: Support UTF8.

See some related discussion in T12822. In particular:

Jun 12 2017, 2:06 PM · Restricted Project, Lint, Feature Request
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

me too but not everyone is on our level

Jun 12 2017, 1:51 PM · Differential
chad added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

FWIW I only code via copy/paste.

Jun 12 2017, 1:49 PM · Differential
epriestley added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.
Jun 12 2017, 1:44 PM · Differential
epriestley added a project to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery: Customer Impact.

Per above, these are already detected by the Text linter:

Jun 12 2017, 1:36 PM · Differential

Jun 11 2017

avivey added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

I think that ArcanistTextLinter actually checks for ASCII right now, so it should be easy to enable for this case. See also D6050, which discusses selecting encoding for it.

Jun 11 2017, 7:19 PM · Differential
johnny-bit added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

well script-and-regex is NOT anything complex... or you can try and add zero-widht-space as a rule to arcanist Text linter or make own linter extension... anything is good ;)

Jun 11 2017, 3:56 PM · Differential
chad added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

Anything programmatically detectable should be raised through lint. Asking humans to detect it is still likely to not solve the core problem since they'll always be less reliable. .

Jun 11 2017, 1:48 PM · Differential
brunobowden created T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.
Jun 11 2017, 6:40 AM · Differential

Jun 10 2017

chad closed T12820: test as Spite.

nyancat

Jun 10 2017, 3:17 PM · Feature Request
steve8924 created T12820: test.
Jun 10 2017, 3:10 PM · Feature Request

Jun 9 2017

epriestley closed T12650: Allow setting --delete-remote on .arcrc as Invalid.

Arc supports auto-deleting the remote branch as well as the local one

Jun 9 2017, 1:56 PM · Feature Request

Jun 8 2017

kszatan added a comment to T12813: Integrate Harbormaster with GoCD.

Great! I was hoping this could be done with some kind of a plugin/extension. I'll look into it and let you know when I have a working solution.

Jun 8 2017, 9:06 PM · Harbormaster, Feature Request
epriestley added a comment to T12813: Integrate Harbormaster with GoCD.

To set expectations, this is an exceedingly low priority for the upstream and these tasks basically only move forward when an existing customer requests integrations.

Jun 8 2017, 9:04 PM · Harbormaster, Feature Request
epriestley merged task T12812: Make it possible to send HTTP headers in Harbormaster's "Make HTTP Request" build step into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Jun 8 2017, 9:01 PM · Harbormaster, Feature Request
epriestley added a project to T12813: Integrate Harbormaster with GoCD: Harbormaster.
Jun 8 2017, 9:00 PM · Harbormaster, Feature Request
epriestley triaged T12813: Integrate Harbormaster with GoCD as Wishlist priority.
Jun 8 2017, 9:00 PM · Harbormaster, Feature Request
epriestley added a parent task for T12813: Integrate Harbormaster with GoCD: T9456: Evaluate upstream support for third-party build systems.
Jun 8 2017, 8:59 PM · Harbormaster, Feature Request
kszatan created T12813: Integrate Harbormaster with GoCD.
Jun 8 2017, 8:56 PM · Harbormaster, Feature Request
kszatan created T12812: Make it possible to send HTTP headers in Harbormaster's "Make HTTP Request" build step.
Jun 8 2017, 8:49 PM · Harbormaster, Feature Request
epriestley closed T11509: Provide a way to quickly see if all comments on a diff have been marked as "done" as Resolved.

This is now available in HEAD. See M1476 for a mock. The actual feature doesn't quite look like that yet since the buttons use generic styles, but should soon (see also T12688).

Jun 8 2017, 11:54 AM · Inline Comments, Differential, Restricted Project, Feature Request
epriestley added a project to T11509: Provide a way to quickly see if all comments on a diff have been marked as "done": Inline Comments.
Jun 8 2017, 11:52 AM · Inline Comments, Differential, Restricted Project, Feature Request

Jun 7 2017

alexmv added a comment to T12809: Pass through MySQL commands via bin/storage.

Noted, OK. We'll proceed by adding our own local ./bin/storage endpoint for it.

Jun 7 2017, 11:20 PM · Restricted Project, Feature Request
epriestley added a comment to T12809: Pass through MySQL commands via bin/storage.

Yes. (That is, I'm adverse to upstreaming this.)

Jun 7 2017, 11:02 PM · Restricted Project, Feature Request
alexmv added a comment to T12809: Pass through MySQL commands via bin/storage.

Would you be adverse to accepting a patch that does this?

Jun 7 2017, 10:52 PM · Restricted Project, Feature Request
epriestley closed T12809: Pass through MySQL commands via bin/storage as Invalid.

"Wait for T12681, then pay us a lot of money." See also T12778.

Jun 7 2017, 10:36 PM · Restricted Project, Feature Request
epriestley added a project to T12809: Pass through MySQL commands via bin/storage: Restricted Project.
Jun 7 2017, 10:15 PM · Restricted Project, Feature Request
sakura updated subscribers of T12809: Pass through MySQL commands via bin/storage.
Jun 7 2017, 9:49 PM · Restricted Project, Feature Request
sakura created T12809: Pass through MySQL commands via bin/storage.
Jun 7 2017, 9:49 PM · Restricted Project, Feature Request
epriestley closed T12234: Add a "Duplicates" tab to the "Related Objects" section on task page as Resolved.

This is now deployed here, to secure.

Jun 7 2017, 9:10 PM · Customer Impact, Feature Request
avivey closed T12805: Auth0 Auth Provider / Auth0 Integration for Authentication as Invalid.

Please see Contributing Feature Requests for instructions on how to file a constructive feature request.

Jun 7 2017, 7:58 AM · Feature Request
vallabh created T12805: Auth0 Auth Provider / Auth0 Integration for Authentication.
Jun 7 2017, 6:57 AM · Feature Request
chad moved T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way from Backlog to UI Refresh on the Diffusion board.
Jun 7 2017, 2:57 AM · Diffusion, Feature Request

Jun 6 2017

janitorial added a comment to T12144: Ability to reorder milestones on a project's workboard.

Why would you want to set those up as milestones instead of subprojects?

Jun 6 2017, 9:25 PM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

It doesn't help that GH/GL Milestones are loose tags with a target date.

Jun 6 2017, 8:19 PM · Projects, Feature Request
epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

We could also let you collapse/expand columns like your mock in T6642. None of this hide/show/filter/collapse/expand stuff is hard -- T11036 and T4900/T10336 are the only really involved JS changes in queue for workboards, I think. It's largely just not clear to me which subset of the proposed tools is most useful, and it feel like major overkill to implement all of them.

Jun 6 2017, 7:31 PM · Projects, Feature Request
epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

But it's mostly moot until T11036 I think. T5024 is vaguely related ("filter to just one column"). T6642 might be related ("save collections of columns") but my recollection is that task was a bit muddy? I haven't re-read it recently.

Jun 6 2017, 7:28 PM · Projects, Feature Request
epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

That's very easy, just a question of whether we want to add the buttons/menu items for it.

Jun 6 2017, 7:27 PM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

Yeah there are some UI tweaks I can do to dissuade accidental milestone creation.

Jun 6 2017, 7:27 PM · Projects, Feature Request