Page MenuHomePhabricator
Feed Advanced Search

Mar 11 2021

epriestley closed T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully as Resolved by committing rP32da29b96569: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE….
Mar 11 2021, 10:55 PM · Installing & Upgrading, Database
epriestley added a revision to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully: D21608: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission.
Mar 11 2021, 10:32 PM · Installing & Upgrading, Database
epriestley added a comment to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully.

There are also already a bunch of tailored messages in other context:

Mar 11 2021, 10:30 PM · Installing & Upgrading, Database
epriestley added a comment to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully.

I looked into this briefly, but I can't find a simple way to show all the current user's database permissions.

Mar 11 2021, 10:14 PM · Installing & Upgrading, Database
epriestley moved T12965: When no "master" database is configured, the ElasticSearch setup check can fatal from Backlog to External Search on the Search board.
Mar 11 2021, 5:49 PM · Database, Clusters, Search

Feb 26 2021

epriestley triaged T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully as Wishlist priority.
Feb 26 2021, 6:24 PM · Installing & Upgrading, Database

Feb 19 2021

epriestley closed T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php" as Resolved.

That covered everything that looked low-hanging.

Feb 19 2021, 4:35 PM · Database, Differential
epriestley added a revision to T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php": D21570: Improve performance of "phabricator:20210215.changeset.02.phid-populate.php".
Feb 19 2021, 3:48 PM · Database, Differential
epriestley updated the task description for T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php".
Feb 19 2021, 3:21 PM · Database, Differential
epriestley triaged T13613: Improve performance of bulk PHID assignment, particularly for "phabricator:20210215.changeset.02.phid-populate.php" as Low priority.
Feb 19 2021, 3:21 PM · Database, Differential

Sep 13 2019

epriestley triaged T13417: "bin/storage upgrade" should test for replication problems before applying migrations as Low priority.
Sep 13 2019, 7:31 PM · Database

Sep 8 2019

epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: D20791: Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES".
Sep 8 2019, 8:02 PM · Database, Infrastructure
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: D20790: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES".
Sep 8 2019, 7:59 PM · Database, Infrastructure
epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Vaguely adjacent:

Sep 8 2019, 7:27 PM · Database, Infrastructure

Sep 7 2019

swisspol added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

Now that we are on RDS I can confirm that MySQL also has ONLY_FULL_GROUP_BY enabled by default.

Sep 7 2019, 1:55 AM · Database, Infrastructure

Sep 4 2019

swisspol added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

That actually using MySQL official Docker image.

Sep 4 2019, 3:12 AM · Database, Infrastructure

Sep 3 2019

epriestley added a comment to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY.

There are only 23 occurrences of the string "GROUP BY" in the codebase, and, from inspection, many obviously do not conflict with ONLY_FULL_GROUP_BY.

Sep 3 2019, 11:54 PM · Database, Infrastructure
epriestley added a revision to T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY: D20782: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries.
Sep 3 2019, 11:43 PM · Database, Infrastructure
epriestley triaged T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY as Wishlist priority.
Sep 3 2019, 11:23 PM · Database, Infrastructure
epriestley closed T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Resolved.
Sep 3 2019, 7:54 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20781: Use the "@" operator to silence connection retry messages if initializing the stack with database config optional.
Sep 3 2019, 7:26 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20780: When "mysqli->real_connect()" fails without setting an error code, recover more gracefully.
Sep 3 2019, 7:23 PM · Database, Config
epriestley added a revision to T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues: D20779: Give "bin/config" a friendlier error message if "local.json" is not writable.
Sep 3 2019, 7:19 PM · Database, Config
epriestley triaged T13403: "mysqli->real_connect()" can fail awkwardly without setting "error_code", plus bonus issues as Low priority.
Sep 3 2019, 7:05 PM · Database, Config

Sep 1 2019

epriestley added a comment to T13400: Evaluate performance impact of performing MySQL dump/restore in parallel.

Anecdata: locally, using 2 subprocesses went twice as fast (~85s -> ~42s). 4 subprocesses chopped another ~20% of the time off (~42s > ~35s). It stopped getting faster at 4. However, the largest table took 24s, so even if this was completely parallelizable we wouldn't expect it to drop lower than that.

Sep 1 2019, 11:19 PM · Infrastructure, Database

Aug 31 2019

epriestley triaged T13400: Evaluate performance impact of performing MySQL dump/restore in parallel as Wishlist priority.
Aug 31 2019, 4:04 PM · Infrastructure, Database

Jun 19 2019

epriestley added a comment to T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks.

Getting rid of the indirect writes on handle reads would probably be nice eventually, but doesn't directly accomplish anything today.

Jun 19 2019, 5:30 PM · Installing & Upgrading, Database

Jun 18 2019

epriestley closed T13304: Phabricator "Backups" instructions are somewhat out of date as Resolved by committing rP6219d30f6b0b: Recommend dumping database backups with "--compress --output X" instead of "|….
Jun 18 2019, 6:37 PM · Database

Jun 5 2019

epriestley added a revision to T13304: Phabricator "Backups" instructions are somewhat out of date: D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X".
Jun 5 2019, 10:00 PM · Database
epriestley added a revision to T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks: D20570: Skip loading transaction handles in an old migration.
Jun 5 2019, 6:43 PM · Installing & Upgrading, Database
epriestley added a comment to T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks.

I applied this change to 20180208.maniphest.02.populate.php:

Jun 5 2019, 5:24 PM · Installing & Upgrading, Database
epriestley created T13305: Migration "20180208.maniphest.02.populate.php" may fail when queueing indexing tasks.
Jun 5 2019, 5:18 PM · Installing & Upgrading, Database
epriestley created T13304: Phabricator "Backups" instructions are somewhat out of date.
Jun 5 2019, 3:26 PM · Database

Apr 15 2019

epriestley closed T8476: Rename `phabricator_repository` database as Wontfix.

This remains desirable, but probably won't happen without a stronger motivator since the patches are somewhat involved.

Apr 15 2019, 4:01 PM · Restricted Project, Database, Diffusion

Jan 18 2019

epriestley closed T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB as Resolved.

Nothing really actionable here.

Jan 18 2019, 9:03 PM · Database

Aug 30 2018

epriestley updated the task description for T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB.
Aug 30 2018, 1:24 PM · Database
epriestley triaged T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB as Low priority.
Aug 30 2018, 1:10 PM · Database
epriestley created T13193: Dropping a column which is a component of a UNIQUE KEY has surprising behavior in MariaDB.
Aug 30 2018, 1:10 PM · Database

Aug 22 2018

jasonyoung added a comment to T6931: Support SSL connections to MySQL.
  • your business faces regulatory/compliance issues which are satisfied by encrypting the connection, even if it provides no direct security benefit.
Aug 22 2018, 3:19 PM · Database

Mar 18 2018

mydeveloperday added a comment to T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).

I don't run my Phabricator instance on Ubuntu but instead on RHEL6 (and with PHP7, which I know isn't officially support)

Mar 18 2018, 12:19 PM · Database, Infrastructure

Mar 13 2018

epriestley closed T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async) as Resolved by committing rP0bf8e33bb6c1: Issue setup guidance recommending MySQLi and MySQL Native Driver.
Mar 13 2018, 7:38 PM · Database, Infrastructure
epriestley added a comment to T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).

(I'll follow up in T13102 if there's more to be done here, it's possible that some installs are missing this for reasons other than "Ubuntu + apt get install php5-mysql").

Mar 13 2018, 7:38 PM · Database, Infrastructure
epriestley added a revision to T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async): D19216: Issue setup guidance recommending MySQLi and MySQL Native Driver.
Mar 13 2018, 7:35 PM · Database, Infrastructure

Sep 20 2017

epriestley created T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).
Sep 20 2017, 7:28 PM · Database, Infrastructure

Sep 11 2017

epriestley closed T10773: When the search table is marked as crashed, bin/storage should automatically repair it as Wontfix.

We generally stopped seeing this after moving to InnoDB FULLTEXT, which seems less prone to table crashes than MyISAM FULLTEXT was. See also T12819 for the fate of InnoDB FULLTEXT.

Sep 11 2017, 12:02 PM · Database, Feature Request

Aug 30 2017

20after4 added a comment to T12965: When no "master" database is configured, the ElasticSearch setup check can fatal.

Whoops this is probably my bad :-/

Aug 30 2017, 1:07 PM · Database, Clusters, Search

Aug 17 2017

epriestley added a revision to T12965: When no "master" database is configured, the ElasticSearch setup check can fatal: D18440: Don't fatal in ElasticSearch setup check if no "master" database is configured.
Aug 17 2017, 4:53 PM · Database, Clusters, Search
epriestley created T12965: When no "master" database is configured, the ElasticSearch setup check can fatal.
Aug 17 2017, 4:41 PM · Database, Clusters, Search

Aug 15 2017

epriestley closed T12548: Unable to initialize database with invalid credentials in configuration file as Invalid.

Closing this for lack of feedback, feel free to resurrect it if you get back to it.

Aug 15 2017, 5:34 PM · Database, Bug Report

Jul 9 2017

chad updated the image for Database from Restricted File to F5039270: profile.
Jul 9 2017, 7:30 PM

May 5 2017

epriestley created T12678: Bring sanity to the world of all MySQL data being string-typed.
May 5 2017, 4:11 PM · Database, Infrastructure

Apr 13 2017

epriestley added a comment to T12548: Unable to initialize database with invalid credentials in configuration file.

This could definitely be more clear, but I think this is currently expected -- you still need to have valid configuration even when providing additional administrative credentials.

Apr 13 2017, 1:25 PM · Database, Bug Report
joshuaspence created T12548: Unable to initialize database with invalid credentials in configuration file.
Apr 13 2017, 7:01 AM · Database, Bug Report

Mar 16 2017

chad added a comment to T421: Show it to me Calimonk!.

Do this man

Mar 16 2017, 2:00 AM · newyork, Arcanist (Milestone 1), Restricted Project, Localization, ircbot, External, DeviantArt, Database, Dashboard, Dashboards, Daemons, Conpherence, Calendar, Chatlog, Unknown Object (Project)

Jan 17 2017

Alexmoon2 added projects to T421: Show it to me Calimonk!: Chatlog, Calendar, Conpherence, Daemons, Dashboards, Dashboard, Database, DeviantArt, External, ircbot, Localization, Restricted Project, Arcanist (Milestone 1), newyork.
Jan 17 2017, 9:24 AM · newyork, Arcanist (Milestone 1), Restricted Project, Localization, ircbot, External, DeviantArt, Database, Dashboard, Dashboards, Daemons, Conpherence, Calendar, Chatlog, Unknown Object (Project)

Nov 22 2016

epriestley closed T11672: Evaluate persistent connections from HTTP contexts as Resolved by committing rP8c89fc38fc42: Allow persistent connections to be configured per database host.
Nov 22 2016, 6:57 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: D16913: Allow persistent connections to be configured per database host.
Nov 22 2016, 2:41 PM · Restricted Project, Performance, Clusters, Database
epriestley closed T10931: Changing mysql.implementation setting doesn't work as Resolved by committing rPbac27fb40363: Remove "mysql.implementation" configuration.
Nov 22 2016, 12:15 PM · Setup, Database, Bug Report
epriestley added a comment to T10931: Changing mysql.implementation setting doesn't work.

I've marked D16909 as fixing this, but it just removes mysql.implementation, and uses the rule "mysqli if available, mysql otherwise".

Nov 22 2016, 1:08 AM · Setup, Database, Bug Report
epriestley added a revision to T10931: Changing mysql.implementation setting doesn't work: D16909: Remove "mysql.implementation" configuration.
Nov 22 2016, 1:05 AM · Setup, Database, Bug Report

Nov 21 2016

epriestley added a parent task for T11672: Evaluate persistent connections from HTTP contexts: T11044: Support partitioning application databases across multiple database hosts.
Nov 21 2016, 4:01 PM · Restricted Project, Performance, Clusters, Database

Sep 29 2016

eadler added a project to T11672: Evaluate persistent connections from HTTP contexts: Restricted Project.
Sep 29 2016, 6:29 PM · Restricted Project, Performance, Clusters, Database

Sep 23 2016

epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: D16591: For now, disable persistent connections and the "max_connections" setup warning.
Sep 23 2016, 7:40 PM · Restricted Project, Performance, Clusters, Database
epriestley reopened T11672: Evaluate persistent connections from HTTP contexts as "Open".
Sep 23 2016, 7:37 PM · Restricted Project, Performance, Clusters, Database

Sep 21 2016

epriestley closed T11672: Evaluate persistent connections from HTTP contexts as Resolved.
Sep 21 2016, 9:47 PM · Restricted Project, Performance, Clusters, Database
epriestley added a comment to T11672: Evaluate persistent connections from HTTP contexts.

I've banged on this a reasonable amount locally without issues and the originating instance reports that this seems to have calmed things down in production with these patches, so it seems like this pretty much just worked.

Sep 21 2016, 9:47 PM · Restricted Project, Performance, Clusters, Database

Sep 20 2016

epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: D16578: Use persistent database connections from web contexts.
Sep 20 2016, 2:34 PM · Restricted Project, Performance, Clusters, Database
epriestley added a revision to T11672: Evaluate persistent connections from HTTP contexts: D16577: Support persistent connections in libphutil.
Sep 20 2016, 2:29 PM · Restricted Project, Performance, Clusters, Database
epriestley created T11672: Evaluate persistent connections from HTTP contexts.
Sep 20 2016, 1:54 PM · Restricted Project, Performance, Clusters, Database

Aug 5 2016

eadler added a project to T8476: Rename `phabricator_repository` database: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Database, Diffusion

Jul 27 2016

epriestley closed T11382: Data issue - France as Invalid.

You are in the wrong place -- it looks like you mean to be on Uber's internal install of Phabricator, but this is the public upstream install of Phabricator.

Jul 27 2016, 11:30 AM · Database, Bug Report
pauline created T11382: Data issue - France.
Jul 27 2016, 10:03 AM · Database, Bug Report

Jun 8 2016

chad added projects to T10768: Provide tools to drop severed nodes from load balancer pools by failing status checks: Database, Clusters.
Jun 8 2016, 4:51 PM · Clusters, Database

May 26 2016

epriestley added a comment to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment.

Should be fixed in HEAD of master. Thanks for the report!

May 26 2016, 7:17 PM · Database, Clusters, Bug Report
epriestley closed T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment as Resolved by committing rP74a36f9d7bf0: Read "Database Status" page connection information from cluster config if….
May 26 2016, 7:14 PM · Database, Clusters, Bug Report
epriestley added a revision to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment: D15982: Read "Database Status" page connection information from cluster config if present.
May 26 2016, 7:13 PM · Database, Clusters, Bug Report
epriestley added projects to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment: Clusters, Database.
May 26 2016, 7:03 PM · Database, Clusters, Bug Report

May 19 2016

chad added projects to T10931: Changing mysql.implementation setting doesn't work: Database, Setup.
May 19 2016, 5:08 PM · Setup, Database, Bug Report
faulconbridge added a comment to Q391: Meaning of each databases and tables used by Phabricator.

Source code isn't (AFAIK) stored in Phabricator's databases; it only lives at /var/repo/ and whatever other URIs you're mirroring/observing in Diffusion. But again, if you're just looking for commit-level metadata, using Conduit will probably be easier.

May 19 2016, 2:57 PM · Restricted Project, Database
tukamon added a comment to Q391: Meaning of each databases and tables used by Phabricator.

The use case is take all of that info as ETL input, but I what to be sure that I am not retrieveing source code from the tables as a matter of performance in addition to I am not interested in it.
What do you think is the best way to do that?

May 19 2016, 2:52 PM · Restricted Project, Database

May 18 2016

faulconbridge added a comment to Q391: Meaning of each databases and tables used by Phabricator.

If you really want to muck around in Phabricator's databases, you could probably get at the information you mentioned with something similar to

May 18 2016, 8:41 PM · Restricted Project, Database
tukamon added a comment to Q391: Meaning of each databases and tables used by Phabricator.

The reason why I want that data is not relevant. The question in brief is the following the source code versioned by the repositories hosted in Phabricator are held in the data base?

May 18 2016, 6:33 AM · Restricted Project, Database

May 17 2016

chad added a comment to Q391: Meaning of each databases and tables used by Phabricator.

Sorry, maybe I didn't explain that very well. I already understand you want the data, I don't understand why you want that data. The upstream isn't going to get into database nitty gritty without a Phacility Consulting contract ($1500 / hr if you're interested), but perhaps if you let us understand what problem you're trying to solve, we can give you pointers as to the best approach (APIs?)

May 17 2016, 4:03 PM · Restricted Project, Database
tukamon added a comment to Q391: Meaning of each databases and tables used by Phabricator.

Hello chad,

May 17 2016, 3:55 PM · Restricted Project, Database
chad added a comment to Q391: Meaning of each databases and tables used by Phabricator.

Might be quicker to simply tell us what you are attempting to do.

May 17 2016, 3:25 PM · Restricted Project, Database
tukamon updated Q391: Meaning of each databases and tables used by Phabricator from to Meaning of each databases and tables used by Phabricator.
May 17 2016, 3:11 PM · Restricted Project, Database

May 7 2016

epriestley updated subscribers of T8476: Rename `phabricator_repository` database.
May 7 2016, 1:14 PM · Restricted Project, Database, Diffusion
epriestley removed a project from T8476: Rename `phabricator_repository` database: Clusters.
May 7 2016, 1:14 PM · Restricted Project, Database, Diffusion
rubenriverae added a project to T8476: Rename `phabricator_repository` database: Clusters.
May 7 2016, 11:58 AM · Restricted Project, Database, Diffusion

May 2 2016

chad added a project to T10773: When the search table is marked as crashed, bin/storage should automatically repair it: Database.
May 2 2016, 7:13 PM · Database, Feature Request

Apr 14 2016

epriestley merged task T6453: MySQL warnings after storage adjustment into T10813: Maybe fix various statements that MySQL statement-based replication gets upset about.
Apr 14 2016, 8:55 PM · Database

Mar 15 2016

epriestley closed T10587: test as Spite.
Mar 15 2016, 9:51 AM · Database
Luke081515.2 added a comment to T10587: test.

From the homepage:

IMPORTANT: This is not a demo or test install. Please don't make a mess. You can launch a demo install on Phacility if you want to poke around and try things out.
Mar 15 2016, 9:03 AM · Database
fr created T10587: test.
Mar 15 2016, 8:14 AM · Database

Dec 1 2015

joshuaspence closed T9715: Prevent upgrade scripts from being run multiple times simultaneously as Resolved by committing rP71646062852b: Add a lock to storage upgrade and adjustment.
Dec 1 2015, 7:21 PM · Database

Nov 11 2015

joshuaspence added a revision to T9715: Prevent upgrade scripts from being run multiple times simultaneously: D14463: Add a lock to storage upgrade and adjustment.
Nov 11 2015, 12:17 PM · Database

Nov 5 2015

epriestley renamed T9715: Prevent upgrade scripts from being run multiple times simultaneously from Prevent migrations from being applied multiple times to Prevent upgrade scripts from being run multiple times simultaneously.
Nov 5 2015, 12:28 PM · Database
epriestley added a comment to T9715: Prevent upgrade scripts from being run multiple times simultaneously.

Yeah, I'm fine with putting a global lock on this. You shouldn't really ever be running it on multiple hosts simultaneously (in the best case, this just slows you down by running the slow checks in adjust multiple times), but it's dangerous enough to explicitly prevent.

Nov 5 2015, 12:28 PM · Database
joshuaspence claimed T9715: Prevent upgrade scripts from being run multiple times simultaneously.

Happy to submit a patch if @epriestley is on board.

Nov 5 2015, 8:27 AM · Database

Nov 4 2015

joshuaspence added a comment to T9715: Prevent upgrade scripts from being run multiple times simultaneously.

Oh, I take the hosts offline first.

Nov 4 2015, 9:23 PM · Database