Page MenuHomePhabricator
Differential D20790

Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
ClosedPublic
Actions

Authored by epriestley on Sep 8 2019, 7:59 PM.

Details

Reviewers
None
Maniphest Tasks
T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY
Commits
rPf16365ed0778: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES"
Summary

Ref T13404. Enabling "STRICT_ALL_TABLES" is good, but if you don't want to bother it doesn't matter too much. All upstream development has been on "STRICT_ALL_TABLES" for a long time.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 8 2019, 7:59 PM
epriestley requested review of this revision.Sep 8 2019, 8:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:17 PM
Closed by commit rPf16365ed0778: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPf16365ed0778: Weaken the guidance recommending that installs enable "STRICT_ALL_TABLES".

Revision Contents
Changeset List

Diff 49578

View Options

src/applications/config/check/PhabricatorMySQLSetupCheck.php

Loading...
Phabricator · Built by Phacility