Page MenuHomePhabricator

Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES"
ClosedPublic

Authored by epriestley on Sep 8 2019, 8:02 PM.
Tags
None
Referenced Files
F14798062: D20791.id49579.diff
Sat, Jan 25, 5:42 AM
F14798061: D20791.id49571.diff
Sat, Jan 25, 5:41 AM
F14798059: D20791.id.diff
Sat, Jan 25, 5:41 AM
Unknown Object (File)
Thu, Jan 23, 12:02 AM
Unknown Object (File)
Tue, Jan 21, 10:22 AM
Unknown Object (File)
Sat, Jan 18, 7:55 AM
Unknown Object (File)
Sat, Jan 18, 3:13 AM
Unknown Object (File)
Nov 9 2024, 3:41 PM
Subscribers
None

Details

Summary

Ref T13404. Except for one known issue in Multimeter, Phabricator appears to function properly in this mode. It is broadly desirable that we run in this mode; it's good on its own, and enabled by default in at least some recent MySQL.

Additionally, "ONLY_FULL_GROUP_BY" and "STRICT_ALL_TABLES" shared a setup key, so ignoring one would ignore both. Change the key so that existing ignores on "ONLY_FULL_GROUP_BY" do not mask "STRICT_ALL_TABLES" warnings.

Test Plan

Grepped for ONLY_FULL_GROUP_BY.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable