Page MenuHomePhabricator

Remove the "ONLY_FULL_GROUP_BY" SQL mode setup warning and change the setup key for "STRICT_ALL_TABLES"
ClosedPublic

Authored by epriestley on Sep 8 2019, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:25 AM
Unknown Object (File)
Mon, Apr 8, 7:35 PM
Unknown Object (File)
Fri, Mar 29, 6:31 AM
Unknown Object (File)
Mar 8 2024, 7:50 PM
Unknown Object (File)
Feb 19 2024, 12:20 PM
Unknown Object (File)
Feb 7 2024, 9:37 PM
Unknown Object (File)
Jan 18 2024, 8:58 AM
Unknown Object (File)
Jan 15 2024, 9:12 PM
Subscribers
None

Details

Summary

Ref T13404. Except for one known issue in Multimeter, Phabricator appears to function properly in this mode. It is broadly desirable that we run in this mode; it's good on its own, and enabled by default in at least some recent MySQL.

Additionally, "ONLY_FULL_GROUP_BY" and "STRICT_ALL_TABLES" shared a setup key, so ignoring one would ignore both. Change the key so that existing ignores on "ONLY_FULL_GROUP_BY" do not mask "STRICT_ALL_TABLES" warnings.

Test Plan

Grepped for ONLY_FULL_GROUP_BY.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable