Paths

Table of Contentst

Differential D20782

Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
ClosedPublic
Actions

Authored by epriestley on Sep 3 2019, 11:43 PM.

Tags

None

Referenced Files

	F13082168: D20782.diff
	Wed, Apr 24, 10:02 PM

	Unknown Object (File)
	Sun, Apr 21, 4:08 PM

	Unknown Object (File)
	Sat, Apr 20, 4:55 PM

	Unknown Object (File)
	Sat, Apr 20, 3:32 AM

	Unknown Object (File)
	Wed, Apr 17, 3:09 PM

	Unknown Object (File)
	Tue, Apr 16, 4:16 PM

	Unknown Object (File)
	Thu, Apr 11, 7:18 AM

	Unknown Object (File)
	Thu, Mar 28, 6:56 PM

View All 75 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13404: Make Phabricator compatible with ONLY_FULL_GROUP_BY
Commits: rP22b075df9716: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries

Summary

Ref T13404. This query is invalid under "sql_mode=ONLY_FULL_GROUP_BY". Rewrite it to avoid interacting with actorIdentity at all; this is a little more robust in the presence of weird data and not really more complicated.

Test Plan

Enabled "ONLY_FULL_GROUP_BY".
Hit system actions (e.g., login).
- Before: error.
- After: clean login.
Tried to login with a bad password many times in a row, got properly limited by the system action rate limiter.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 3 2019, 11:43 PM

Harbormaster completed remote builds in B23379: Diff 49553.Sep 3 2019, 11:44 PM

epriestley requested review of this revision.Sep 3 2019, 11:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 11:50 PM

Closed by commit rP22b075df9716: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP22b075df9716: Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries.

Revision Contents
Changeset List

Path

Size

src/

applications/

system/

engine/

PhabricatorSystemActionEngine.php

26 lines

Diff 49554

src/applications/system/engine/PhabricatorSystemActionEngine.php

Loading...