Page MenuHomePhabricator

Fix "ONLY_FULL_GROUP_BY" issue in SystemAction queries
ClosedPublic

Authored by epriestley on Sep 3 2019, 11:43 PM.

Details

Summary

Ref T13404. This query is invalid under "sql_mode=ONLY_FULL_GROUP_BY". Rewrite it to avoid interacting with actorIdentity at all; this is a little more robust in the presence of weird data and not really more complicated.

Test Plan
  • Enabled "ONLY_FULL_GROUP_BY".
  • Hit system actions (e.g., login).
    • Before: error.
    • After: clean login.
  • Tried to login with a bad password many times in a row, got properly limited by the system action rate limiter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 11:50 PM
This revision was automatically updated to reflect the committed changes.