Don't fatal in ElasticSearch setup check if no "master" database is configured
ClosedPublic
Actions

Authored by epriestley on Aug 17 2017, 4:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 22 2024, 11:09 AM

	Unknown Object (File)
	Jan 25 2024, 5:27 AM

	Unknown Object (File)
	Jan 19 2024, 4:55 PM

	Unknown Object (File)
	Jan 15 2024, 7:54 PM

	Unknown Object (File)
	Jan 13 2024, 3:44 PM

	Unknown Object (File)
	Jan 9 2024, 10:15 AM

	Unknown Object (File)
	Jan 9 2024, 10:14 AM

	Unknown Object (File)
	Jan 9 2024, 1:55 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12965: When no "master" database is configured, the ElasticSearch setup check can fatal

Commits

rPc9986fd5dee6: Don't fatal in ElasticSearch setup check if no "master" database is configured

Summary

Ref T12965. See that task for discussion, and PHI36 for context.

This sweeps the fatal under the rug by skipping it, letting things move forward for now.

Test Plan

Followed instructions in T12965, got a read-only recovery after restart instead of a fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 17 2017, 4:53 PM

Harbormaster completed remote builds in B18093: Diff 44302.Aug 17 2017, 4:54 PM

chad accepted this revision.Aug 17 2017, 5:01 PM

This revision is now accepted and ready to land.Aug 17 2017, 5:01 PM

Closed by commit rPc9986fd5dee6: Don't fatal in ElasticSearch setup check if no "master" database is configured (authored by epriestley). · Explain WhyAug 17 2017, 5:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorElasticsearchSetupCheck.php

6 lines

Diff 44304

View Options

src/applications/config/check/PhabricatorElasticsearchSetupCheck.php

Don't fatal in ElasticSearch setup check if no "master" database is configuredClosedPublicActions