Oh, now that we gave posts the J monogram, we should probably also find a way to put that on the blog page somewhere (at least the internal one, and maybe the ApplicationSearch results page). Right now you have to know that you can fish the ID out of the URI. Let me see if I can poke at that a bit with my doc stuff.

I've been pretty excited about this since the unbetaing started.

I think I started the unbeta task in December. So... Merry Christmas!

Just the T6299 stuff, I think.

Anything left to fix before unbeta?

In T9360#183602, @chad wrote:

Is [HTTPS] simple? Not sure where to start? Nothing is jumping out at me here.

In T9360#182482, @epriestley wrote:

Oh, and we select the correct protocol for custom domains now, but don't enforce it when serving content. That is, these both work, and we always link to "https", but "http" should redirect you directly to "https" instead of serving content:

• http://blog.phacility.com/
• https://blog.phacility.com/

PhabricatorPasteViewController is the best example for the EditEngine comment thing. Basically, make the comment form generate like Paste does (Maniphest too, although it's more complex). Then you can remove PhamePostCommentController completely.

The edit link on the post list is a little weird to me, since Maniphest is the only other application which has it (I think?) and the behavior is different there. In particular, you don't lose your place in the results in Maniphest, but you do in Phame. (I think this was originally added to Maniphest as a stopgap for T1960? But it doesn't address that use case in Phame, and that use case likely does not exist.)

I think the error is correct and the URLs are wrong. We should probably handle this with an Exception though. Also correcting our site links.

Thanks, we'll look into it.

alrighty

I identified posts on invalid blogs with this query:

Oh, it actually should cause this issue as currently written. I'm just going to destroy the bad data until this appears in the wild in a more reachable way, I don't think there is any easy way to resolve it.

Post #667 has an invalid blog, so this is probably difficult/impossible for normal users to hit, but it shouldn't cause this issue. I'll see if I can reproduce it locally.

• PhameBlog calls delete() on posts directly, but should use the destruction engine to destroy them instead. Calling delete() directly means that edges, comments, etc., on the posts won't be cleaned up when a blog is deleted.

Oh, and we select the correct protocol for custom domains now, but don't enforce it when serving content. That is, these both work, and we always link to "https", but "http" should redirect you directly to "https" instead of serving content:

Few more things I caught:

Thanks, this reproduces for me.

In live comments, these links are bad offhand:

• The stuff above should be better now, but I'm not sure if I got everything. We should run through that list again.
• The "Subscribers" and "Projects" links here do not link to the correct domain, and fixing them isn't trivial because they're event-driven extensions:

Sites eventually got split out (T5702) so that's no longer an issue, but this still isn't really straightforward. We do a lot of object loads which need some real viewer (blog, post, other adjacent posts, author, subscribers, object references in remarkup).

This still hard?

Closing as Resolved in general. T6299 and T4936 are already in the system separately.

Yeah, I think you can just do a SQL migration like:

User enters full URI (protocol + domain + optional port), like https://blog.phacility.com/ (UI is basically the same as it is now -- they still enter one value, it just has protocol + port now).

Custom domains probably need a way to link to an alternate root (e.g., the main company site).

The major custom domain issue is that there's no way to specify a protocol (HTTP vs HTTPS) or port (although this is less important). In particular, http://blog.phacility.com/ works and is the default live URI for that blog, but we would prefer https://blog.phacility.com/ to be the default URI and for http to redirect to https.

@epriestley Any of what's left reasonable for me to accomplish? Or are they all super technical?

I feel like he should be "N + 1 Raccoon" instead of "No 1 Raccoon"

oh wow

they are mine T.T

i can has arts

We could do posts too, but I only have 3 arts so far, so blogs seemed easier to start with.

Oh for blogs, not posts.

Is this an example of "title art" or is there something better. I seem to think there was an actual header, but maybe not.

I can probably copy-pasta that feature.

any plans/chance to implement search if you unbeta phame? T6383?