Page MenuHomePhabricator

Add ability to set a header image per Phame blog
ClosedPublic

Authored by chad on Jun 17 2016, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 7:35 PM
Unknown Object (File)
Sun, Mar 24, 12:32 AM
Unknown Object (File)
Sun, Mar 10, 10:52 PM
Unknown Object (File)
Feb 23 2024, 2:17 AM
Unknown Object (File)
Feb 23 2024, 2:17 AM
Unknown Object (File)
Feb 14 2024, 8:58 PM
Unknown Object (File)
Feb 14 2024, 8:47 PM
Unknown Object (File)
Feb 3 2024, 10:57 AM
Subscribers

Details

Summary

This is the backend half of uploading an image as a header for Phame Blogs. Allows you to upload image, or delete it. Ref T10901

Test Plan

Go to Manage Blog, visit Edit Header Image, Upload snarky file. See snarky file on Manage page. Edit Header Image, click delete, save, see file goes away.

pasted_file (1×1 px, 389 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Add ability to set a header image per Phame blog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Nice! Couple of nits inline but nothing substantive.

src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php
7–9

You should be able to get rid of this method, this should be the default behavior.

60–66

This should become a transaction at some point, PhabricatorProjectTransaction::TYPE_IMAGE starting in PhabricatorProjectEditPictureController is an example, I think.

But I may modularize all of these under T9789 while doing the custom domain stuff anyway, and swapping this for a transaction is easy to do in a followup.

src/applications/phame/query/PhameBlogQuery.php
118

Unused?

This revision is now accepted and ready to land.Jun 17 2016, 6:16 PM
This revision was automatically updated to reflect the committed changes.
chad marked 3 inline comments as done.