Page MenuHomePhabricator

Add ability to set a header image per Phame blog
ClosedPublic

Authored by chad on Jun 17 2016, 6:07 PM.

Details

Summary

This is the backend half of uploading an image as a header for Phame Blogs. Allows you to upload image, or delete it. Ref T10901

Test Plan

Go to Manage Blog, visit Edit Header Image, Upload snarky file. See snarky file on Manage page. Edit Header Image, click delete, save, see file goes away.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 38829.Jun 17 2016, 6:07 PM
chad retitled this revision from to Add ability to set a header image per Phame blog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad edited the test plan for this revision. (Show Details)Jun 17 2016, 6:08 PM
epriestley accepted this revision.Jun 17 2016, 6:16 PM
epriestley edited edge metadata.

Nice! Couple of nits inline but nothing substantive.

src/applications/phame/controller/blog/PhameBlogHeaderPictureController.php
7–9

You should be able to get rid of this method, this should be the default behavior.

60–66

This should become a transaction at some point, PhabricatorProjectTransaction::TYPE_IMAGE starting in PhabricatorProjectEditPictureController is an example, I think.

But I may modularize all of these under T9789 while doing the custom domain stuff anyway, and swapping this for a transaction is easy to do in a followup.

src/applications/phame/query/PhameBlogQuery.php
118

Unused?

This revision is now accepted and ready to land.Jun 17 2016, 6:16 PM
This revision was automatically updated to reflect the committed changes.
chad marked 3 inline comments as done.