Page MenuHomePhabricator
Differential D16010

Give Phame blogs an explicit 404 controller
ClosedPublic
Actions

Authored by epriestley on Jun 2 2016, 2:39 PM.
Tags
None
Referenced Files
F14055030: D16010.diff
Sat, Nov 16, 7:35 AM
F14042471: D16010.diff
Tue, Nov 12, 3:47 AM
F14025432: D16010.diff
Thu, Nov 7, 5:48 PM
F14003872: D16010.diff
Sat, Oct 26, 11:50 AM
F13989166: D16010.id38532.diff
Mon, Oct 21, 6:33 PM
Unknown Object (File)
Oct 10 2024, 10:53 PM
Unknown Object (File)
Oct 9 2024, 3:55 AM
Unknown Object (File)
Sep 17 2024, 12:56 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9897: Unbeta Feedback on Phame
T11076: Ship CORGI
Commits
rP03e54afc146c: Give Phame blogs an explicit 404 controller
Summary

Ref T11076. Ref T9897. Bad links on Phame blogs are currently made worse because we try to prompt you to login on a non-cookie domain.

Instead, just 404 in a vanilla way. Do so cleanly on external domains.

Test Plan

Screen Shot 2016-06-02 at 7.37.58 AM.png (1×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38532.Jun 2 2016, 2:39 PM
epriestley retitled this revision from to Give Phame blogs an explicit 404 controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11076: Ship CORGI, T9897: Unbeta Feedback on Phame.
Herald edited edge metadata. · View Herald TranscriptJun 2 2016, 2:39 PM
chad accepted this revision.Jun 2 2016, 3:13 PM
chad edited edge metadata.
chad added inline comments.
src/applications/phame/site/Phame404Response.php
34

Hehe

This revision is now accepted and ready to land.Jun 2 2016, 3:13 PM
Closed by commit rP03e54afc146c: Give Phame blogs an explicit 404 controller (authored by epriestley, committed by epriestley). · Explain WhyJun 2 2016, 4:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
4 lines
applications/
phame/
application/
2 lines
controller/
33 lines
blog/
14 lines
6 lines
site/
43 lines
webroot/
rsrc/
css/
application/
phame/
10 lines

Diff 38533

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phame/application/PhabricatorPhameApplication.php

Loading...
View Options

src/applications/phame/controller/PhameLiveController.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlog404Controller.php

Loading...
View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

Loading...
View Options

src/applications/phame/site/Phame404Response.php

Loading...
View Options

webroot/rsrc/css/application/phame/phame.css

Loading...
Phabricator · Built by Phacility