Page MenuHomePhabricator

Give Phame blogs an explicit 404 controller
ClosedPublic

Authored by epriestley on Jun 2 2016, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 4:37 PM
Unknown Object (File)
Fri, May 30, 3:31 AM
Unknown Object (File)
Wed, May 28, 5:36 PM
Unknown Object (File)
Tue, May 27, 7:54 PM
Unknown Object (File)
Mon, May 26, 7:43 AM
Unknown Object (File)
Apr 28 2025, 10:06 PM
Unknown Object (File)
Apr 27 2025, 5:46 PM
Unknown Object (File)
Apr 26 2025, 6:54 PM
Subscribers
None

Details

Summary

Ref T11076. Ref T9897. Bad links on Phame blogs are currently made worse because we try to prompt you to login on a non-cookie domain.

Instead, just 404 in a vanilla way. Do so cleanly on external domains.

Test Plan

Screen Shot 2016-06-02 at 7.37.58 AM.png (1×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Phame blogs an explicit 404 controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/phame/site/Phame404Response.php
34

Hehe

This revision is now accepted and ready to land.Jun 2 2016, 3:13 PM
This revision was automatically updated to reflect the committed changes.