src/applications/phame/query/PhamePostQuery.php
126	Hrrm, I'd expect this to break queries, although maybe MySQL is more lenient than I thought. For consistency, prefer a short alias like `post`. When providing a table alias, you should also use that alias to refer to columns elsewhere. In `buildWhereClauseParts()`, edit the queries to be `post.id IN ...` instead of `id IN ...`, etc.
131	This key should be `'published'`, not `'name`'. As written, you'd make an API call like `phame.post.search(order = name)` to order things by publish date.

This revision now requires changes to proceed.Jun 15 2016, 7:08 PM

chad added inline comments.Jun 15 2016, 7:21 PM

src/applications/phame/query/PhamePostQuery.php
126	doesn't this need to be the name of the table? If I make it `post`, it fails.

What's the error you get if you call it post?

(It's normally not the name of the table -- both because it's a little more convenient to use a shorter alias, and because sometimes you'll join the table to itself, which makes it ambiguous/weird if you use the table name.)

e.g., see ManiphestTaskQuery:

protected function getPrimaryTableAlias() {
  return 'task';
}

Updates

I just deleted it, or should I use that method?

chad updated this object.Jun 15 2016, 7:33 PM

chad edited the test plan for this revision. (Show Details)

chad edited edge metadata.

You don't need it as long as there are no joins, and there currently aren't.

This revision is now accepted and ready to land.Jun 15 2016, 7:34 PM

(No idea why that test is failing some of the time, let me see if I can figure that out.)

Closed by commit rPb94b16df4900: Allow Phame Posts to be ordered by datePublished (authored by chad, committed by chad). · Explain WhyJun 15 2016, 7:47 PM

This revision was automatically updated to reflect the committed changes.

I tried to reproduce the issue locally and on the build server without any luck. I'll add some more assertions if it keeps happening to maybe narrow it down.

iiam