Fix external blog images
ClosedPublic
Actions

Authored by chad on Jun 19 2016, 2:59 PM.

Tags

None

Referenced Files

	F14053330: D16148.diff
	Fri, Nov 15, 2:55 PM

	F14040626: D16148.diff
	Mon, Nov 11, 11:42 AM

	F14025056: D16148.diff
	Thu, Nov 7, 2:11 PM

	F13996911: D16148.id.diff
	Thu, Oct 24, 1:00 AM

	F13974612: D16148.diff
	Oct 18 2024, 6:24 AM

	F13959742: D16148.id38848.diff
	Oct 14 2024, 8:35 PM

	Unknown Object (File)
	Oct 9 2024, 4:11 AM

	Unknown Object (File)
	Oct 3 2024, 3:56 PM

View All Files

Subscribers

Korvin

Tokens

"Pterodactyl" token, awarded by epriestley.

Details

Reviewers

epriestley

Maniphest Tasks

T9897: Unbeta Feedback on Phame

Commits

rPf763c314e107: Fix external blog images

Summary

Reading the code, this seems correct, but I don't have a local test. Ref T9897

Test Plan

read carefully

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38847.Jun 19 2016, 2:59 PM

chad retitled this revision from to Fix external blog images.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 19 2016, 2:59 PM

chad updated this object.Jun 19 2016, 2:59 PM

chad added a task: T9897: Unbeta Feedback on Phame.

Let me see if I have a local repro case, one sec...

Looks good locally. Before:

Screen Shot 2016-06-19 at 8.01.56 AM.png (1×2 px, 468 KB)

After:

Screen Shot 2016-06-19 at 8.02.15 AM.png (1×2 px, 1 MB)

This revision is now accepted and ready to land.Jun 19 2016, 3:02 PM

epriestley awarded a token.Jun 19 2016, 3:02 PM

Closed by commit rPf763c314e107: Fix external blog images (authored by chad, committed by chad). · Explain WhyJun 19 2016, 3:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

site/

PhameBlogSite.php

1 line

Diff 38848

View Options

src/applications/phame/site/PhameBlogSite.php

Fix external blog imagesClosedPublicActions