Page MenuHomePhabricator

Ability to archive Phame Posts
ClosedPublic

Authored by chad on Jun 13 2016, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 9:17 PM
Unknown Object (File)
Sat, Mar 23, 4:13 PM
Unknown Object (File)
Sat, Mar 23, 3:10 PM
Unknown Object (File)
Sat, Mar 23, 3:05 PM
Unknown Object (File)
Sat, Mar 23, 2:13 PM
Unknown Object (File)
Sat, Mar 23, 2:10 PM
Unknown Object (File)
Sat, Mar 23, 11:16 AM
Unknown Object (File)
Sat, Mar 23, 10:49 AM
Subscribers

Details

Summary

Ref T9897. Adds ability to Archive a Phame Post (only visible under ApplicationSearch).

Test Plan

Archive a post, re-publish it, search for it, archive it again. View Home, Blog, Live pages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Ability to archive Phame Posts.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2016, 4:57 PM
chad edited edge metadata.
  • Clean up transaction copy

Can you give this a second glance, I want to make sure I'm not leaking visibility anywhere.

Hrrm -- some of the text (not all of which is new here) is misleading because it says "only you" and "won't be visible to members of this blog", but the actual policy we implement is that users who can edit a blog can see all the drafts and archived posts, so it's not "only you" but "only editors of this blog".

This isn't really new either, but when viewing a blog, there's no easy/obvious way to see archived posts -- for example, no link to "view all posts" in the action menu. You can get to them, sort of, but have to go PhameView All (Posts)(no way to query by blog or by archived, except left-nav filter). It would be nice to add a blog typeahead here to let you search by blog, and have the blog action menu link to it.

Everything else looks good to me. Actual policy implementation is fine, some of the messaging around it is just a bit misleading.

src/applications/phame/query/PhamePostSearchEngine.php
34–39

probably include archived as an option here?

This revision was automatically updated to reflect the committed changes.