Page MenuHomePhabricator

Use CommentEditEngine in PhamePost
ClosedPublic

Authored by chad on Jul 2 2016, 4:34 AM.

Details

Summary

Ref T9360. Moves PhamePost to CommentEditEngine.

  • HTTP Parameters dropdown on New Post goes to 404
  • Implement EditEngine Comments
Test Plan

Make Post, Make Comment, Laugh.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Use CommentEditEngine in PhamePost.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.

The 404 is:

core.pkg.js:2326 POST http://local.phacility.com/phame/edit/1/comment/ 404 (Not Found)

So seems to not find phame/post/edit. Not sure if my fault.

chad edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.

Slightly weird that we quote like this, but "POSTxxx" isn't a real monogram so it doesn't link:

Screen Shot 2016-07-03 at 1.44.31 AM.png (177×412 px, 22 KB)

Not sure if that's worth fixing or how to fix it:

  • I could make it not show the "quote" action if you don't setQuoteRef(), although quoting post comments seems somewhat useful.
  • We could also make "POST" a real monogram. I think I'd use monograms for posts (see earlier in T9897#151198), although multiple-letter monograms feel a little clunky to me.
  • We could give posts the "J" monogram, nominally for "Journal Entry"?

I maybe slightly favor giving them "J".


Also slightly weird that you can select "Change Projects" and "Change Subscribers", and we show you a preview, and we actually do apply the actions, but the timeline doesn't show them. Maybe:

  • Show comments, subscriber changes, and project changes in the timeline?
  • Or, I can tweak things so the actions just don't show up here?

I maybe slightly favor removing the actions.

This revision is now accepted and ready to land.Jul 3 2016, 8:55 AM

Oh I made POST work, but didn’t push up another diff. I can just get rid of
actions too.

chad edited edge metadata.
  • Make "J" a post monogram
This revision was automatically updated to reflect the committed changes.