Page MenuHomePhabricator
Differential D16241

Redirect https blogs
ClosedPublic
Actions

Authored by chad on Jul 6 2016, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 1:19 PM
Unknown Object (File)
Wed, Nov 27, 7:34 PM
Unknown Object (File)
Sun, Nov 24, 11:40 AM
Unknown Object (File)
Fri, Nov 22, 11:45 PM
Unknown Object (File)
Tue, Nov 19, 8:11 PM
Unknown Object (File)
Nov 9 2024, 4:10 PM
Unknown Object (File)
Nov 6 2024, 3:13 PM
Unknown Object (File)
Oct 31 2024, 4:47 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
rPee460b4f1b4c: Redirect https blogs
Summary

Ref T9360, forces https if we say the blog is https.

Test Plan

Fake an https, get redirected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39070.Jul 6 2016, 8:33 PM
chad retitled this revision from to Redirect https blogs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptJul 6 2016, 8:33 PM
epriestley requested changes to this revision.Jul 6 2016, 11:25 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/site/PhameBlogSite.php
23

I'd expect this to need a $full_uri->getProtocol() here somewhere, the bare $full_uri should never be "https".

This revision now requires changes to proceed.Jul 6 2016, 11:25 PM
chad added a comment.Jul 6 2016, 11:52 PM

I knew I was going to be busted on that test plan. Haha. FWIW I got stumped by the parent Domain bug and never went back to this after fixing.

epriestley added a comment.Jul 6 2016, 11:56 PM

I can kick the tires locally before I accept, I have it sort-of-configured locally.

chad updated this revision to Diff 39075.Jul 7 2016, 12:19 AM
chad edited edge metadata.
  • check protocol, rerun test, see redirect
epriestley accepted this revision.Jul 7 2016, 12:20 AM
epriestley edited edge metadata.

Cool, this works properly in my only-sort-of-fake local environment:

Screen Shot 2016-07-06 at 5.20.08 PM.png (1×1 px, 344 KB)

This revision is now accepted and ready to land.Jul 7 2016, 12:20 AM
Closed by commit rPee460b4f1b4c: Redirect https blogs (authored by chad, committed by chad). · Explain WhyJul 7 2016, 12:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
site/
7 lines

Diff 39076

View Options

src/applications/phame/site/PhameBlogSite.php

Loading...
Phabricator · Built by Phacility