Page MenuHomePhabricator

Redirect https blogs
ClosedPublic

Authored by chad on Jul 6 2016, 8:33 PM.

Details

Summary

Ref T9360, forces https if we say the blog is https.

Test Plan

Fake an https, get redirected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Redirect https blogs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/site/PhameBlogSite.php
23

I'd expect this to need a $full_uri->getProtocol() here somewhere, the bare $full_uri should never be "https".

This revision now requires changes to proceed.Jul 6 2016, 11:25 PM

I knew I was going to be busted on that test plan. Haha. FWIW I got stumped by the parent Domain bug and never went back to this after fixing.

I can kick the tires locally before I accept, I have it sort-of-configured locally.

chad edited edge metadata.
  • check protocol, rerun test, see redirect
epriestley edited edge metadata.

Cool, this works properly in my only-sort-of-fake local environment:

Screen Shot 2016-07-06 at 5.20.08 PM.png (1×1 px, 344 KB)

This revision is now accepted and ready to land.Jul 7 2016, 12:20 AM
This revision was automatically updated to reflect the committed changes.