Page MenuHomePhabricator

Improve some Phame custom domain remarkup and link behaviors
ClosedPublic

Authored by epriestley on Jun 2 2016, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:28 AM
Unknown Object (File)
Tue, Apr 9, 7:36 PM
Unknown Object (File)
Sun, Apr 7, 4:36 AM
Unknown Object (File)
Sun, Apr 7, 4:24 AM
Unknown Object (File)
Fri, Apr 5, 5:56 PM
Unknown Object (File)
Fri, Apr 5, 8:39 AM
Unknown Object (File)
Fri, Apr 5, 6:33 AM
Unknown Object (File)
Fri, Apr 5, 6:32 AM
Subscribers
None

Details

Summary

Ref T6299. This makes more of the links point to the right places.

Not covered yet:

  • Projects and subscribers don't point to the right place (this is a little tricky to fix, I think).
  • [[ #anchor ]]s won't do the right thing in, uh, email, I guess, since uri.here is not set. This is also a little tricky.

Possibly we should just remove subscribers (although also kind of tricky).

Test Plan

On a custom-domain blog, observed that fewer things were broken.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve some Phame custom domain remarkup and link behaviors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Also fix a PHUIRemarkup view cachekey typo.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 2 2016, 2:42 AM
This revision was automatically updated to reflect the committed changes.