Page MenuHomePhabricator

Improve PhamePost search options
ClosedPublic

Authored by chad on Jun 30 2016, 4:19 AM.

Details

Summary

Ref T9360. This adds ability to search posts by blog(s) and by type better.

Test Plan

Create some posts, search for them.

pasted_file (662×1 px, 141 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Improve PhamePost search options.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
  • Add ability to "Search Posts" from Blog View
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/phame/controller/blog/PhameBlogViewController.php
147

Probably just blog= works, too.

src/applications/phame/query/PhamePostSearchEngine.php
24–26

(This would become "blogPHIDs" with the change below.)

46

Maybe use blogPHIDs as the key, and 'blog', 'blogs', 'blogPHID' as the aliases.

48

Minor, but maybe "on certain blogs" instead of "with certain blogs"?

This revision is now accepted and ready to land.Jun 30 2016, 7:47 PM
chad edited edge metadata.
  • derp
chad marked an inline comment as done.Jun 30 2016, 7:51 PM
chad added inline comments.
src/applications/phame/query/PhamePostSearchEngine.php
46

oohh, that what alias does. nice.

Yeah, the "aliases" thing is basically just "anything a somewhat-reasonable user might try to type into the URL to select this field", and the "key" is what we actually store in the database.

(In some apps it also does "things we used to make you type into the URL that should probably still keep working".)

chad marked 5 inline comments as done.
  • per comments
This revision was automatically updated to reflect the committed changes.