Page MenuHomePhabricator
Differential D16197

Misc Phame cleanup
ClosedPublic
Actions

Authored by chad on Jun 30 2016, 12:53 AM.
Tags
None
Referenced Files
F18848900: D16197.id.diff
Thu, Oct 30, 6:47 AM
F18845965: D16197.diff
Wed, Oct 29, 3:33 PM
F18767619: D16197.id38960.diff
Tue, Oct 7, 11:27 PM
F18753456: D16197.id38960.diff
Sat, Oct 4, 6:55 PM
F18735330: D16197.id.diff
Oct 1 2025, 12:47 AM
F18670930: D16197.id38959.diff
Sep 25 2025, 2:08 AM
F18610609: D16197.diff
Sep 14 2025, 5:11 AM
F18507775: D16197.id.diff
Sep 5 2025, 2:25 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9360: Unbeta Phame
Commits
rPfd0a606f7942: Misc Phame cleanup
Summary

Ref T9360.

  • View Live useless on archived blogs
  • Edit Blog Image treatment like profiles
  • Pager next/prev should keep you on whatever view you're on
  • Unset user titles aren't falling back properly
  • Add captions to edit fields for better clarification
Test Plan

Archive a blog, Edit a photo, verify pager on live and internal blogs, check empty titles, and view new edit form instructions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38959.Jun 30 2016, 12:53 AM
chad retitled this revision from to Misc Phame cleanup.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9360: Unbeta Phame.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 30 2016, 12:53 AM
epriestley accepted this revision.Jun 30 2016, 1:52 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2016, 1:52 AM
Closed by commit rPfd0a606f7942: Misc Phame cleanup (authored by chad, committed by chad). · Explain WhyJun 30 2016, 2:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
blog/
13 lines
post/
10 lines
editor/
8 lines
storage/
12 lines

Diff 38960

View Options

src/applications/phame/controller/blog/PhameBlogManageController.php

Loading...
View Options

src/applications/phame/controller/post/PhamePostViewController.php

Loading...
View Options

src/applications/phame/editor/PhameBlogEditEngine.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
Phabricator · Built by Phacility