Ref T9360. This makes these transactional.
- Maniphest Tasks
- T9360: Unbeta Phame
- rPf26374241ab1: Make Phame Header and Profile Image Transactional
Set new header, delete header. Set new profile image, reset profile image.
Minor nitpick that doesn't really matter: ideally, you should let ApplicationTransactionEditor handle the $file->attachToObject(...) call, by implementing extractFilePHIDsFromCustomTransaction().
However, this won't change anything and it's an easier fix when this moves to ModularTransactions so it's 100% fine to just leave it as-is for now.
Should these be renderHandleLink()?
I'm breaking something, can't figure it out.