Fixes T10901. Allows blogs to have headers. I've built this in a basic way, any file, max-height is 240. Should bleed into top crumbs, so any spacing you want you should add to the file itself. Might have to see how users break this.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T10901: Support title art for Phame blogs
- Commits
- rPe384e945d0cf: Add basic support for Phame blog headers
Set a blog header, see blog header, remove blog header, see no blog header. Check mobile, tablet, desktop break points.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
On Desktop I think these could maybe even be a bit bigger without being annoying.
| src/applications/phame/controller/blog/PhameBlogViewController.php | ||
|---|---|---|
| 160 | Viewer unused? | |
Comment Actions
Let's see how 240 feels here. I haven't played with it on my laptop/phone personally yet.