Page MenuHomePhabricator
Feed Advanced Search

Aug 29 2020

MagicInventor added a comment to T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate.
Aug 29 2020, 12:19 AM · Arcanist

Aug 24 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

New user is told "install dinosaurs, you can trust epriestley.

Aug 24 2020, 4:49 PM · Arcanist

Aug 22 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

The public key won't necessarily be available to Phabricator (because it's kinda funny to have the public key and signature in the same place). We'll just register the fingerprints I guess?

I think the public key has to be available -- you can't verify signatures otherwise.

Aug 22 2020, 6:28 AM · Arcanist

Aug 21 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

Distribution would just be zip/tgz files for each package

Aug 21 2020, 5:01 PM · Arcanist
avivey added a comment to T5055: Distribution mechanism for arc extensions.

I think I'm going to start working on the Arcanist side of this soon...

Aug 21 2020, 12:15 PM · Arcanist

Aug 12 2020

epriestley triaged T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate as Low priority.
Aug 12 2020, 4:02 PM · Arcanist

Aug 11 2020

epriestley triaged T13567: Arcanist does not decode unicode filenames in Git before passing them to linters as Low priority.
Aug 11 2020, 6:38 PM · Arcanist
epriestley renamed T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits from Improve fallback behavior for "arc branches/bookmarks" to Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits as Normal priority.
Aug 11 2020, 6:34 PM · Arcanist
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Aug 11 2020, 5:47 PM · Windows, Arcanist
epriestley triaged T13563: On Windows, Arcanist tries and fails to set stdin nonblocking while reading the stream as Low priority.
Aug 11 2020, 5:06 PM · Windows, Arcanist
epriestley triaged T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions as Normal priority.
Aug 11 2020, 5:02 PM · Windows, Arcanist
epriestley added a revision to T9924: Add support for git worktree: D21438: Find the per-worktree .git directory when using git-worktree.
Aug 11 2020, 4:45 PM · FreeBSD, Restricted Project, Arcanist, Feature Request

Jul 27 2020

epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 27 2020, 6:06 PM · Guides, Arcanist

Jul 22 2020

epriestley added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

Please use Discourse to discuss Phabricator.

Jul 22 2020, 11:49 PM · Arcanist, Guides
jbrownEP added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

This task references more details on "Excuses" and "Prompts", but there isn't any. Is there any way to provide context around lint issues?

Jul 22 2020, 11:46 PM · Arcanist, Guides

Jul 21 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 21 2020, 6:24 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 21 2020, 6:24 PM · Guides, Arcanist

Jul 6 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: D21392: Allow "hg arc-ls-markers" to run under Python 2 or Python 3.
Jul 6 2020, 10:29 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

See PHI1807. At time of writing, arc land can delete the local master if you land it onto itself. This isn't a big deal (it gives you the command to get it back), but not intended and undesirable. Although it isn't recommended, arc land is supposed to support working in master and landing master into itself.

Jul 6 2020, 10:00 PM · Arcanist

Jul 3 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jul 3 2020, 8:19 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:46 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:45 PM · Guides, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 3 2020, 7:43 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21390: Render the state tree in "arc branches" slightly more cleanly.
Jul 3 2020, 6:39 PM · Arcanist

Jun 30 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: D21380: Give Mercurial more plausible marker behavior.
Jun 30 2020, 10:24 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21379: Support date-range commit graph queries, and multiple disjoint commits in Git.
Jun 30 2020, 10:01 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21378: Identify published commits in working copies by using remote configuration.
Jun 30 2020, 9:55 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21377: Load and map repository objects for remote URIs.
Jun 30 2020, 8:20 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21376: Provide "arc look", a user-facing inspection command.
Jun 30 2020, 7:57 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21375: Support generating remote refs in Git.
Jun 30 2020, 7:54 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21374: Support inspection of remote refs with "arc inspect remote(...)".
Jun 30 2020, 6:58 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21373: Collapse repository URI normalization code into Arcanist.
Jun 30 2020, 5:55 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21372: Copy repository URI normalization code from Phabricator to Arcanist.
Jun 30 2020, 5:47 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

A related issue is that it is difficult to identify the set of "published" hashes in the general case. We would like arc branches to show all unpublished history, but stop at published history.

Jun 30 2020, 4:48 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21371: Introduce "phutil_partition()" and natural case sorting for "msortv(...)".
Jun 30 2020, 1:41 PM · Arcanist

Jun 18 2020

epriestley added a comment to T13546: Modernize the "arc land" workflow.

The major issue I'm trying to deal with now is that if you have a tree like this:

Jun 18 2020, 6:10 PM · Arcanist

Jun 17 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: D21367: In "arc branches", group linear sequences of published revisions together.
Jun 17 2020, 5:37 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21366: When a commit graph set has many commits, summarize them.
Jun 17 2020, 5:34 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21365: Improve grid layout in "arc branches" at various terminal widths.
Jun 17 2020, 5:33 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21364: Remove implicit sorting from "MarkerRefQuery".
Jun 17 2020, 5:31 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21363: Render "arc markers" workflows as a tree, not a list.
Jun 17 2020, 2:50 PM · Arcanist

Jun 15 2020

epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

P2143 has some graph reachability code that I don't actually need yet, but may by the time I get here.

Jun 15 2020, 3:15 PM · Restricted Project, Restricted Project, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21360: Introduce "GridView", an updated version of "ConsoleTableView".
Jun 15 2020, 3:09 PM · Arcanist

Jun 12 2020

epriestley triaged T13549: Use "sapi_windows_set_ctrl_handler()" under PHP 7.4 to handle ^C on Windows as Low priority.
Jun 12 2020, 9:00 PM · Arcanist, Windows

Jun 11 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: D21355: Add more "RepositoryRef" legacy status mappings.
Jun 11 2020, 5:39 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21354: In "arc land" under Git, confirm branch creation.
Jun 11 2020, 2:48 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21353: Collect scattered implementations of "getDisplayHash()" into RepositoryAPI.
Jun 11 2020, 1:36 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21352: Update "arc land" display of build failures, and rename "DisplayRef" to "RefView".
Jun 11 2020, 1:29 PM · Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21351: Improve "--hold", save/restore state, bookmark creation, and some warnings for "arc land" in Mercurial.
Jun 11 2020, 12:08 AM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21351: Improve "--hold", save/restore state, bookmark creation, and some warnings for "arc land" in Mercurial.
Jun 11 2020, 12:08 AM · Arcanist

Jun 10 2020

epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21350: Correct some minor "arc land" workflow issues in Mercurial.
Jun 10 2020, 11:18 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21350: Correct some minor "arc land" workflow issues in Mercurial.
Jun 10 2020, 11:18 PM · Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21349: Use a "branchmap" call to identify remote branches in "arc-hg".
Jun 10 2020, 10:36 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21349: Use a "branchmap" call to identify remote branches in "arc-hg".
Jun 10 2020, 10:36 PM · Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21348: In "arc land" in Mercurial, inch closer to making complex branch/bookmark workflows function.
Jun 10 2020, 10:13 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21348: In "arc land" in Mercurial, inch closer to making complex branch/bookmark workflows function.
Jun 10 2020, 10:13 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The current ls-remote script as written does not actually work; I think it only returns branches in the remote that:

Jun 10 2020, 10:04 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The actual extension is a 100-line Python script...
The real Pandora's box this opens...

Jun 10 2020, 9:29 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21347: In "arc land", fix some coarse issues with build warnings.
Jun 10 2020, 5:16 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21346: Add an explicit "uri" to the "harbormaster.buildable.search" results.
Jun 10 2020, 5:12 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21345: Realign "arc land" closed/published warning around more modern language.
Jun 10 2020, 4:19 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

The real Pandora's box this opens is that now that arc is exposed to whatever issues arise with the raw Python/Mercurial API, there's a much weaker argument against not writing more extensions.

Jun 10 2020, 3:49 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I put the extension in phabricator/ earlier by accident, but that was just me goofing my local paths. The extension is purely client side: hg can do ls-remote just fine (it's just "do hg pull, but stop half way through"), there's just no UI command for it.

Jun 10 2020, 3:42 PM · Mercurial, Arcanist
cspeckmim added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

Would the use of an extension make additional setup necessary for observed repositories vs. hosted repositories, or are observed repositories out of scope for these set of changes?

Jun 10 2020, 3:35 PM · Mercurial, Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21344: In "arc land" in Mercurial, show a tidier "ls-remote" command.
Jun 10 2020, 3:30 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21344: In "arc land" in Mercurial, show a tidier "ls-remote" command.
Jun 10 2020, 3:30 PM · Arcanist

Jun 9 2020

epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I am considering reviving the command server since I don't remember it having any critical failures, but offhand:

Jun 9 2020, 5:44 PM · Mercurial, Arcanist
epriestley added a revision to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: D21343: Disambiguate various types of Mercurial remote markers with "hg arc-ls-remote".
Jun 9 2020, 5:27 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21343: Disambiguate various types of Mercurial remote markers with "hg arc-ls-remote".
Jun 9 2020, 5:27 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I'm going to try writing a Mercurial extension instead.

Jun 9 2020, 4:23 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I believe this is roughly the form we end up with, which is completely ridiculous and extremely difficult to test or have any confidence in:

Jun 9 2020, 3:27 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

As a tool developer, this kind of thing is infuriating:

Jun 9 2020, 3:14 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

This is also made more complicated because Mercurial branches and bookmarks are all in a single shared namespace to some degree. I'm not sure what happens if you try to fetch a bookmark that conflicts with a local branch name (presumably: it renames it as "divergent"?) or try to fetch a branch which conflicts with a local bookmark name (presumably: fails in a way that's hard to detect?).

Jun 9 2020, 2:14 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

When the user specifies arc land --onto marker, I'd like to identify whether marker is a bookmark or branch.

Jun 9 2020, 1:58 PM · Mercurial, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21342: Verify remotes ("paths") in Mercurial during "arc land".
Jun 9 2020, 1:35 PM · Arcanist
epriestley moved T13214: When there is no remote Mercurial URI, `hg paths default` exits with an error code from Backlog to arc land on the Arcanist board.
Jun 9 2020, 1:07 PM · Mercurial, Arcanist
epriestley moved T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark" from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Guides, Arcanist
epriestley moved T13545: Upgrading: Mid 2020 Changes to "arc diff" from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist, Guides
epriestley moved T13544: Modernize the "arc diff" workflow from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist
epriestley moved T13490: Upgrade all "classic" Arcanist workflows to Toolsets from Backlog to vNext on the Arcanist board.
Jun 9 2020, 2:09 AM · Arcanist
epriestley closed T13488: Upgrading: Early 2020 Changes to Arcanist as Resolved.

See T13545, T13547, T13548, for the next round.

Jun 9 2020, 2:09 AM · Arcanist, Installing & Upgrading
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`, as Resolved.
Jun 9 2020, 12:32 AM · Prioritized, Restricted Project, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked, as Resolved.
Jun 9 2020, 12:32 AM · Differential, Arcanist, Feature Request
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T6072: Improve usability of `arc diff`, as Resolved.
Jun 9 2020, 12:32 AM · Restricted Project, Documentation, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist as Resolved.

This approximately exists now via T11968.

Jun 9 2020, 12:32 AM · Restricted Project, Prioritized, Arcanist
epriestley closed T11355: Build a flexible revision lookup API in Arcanist, a subtask of T10895: Support`arc browse --revision <commit>` and make `arc browse` with no arguments mean `... --revision HEAD`, as Resolved.
Jun 9 2020, 12:32 AM · Arcanist, Prioritized, Restricted Project, Feature Request
epriestley closed T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote as Resolved.

I'm not 100% sure I got this, but all of these seem to work now:

Jun 9 2020, 12:29 AM · Arcanist

Jun 8 2020

epriestley added a revision to T13546: Modernize the "arc land" workflow: D21341: Refine "arc land" behavior when pushing "onto" a new branch.
Jun 8 2020, 11:56 PM · Arcanist
epriestley closed T13380: `git push` fatals when CWD does not exist as Resolved by committing rARCf3f31155b761: Format "arc land" passthru commands more nicely, and execute them from CWD.
Jun 8 2020, 11:26 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

Screen Shot 2020-06-08 at 4.23.04 PM.png (1×1 px, 932 KB)

Jun 8 2020, 11:24 PM · Arcanist
epriestley closed T5420: Pipe output to a pager as Resolved by committing rARCb62919f7e48a: Show some "arc" help pages through a configurable pager, like "less".
Jun 8 2020, 11:22 PM · Arcanist, libphutil
epriestley closed T12876: Improve initial arc land experience when destination repo is empty as Resolved by committing rARC8a53b5a4517d: When landing changes in an empty repository, merge cleanly in Git.
Jun 8 2020, 11:20 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21340: Support "arc land --pick" to pick specific changes out of a sequence.
Jun 8 2020, 11:16 PM · Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 8 2020, 10:54 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21339: Improve "arc land" behavior in the presence of merge conflicts and change sequences.
Jun 8 2020, 10:42 PM · Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21338: Allow "arc" to accept any prefix of a command as that command.
Jun 8 2020, 9:53 PM · Arcanist
epriestley closed T2928: "arc start" / "arc feature" / "arc push" Discussion as Resolved.

After D12336:

Jun 8 2020, 9:44 PM · Phrequent, Maniphest, Arcanist
epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jun 8 2020, 9:42 PM · Guides, Arcanist
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21337: Remove "arc feature", "arc branch", "arc bookmark", and significant chunks of obsolete marker code.
Jun 8 2020, 9:36 PM · Arcanist