Page MenuHomePhabricator
Differential D21354

In "arc land" under Git, confirm branch creation
ClosedPublic
Actions

Authored by epriestley on Jun 11 2020, 2:48 PM.
Tags
None
Referenced Files
F18780086: D21354.id50867.diff
Sat, Oct 11, 11:09 PM
F18769628: D21354.id50832.diff
Wed, Oct 8, 8:25 AM
F18753777: D21354.id.diff
Sat, Oct 4, 8:14 PM
F18745135: D21354.id50831.diff
Fri, Oct 3, 5:26 AM
F18283965: D21354.diff
Aug 23 2025, 2:16 AM
F18198684: D21354.diff
Aug 18 2025, 1:09 AM
F18101192: D21354.id.diff
Aug 9 2025, 12:22 PM
F18099073: D21354.diff
Aug 9 2025, 1:15 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13546: Modernize the "arc land" workflow
Commits
rARCb0a9ef8351f1: In "arc land" under Git, confirm branch creation
Summary

Ref T13546. If "arc land" would create a branch, warn the user before it does.

Test Plan

Ran "arc land --onto mtarse", a typo of "master".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 11 2020, 2:48 PM
Harbormaster completed remote builds in B24651: Diff 50831.Jun 11 2020, 2:48 PM
epriestley requested review of this revision.Jun 11 2020, 2:48 PM
epriestley updated this revision to Diff 50832.Jun 11 2020, 2:48 PM
  • Fix undeclared "$markers".
Harbormaster completed remote builds in B24652: Diff 50832.Jun 11 2020, 2:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 30 2020, 1:29 PM
Closed by commit rARCb0a9ef8351f1: In "arc land" under Git, confirm branch creation (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARCb0a9ef8351f1: In "arc land" under Git, confirm branch creation.

Revision Contents
Changeset List

PathSize
src/
land/
engine/
62 lines
5 lines
18 lines
repository/
marker/
54 lines
xsprintf/
1 line

Diff 50867

View Options

src/land/engine/ArcanistGitLandEngine.php

Loading...
View Options

src/land/engine/ArcanistLandEngine.php

Loading...
View Options

src/land/engine/ArcanistMercurialLandEngine.php

Loading...
View Options

src/repository/marker/ArcanistGitRepositoryMarkerQuery.php

Loading...
View Options

src/xsprintf/tsprintf.php

Loading...
Phabricator · Built by Phacility