Page MenuHomePhabricator

Update "arc land" display of build failures, and rename "DisplayRef" to "RefView"
ClosedPublic

Authored by epriestley on Jun 11 2020, 1:29 PM.

Details

Summary

Ref T13546. Show ongoing and failed builds more clearly in "arc land" output.

Also rename "DisplayRef" (which is not a "Ref") to "RefView" with the goal of improving clarity, and let callers "build...()" it so they can add more status, etc., information.

Get rid of "[DisplayRef|RefView]Interface". In theory, future refs (say, in Phabricator) might not do anything here, but every Ref just ends up implementing it. This could perhaps be subclassed more narrowly in the future if necessary.

Test Plan

Ran "arc land", grepped for various symbols.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 11 2020, 1:29 PM
epriestley requested review of this revision.Jun 11 2020, 1:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jun 30, 1:28 PM
This revision was automatically updated to reflect the committed changes.