Differential D21351

Improve "--hold", save/restore state, bookmark creation, and some warnings for "arc land" in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jun 11 2020, 12:08 AM.

Tags

None

Referenced Files

	F19507972: D21351.diff
	Sat, Jan 10, 12:22 AM

	F19048043: D21351.id50821.diff
	Nov 27 2025, 1:56 PM

	F19043362: D21351.id50821.diff
	Nov 26 2025, 9:45 PM

	F18981272: D21351.id50822.diff
	Nov 17 2025, 3:02 AM

	F18981271: D21351.id50823.diff
	Nov 17 2025, 3:02 AM

	F18805732: D21351.id50822.diff
	Oct 18 2025, 4:16 PM

	F18768228: D21351.id50821.diff
	Oct 8 2025, 2:28 AM

	F18753822: D21351.diff
	Oct 4 2025, 8:25 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads
T13546: Modernize the "arc land" workflow
Commits: rARC92f860ae9b2f: Improve "--hold", save/restore state, bookmark creation, and some warnings for…

Summary

Ref T13546. Ref T9948.

Make "--hold" show the same set of commands to manually push that the normal workflow would use.
Make save/restore state work.
Make bookmark creation prompt for confirmation.
Improve / provide some additional warnings and help text.

Test Plan

Ran various increasingly complex "arc land" workflows, e.g. "arc land --hold --onto fauxmark1 --onto fauxmark2 --into default . --revision 118 --trace"

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 11 2020, 12:08 AM

Harbormaster completed remote builds in B24641: Diff 50821.Jun 11 2020, 12:08 AM

epriestley requested review of this revision.Jun 11 2020, 12:08 AM

Fix pht() issue.

Harbormaster completed remote builds in B24642: Diff 50822.Jun 11 2020, 12:28 AM

Actually fix pht() issue.

Harbormaster completed remote builds in B24643: Diff 50823.Jun 11 2020, 12:28 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 11 2020, 12:31 AM

This revision was landed with ongoing or failed builds.

Closed by commit rARC92f860ae9b2f: Improve "--hold", save/restore state, bookmark creation, and some warnings for… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC92f860ae9b2f: Improve "--hold", save/restore state, bookmark creation, and some warnings for….

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistMercurialLandEngine.php

170 lines

repository/

state/

ArcanistGitLocalState.php

5 lines

ArcanistMercurialLocalState.php

55 lines

ArcanistRepositoryLocalState.php

4 lines

workflow/

ArcanistLandWorkflow.php

5 lines

Diff 50826

src/land/engine/ArcanistMercurialLandEngine.php

Loading...

src/repository/state/ArcanistGitLocalState.php

Loading...

src/repository/state/ArcanistMercurialLocalState.php

Loading...

src/repository/state/ArcanistRepositoryLocalState.php

Loading...

src/workflow/ArcanistLandWorkflow.php

Loading...