Differential D21351

Improve "--hold", save/restore state, bookmark creation, and some warnings for "arc land" in Mercurial
ClosedPublic
Actions

Authored by epriestley on Jun 11 2020, 12:08 AM.

Tags

None

Referenced Files

	F15412203: D21351.id50823.diff
	Wed, Mar 19, 11:48 AM

	F15409339: D21351.id50826.diff
	Wed, Mar 19, 4:17 AM

	F15378990: D21351.diff
	Thu, Mar 13, 6:02 PM

	F15369629: D21351.diff
	Wed, Mar 12, 7:35 AM

	F15283002: D21351.diff
	Tue, Mar 4, 4:23 AM

	Unknown Object (File)
	Sat, Feb 22, 7:22 PM

	Unknown Object (File)
	Fri, Feb 21, 2:58 PM

	Unknown Object (File)
	Wed, Feb 19, 11:47 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads
T13546: Modernize the "arc land" workflow
Commits: rARC92f860ae9b2f: Improve "--hold", save/restore state, bookmark creation, and some warnings for…

Summary

Ref T13546. Ref T9948.

Make "--hold" show the same set of commands to manually push that the normal workflow would use.
Make save/restore state work.
Make bookmark creation prompt for confirmation.
Improve / provide some additional warnings and help text.

Test Plan

Ran various increasingly complex "arc land" workflows, e.g. "arc land --hold --onto fauxmark1 --onto fauxmark2 --into default . --revision 118 --trace"

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 11 2020, 12:08 AM

Harbormaster completed remote builds in B24641: Diff 50821.Jun 11 2020, 12:08 AM

epriestley requested review of this revision.Jun 11 2020, 12:08 AM

Fix pht() issue.

Harbormaster completed remote builds in B24642: Diff 50822.Jun 11 2020, 12:28 AM

Actually fix pht() issue.

Harbormaster completed remote builds in B24643: Diff 50823.Jun 11 2020, 12:28 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 11 2020, 12:31 AM

This revision was landed with ongoing or failed builds.

Closed by commit rARC92f860ae9b2f: Improve "--hold", save/restore state, bookmark creation, and some warnings for… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC92f860ae9b2f: Improve "--hold", save/restore state, bookmark creation, and some warnings for….

Revision Contents
Changeset List

Path

Size

src/

land/

engine/

ArcanistMercurialLandEngine.php

170 lines

repository/

state/

ArcanistGitLocalState.php

5 lines

ArcanistMercurialLocalState.php

55 lines

ArcanistRepositoryLocalState.php

4 lines

workflow/

ArcanistLandWorkflow.php

5 lines

Diff 50826

src/land/engine/ArcanistMercurialLandEngine.php

Loading...

src/repository/state/ArcanistGitLocalState.php

Loading...

src/repository/state/ArcanistMercurialLocalState.php

Loading...

src/repository/state/ArcanistRepositoryLocalState.php

Loading...

src/workflow/ArcanistLandWorkflow.php

Loading...