Page MenuHomePhabricator
Feed Advanced Search

Oct 31 2019

epriestley added a revision to T13440: Provide a richer "Revisions/Commits" UI in Maniphest: Restricted Differential Revision.
Oct 31 2019, 6:13 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13440: Provide a richer "Revisions/Commits" UI in Maniphest: Unknown Object (Differential Revision).
Oct 31 2019, 6:10 PM · Diffusion, Differential, Maniphest
epriestley triaged T13440: Provide a richer "Revisions/Commits" UI in Maniphest as Low priority.
Oct 31 2019, 5:05 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
Oct 31 2019, 3:59 PM · Customer Impact, Diffusion (v3)
epriestley added a revision to T13439: Include repository information on commit hovercards: Unknown Object (Differential Revision).
Oct 31 2019, 3:58 PM · Diffusion
epriestley added a comment to T13439: Include repository information on commit hovercards.

Show audit status?

Oct 31 2019, 3:23 PM · Diffusion
epriestley added a comment to T13439: Include repository information on commit hovercards.

Here's the current hovercard:

Oct 31 2019, 3:21 PM · Diffusion

Oct 29 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
Oct 29 2019, 8:46 PM · Plans, Facts
epriestley triaged T13439: Include repository information on commit hovercards as Low priority.
Oct 29 2019, 8:42 PM · Diffusion
epriestley added a revision to T13438: Implement "harbormaster.artifact.search": Unknown Object (Differential Revision).
Oct 29 2019, 8:30 PM · Harbormaster
epriestley triaged T13438: Implement "harbormaster.artifact.search" as Low priority.
Oct 29 2019, 8:29 PM · Harbormaster
epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

After D20877, we'll forcefully override this option when generating diffs internally.

Oct 29 2019, 5:15 PM · Differential
epriestley added a revision to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: Unknown Object (Differential Revision).
Oct 29 2019, 5:12 PM · Differential
epriestley updated the task description for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 29 2019, 5:04 PM · Differential
epriestley closed T13437: "Jump to Symbol" URIs from diff views are built without proper escaping as Resolved by committing Restricted Diffusion Commit.
Oct 29 2019, 4:48 PM · Diffusion, Differential
epriestley updated the task description for T13437: "Jump to Symbol" URIs from diff views are built without proper escaping.
Oct 29 2019, 4:48 PM · Diffusion, Differential
epriestley added a revision to T13437: "Jump to Symbol" URIs from diff views are built without proper escaping: Unknown Object (Differential Revision).
Oct 29 2019, 4:41 PM · Diffusion, Differential
epriestley triaged T13437: "Jump to Symbol" URIs from diff views are built without proper escaping as Low priority.
Oct 29 2019, 4:32 PM · Diffusion, Differential
epriestley added a comment to T13436: Improve performance of "ssh-auth".

I deployed the --sshd-key %k stuff to secure and it looks like that shaved ~1,000-2000ms off the total cost. The ssh-auth cost has dropped to about 200ms:

Oct 29 2019, 1:47 AM · Diffusion, Phacility, Infrastructure
epriestley added a revision to T13436: Improve performance of "ssh-auth": Unknown Object (Differential Revision).
Oct 29 2019, 1:31 AM · Diffusion, Phacility, Infrastructure
epriestley added a revision to T13436: Improve performance of "ssh-auth": Unknown Object (Differential Revision).
Oct 29 2019, 12:49 AM · Diffusion, Phacility, Infrastructure
epriestley added a revision to T13436: Improve performance of "ssh-auth": Unknown Object (Differential Revision).
Oct 29 2019, 12:36 AM · Diffusion, Phacility, Infrastructure
epriestley added a comment to T13436: Improve performance of "ssh-auth".

I saw things hang during deploy and the OpenSSH bug should have been fixed years ago.

Oct 29 2019, 12:20 AM · Diffusion, Phacility, Infrastructure
epriestley added a comment to T13436: Improve performance of "ssh-auth".

I configured ControlMaster on secure.

Oct 29 2019, 12:14 AM · Diffusion, Phacility, Infrastructure

Oct 28 2019

epriestley triaged T13436: Improve performance of "ssh-auth" as Normal priority.
Oct 28 2019, 11:00 PM · Diffusion, Phacility, Infrastructure
epriestley closed T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt as Resolved by committing Restricted Diffusion Commit.
Oct 28 2019, 9:44 PM · Diffusion
epriestley added a revision to T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt: Unknown Object (Differential Revision).
Oct 28 2019, 9:35 PM · Diffusion
epriestley added a revision to T13434: Support Perforce/Git in "arc land": Unknown Object (Differential Revision).
Oct 28 2019, 6:52 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

Under the --merge workflow (which does a --no-ff merge and always generates a merge commit; as opposed to the --squash strategy, which does a rebase-like squash merge) the git p4 submit --commit ... fails:

Oct 28 2019, 6:47 PM · Arcanist
epriestley closed T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched as Resolved by committing Restricted Diffusion Commit.
Oct 28 2019, 6:31 PM · Restricted Project, Arcanist
epriestley closed T12668: "arc help land" says "current branch", but means "branch targeted by the land operation" as Resolved by committing Restricted Diffusion Commit.
Oct 28 2019, 6:25 PM · Arcanist
epriestley added a revision to T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched: Unknown Object (Differential Revision).
Oct 28 2019, 6:20 PM · Restricted Project, Arcanist
epriestley added a revision to T13434: Support Perforce/Git in "arc land": Unknown Object (Differential Revision).
Oct 28 2019, 6:04 PM · Arcanist
epriestley added a revision to T12668: "arc help land" says "current branch", but means "branch targeted by the land operation": Unknown Object (Differential Revision).
Oct 28 2019, 6:04 PM · Arcanist
epriestley claimed T12668: "arc help land" says "current branch", but means "branch targeted by the land operation".
Oct 28 2019, 6:01 PM · Arcanist
epriestley added a revision to T13434: Support Perforce/Git in "arc land": Unknown Object (Differential Revision).
Oct 28 2019, 5:40 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

I'm passing these additional flags to git p4 submit:

Oct 28 2019, 5:01 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

If you haven't logged in to Perforce recently (I think?), the sync can fail like this:

Oct 28 2019, 4:31 PM · Arcanist
epriestley added a revision to T13434: Support Perforce/Git in "arc land": Unknown Object (Differential Revision).
Oct 28 2019, 4:04 PM · Arcanist
epriestley edited the content of 2019 Week 43 (Late October).
Oct 28 2019, 3:10 PM
epriestley created an object: 2019 Week 43 (Late October).
Oct 28 2019, 3:09 PM
epriestley edited the content of Changelog.
Oct 28 2019, 2:52 PM
siepkes awarded T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool a Like token.
Oct 28 2019, 12:40 PM · Diffusion

Oct 26 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Oct 26 2019, 7:09 PM · Differential
epriestley added a comment to T13233: Consider supporting GPG/PGP.

I am running through GPG for the first time:

Oct 26 2019, 6:44 PM · Diffusion, Mail

Oct 25 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Oct 25 2019, 6:47 PM · Differential
epriestley merged task T11362: Arcanist tries to land onto identical remote branch instead of 'master' into T11535: Make it possible for arc land to disable upstream branch tracking.
Oct 25 2019, 6:20 PM · Arcanist, Bug Report
epriestley merged T11362: Arcanist tries to land onto identical remote branch instead of 'master' into T11535: Make it possible for arc land to disable upstream branch tracking.
Oct 25 2019, 6:20 PM · Arcanist, Restricted Project
epriestley added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

I'm going to merge this into T11535 since it's basically the same issue.

Oct 25 2019, 6:20 PM · Arcanist, Bug Report
epriestley renamed T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote from Arcanist not always pulling landed branch to On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote.
Oct 25 2019, 6:17 PM · Arcanist
epriestley closed T5964: When landing, it might be nice if arcanist could check if changes are being pushed to the canonical git repository as Wontfix.

This hasn't come up again, so it looks like it probably isn't a feature that would see a lot of general use.

Oct 25 2019, 6:12 PM · Arcanist
epriestley moved T5852: arc should ignore abandoned revisions when landing from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:06 PM · Restricted Project, Arcanist
epriestley moved T11535: Make it possible for arc land to disable upstream branch tracking from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:05 PM · Arcanist, Restricted Project
epriestley edited projects for T11535: Make it possible for arc land to disable upstream branch tracking, added: Arcanist; removed Feature Request.
Oct 25 2019, 6:05 PM · Arcanist, Restricted Project
epriestley moved T2493: Support `arc land` in stacked commits from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:04 PM · Restricted Project, Arcanist
epriestley moved T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:04 PM · Prioritized, Restricted Project, Arcanist
epriestley moved T5964: When landing, it might be nice if arcanist could check if changes are being pushed to the canonical git repository from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:04 PM · Arcanist
epriestley moved T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:03 PM · Arcanist
epriestley moved T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:03 PM · Restricted Project, Arcanist
epriestley moved T11362: Arcanist tries to land onto identical remote branch instead of 'master' from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:03 PM · Arcanist, Bug Report
epriestley moved T12668: "arc help land" says "current branch", but means "branch targeted by the land operation" from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley moved T12876: Improve initial arc land experience when destination repo is empty from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley moved T13434: Support Perforce/Git in "arc land" from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

Why not just implement the basic path for arc land and fail with an error if the user has some esoteric setup?

Oct 25 2019, 5:54 PM · Arcanist
epriestley triaged T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt as Low priority.
Oct 25 2019, 10:43 AM · Diffusion
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory

Oct 25 2019, 10:26 AM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

I got Git/Perforce working after a large amount of bashing my head into errors like these:

Oct 25 2019, 3:20 AM · Arcanist
epriestley triaged T13434: Support Perforce/Git in "arc land" as Low priority.
Oct 25 2019, 2:12 AM · Arcanist
epriestley closed T13431: Make "Members" lists in projects more clear about disabled members as Resolved by committing Restricted Diffusion Commit.
Oct 25 2019, 1:41 AM · Projects
epriestley closed T13433: Continue showing custom login instructions on provider-specific login screens as Resolved by committing Restricted Diffusion Commit.
Oct 25 2019, 1:38 AM · Auth
epriestley added a revision to T13431: Make "Members" lists in projects more clear about disabled members: Unknown Object (Differential Revision).
Oct 25 2019, 1:35 AM · Projects
epriestley added a revision to T13433: Continue showing custom login instructions on provider-specific login screens: Unknown Object (Differential Revision).
Oct 25 2019, 1:07 AM · Auth
epriestley triaged T13433: Continue showing custom login instructions on provider-specific login screens as Low priority.
Oct 25 2019, 12:56 AM · Auth
epriestley closed T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date) as Resolved by committing Restricted Diffusion Commit.
Oct 25 2019, 12:17 AM · Conduit, Diffusion

Oct 24 2019

epriestley added a revision to T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date): Unknown Object (Differential Revision).
Oct 24 2019, 11:44 PM · Conduit, Diffusion
epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

One change we can make here is to explicitly specify -c diff.suppressBlankEmpty false in the arc diff command, as we currently use --src-prefix and --dst-prefix to override diff.mnemonicprefix. This is likely desirable, but it would be good to also parse these diffs properly if they arrive through --raw or copy/pasting, etc.

Oct 24 2019, 11:02 PM · Differential
Pawka awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Oct 24 2019, 5:48 AM · Arcanist
epriestley renamed T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Diffs that have had tailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly to Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Differential
epriestley added a parent task for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Oct 24 2019, 2:43 AM · Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Arcanist, Differential
epriestley triaged T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly as Wishlist priority.
Oct 24 2019, 2:43 AM · Differential

Oct 22 2019

epriestley triaged T13431: Make "Members" lists in projects more clear about disabled members as Low priority.
Oct 22 2019, 5:38 PM · Projects

Oct 17 2019

epriestley triaged T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date) as Low priority.
Oct 17 2019, 5:27 PM · Conduit, Diffusion
epriestley closed T13427: Task to reproduce lack of transaction object validation as Resolved.

This now renders properly; see T13429 for followup.

Oct 17 2019, 5:03 PM · artms
epriestley added a revision to T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior: Unknown Object (Differential Revision).
Oct 17 2019, 4:43 PM · Transactions
epriestley triaged T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior as Low priority.
Oct 17 2019, 4:34 PM · Transactions
epriestley closed T13428: PHP 7.4 now warns about "implode()" argument order as Resolved by committing Restricted Diffusion Commit.
Oct 17 2019, 4:11 PM · Infrastructure
epriestley updated the task description for T13428: PHP 7.4 now warns about "implode()" argument order.
Oct 17 2019, 4:08 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: Unknown Object (Differential Revision).
Oct 17 2019, 4:07 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: Unknown Object (Differential Revision).
Oct 17 2019, 4:05 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: Unknown Object (Differential Revision).
Oct 17 2019, 4:03 PM · Infrastructure
epriestley triaged T13428: PHP 7.4 now warns about "implode()" argument order as Low priority.
Oct 17 2019, 4:03 PM · Infrastructure

Oct 10 2019

epriestley added a comment to T13322: Allow parent projects to have direct members.

See PHI1492. After this change, the parent/subproject modes of the script in T10350 can be brought upstream safely, since they would no longer be destructive operations on membership lists. This wouldn't cover the "convert a project into a milestone" mode, but that seems less important.

Oct 10 2019, 2:51 PM · Projects
epriestley added a parent task for T10350: Scripts to migrate old "points" fields and move projects beneath other projects: T13322: Allow parent projects to have direct members.
Oct 10 2019, 2:50 PM · Projects (v3)
epriestley added a subtask for T13322: Allow parent projects to have direct members: T10350: Scripts to migrate old "points" fields and move projects beneath other projects.
Oct 10 2019, 2:50 PM · Projects
epriestley added a revision to T13416: Transaction logs may overheat explosively: Unknown Object (Differential Revision).
Oct 10 2019, 2:35 PM · Feed

Oct 8 2019

20after4 awarded T13419: Fully modularize object relationships, to support custom relationships like "Subtask/Parent Task" a Love token.
Oct 8 2019, 9:57 PM · Infrastructure

Oct 2 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Oct 2 2019, 3:50 PM · Differential

Oct 1 2019

mcorteel awarded T13410: Update Phriction UI structural behaviors a Love token.
Oct 1 2019, 6:32 AM · Phriction

Sep 30 2019

epriestley edited the content of Changelog.
Sep 30 2019, 6:12 PM