Maniphest T13437

"Jump to Symbol" URIs from diff views are built without proper escaping
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Oct 29 2019, 4:32 PM

Tags

Referenced Files

None

Subscribers

Description

See PHI1480. If symbols are configured and you Command-Click a symbol like #define, you get a URL like /symbol/#define/, which is not valid.

Revisions and Commits

rP Phabricator
	D20876	rPe1da1d86d680 Trim and URI encode symbol names before building URIs from them

Related Objects

Mentioned In: T13638: Investigate "AllowEncodedSlashes" Apache setting

Event Timeline

epriestley triaged this task as Low priority.Oct 29 2019, 4:32 PM

epriestley created this task.

Herald added a subscriber: amckinley. · View Herald TranscriptOct 29 2019, 4:32 PM

epriestley added a revision: D20876: Trim and URI encode symbol names before building URIs from them.Oct 29 2019, 4:41 PM

epriestley updated the task description. (Show Details)Oct 29 2019, 4:48 PM

epriestley closed this task as Resolved by committing rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them.Oct 29 2019, 4:48 PM

epriestley added a commit: rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them.

epriestley mentioned this in T13638: Investigate "AllowEncodedSlashes" Apache setting.Mar 17 2021, 10:15 PM