Page MenuHomePhabricator
Feed All Stories

May 20 2019

epriestley added revisions to T11229: Quotes breaks headings by default: Restricted Differential Revision, Unknown Object (Differential Revision).
May 20 2019, 12:03 PM · Remarkup, Bug Report
asherkin added a revision to T13293: `arc land` using git-svn fails in certain configurations: Unknown Object (Differential Revision).
May 20 2019, 11:56 AM · Subversion, Git, Arcanist
asherkin created T13293: `arc land` using git-svn fails in certain configurations.
May 20 2019, 11:56 AM · Subversion, Git, Arcanist
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 20 2019, 11:47 AM · Diffusion
epriestley updated the task description for T13289: Plans: 2019 Week 21-23 Bonus Content.
May 20 2019, 1:36 AM · Plans

May 19 2019

epriestley triaged T13292: Create a "Sounds" application as Normal priority.
May 19 2019, 9:04 PM · Sounds
epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 19 2019, 8:48 PM · Remarkup, Diffusion

May 17 2019

epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 17 2019, 3:13 PM · Remarkup, Diffusion
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
May 17 2019, 2:43 PM · Dashboards
epriestley added a revision to T8033: Inform editor when panels have more restrictive policy than dashboard: Unknown Object (Differential Revision).
May 17 2019, 2:36 PM · Dashboards
epriestley added a project to T13285: Service failures in JIRA can cascade into service failures in Phabricator: Doorkeeper.
May 17 2019, 2:24 PM · Doorkeeper
epriestley triaged T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion as Normal priority.
May 17 2019, 2:22 PM · Remarkup, Diffusion
epriestley closed T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Resolved.

This stuff is largely resolved, but survived by a few remaining issues in T13290.

May 17 2019, 2:18 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a parent task for T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily: T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".
May 17 2019, 2:17 PM · Restricted Project, Prioritized, Differential
epriestley added a parent task for T7333: Empty commits get same revision as parent: T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".
May 17 2019, 2:17 PM · Differential
epriestley added subtasks for T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily, T7333: Empty commits get same revision as parent.
May 17 2019, 2:17 PM · Diffusion, Differential
epriestley added a project to T7333: Empty commits get same revision as parent: Differential.
May 17 2019, 2:17 PM · Differential
epriestley triaged T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" as Normal priority.
May 17 2019, 2:15 PM · Diffusion, Differential

May 16 2019

epriestley claimed T13289: Plans: 2019 Week 21-23 Bonus Content.
May 16 2019, 9:37 PM · Plans
epriestley triaged T13289: Plans: 2019 Week 21-23 Bonus Content as Normal priority.
May 16 2019, 9:37 PM · Plans
epriestley closed T13263: Plans: 2019 Week 11-15 Bonus Content as Resolved.
May 16 2019, 9:35 PM · Plans
epriestley edited the content of 2019 Week 20 (Late May).
May 16 2019, 9:18 PM
epriestley edited the content of Changelog.
May 16 2019, 9:01 PM
epriestley edited the content of 2019 Week 17 (Very Late April).
May 16 2019, 9:01 PM
epriestley created 2019 Week 20 (Late May).
May 16 2019, 9:00 PM
epriestley created 2019 Week 19 (Mid May).
May 16 2019, 8:39 PM
epriestley created 2019 Week 18 (Early May).
May 16 2019, 8:39 PM
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: Unknown Object (Differential Revision).
May 16 2019, 8:16 PM · Herald
epriestley triaged T13288: Add a "Download" / view raw option to code blocks in Remarkup as Low priority.
May 16 2019, 7:52 PM · Remarkup
simevo added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

For all who might need to migrate from trac to Phabricator, feel free to borrow from this bare-bone script: https://gitlab.com/simevo/trac2phab

May 16 2019, 2:27 PM · Guides, Doorkeeper

May 13 2019

epriestley published a new version of Welcome.
May 13 2019, 7:40 PM
epriestley edited the content of Dependencies.
May 13 2019, 7:37 PM
epriestley created Dependencies.
May 13 2019, 7:01 PM
epriestley deleted Production Configuration.
May 13 2019, 6:42 PM
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: Unknown Object (Differential Revision).
May 13 2019, 5:30 PM · Herald
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: Unknown Object (Differential Revision).
May 13 2019, 5:15 PM · Herald
epriestley added a revision to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon: Unknown Object (Differential Revision).
May 13 2019, 5:02 PM · Herald
epriestley added a comment to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon.

pass the applied transactions to Herald

May 13 2019, 4:56 PM · Herald

May 10 2019

epriestley triaged T13287: Build general healthcheck infrastructure for monitoring services as Low priority.
May 10 2019, 5:45 PM · Clusters, Almanac
epriestley added a subtask for T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: T13287: Build general healthcheck infrastructure for monitoring services.
May 10 2019, 5:45 PM · Clusters, Diffusion
epriestley added a subtask for T13285: Service failures in JIRA can cascade into service failures in Phabricator: T13287: Build general healthcheck infrastructure for monitoring services.
May 10 2019, 5:45 PM · Doorkeeper
epriestley added parent tasks for T13287: Build general healthcheck infrastructure for monitoring services: T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover, T13285: Service failures in JIRA can cascade into service failures in Phabricator.
May 10 2019, 5:45 PM · Clusters, Almanac
epriestley created T13287: Build general healthcheck infrastructure for monitoring services.
May 10 2019, 5:45 PM · Clusters, Almanac
epriestley triaged T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover as Normal priority.
May 10 2019, 5:24 PM · Clusters, Diffusion
epriestley added a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T13285: Service failures in JIRA can cascade into service failures in Phabricator.
May 10 2019, 2:15 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a subtask for T13285: Service failures in JIRA can cascade into service failures in Phabricator: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 10 2019, 2:15 PM · Doorkeeper
epriestley triaged T13285: Service failures in JIRA can cascade into service failures in Phabricator as Normal priority.
May 10 2019, 2:15 PM · Doorkeeper
joshuaspence edited the content of Community Resources.
May 10 2019, 12:52 AM

May 9 2019

epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 8:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Got it, thanks for clarifying.

May 9 2019, 8:05 PM · Workboards (v3), Restricted Project
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 7:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop). Is this expected / intentional?

May 9 2019, 6:54 PM · Workboards (v3), Restricted Project
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop).

May 9 2019, 6:51 PM · Workboards (v3), Restricted Project
epriestley added a subtask for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T9720: Provide a way to link to Diffusion files.
May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a parent task for T9720: Provide a way to link to Diffusion files: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:31 PM · Restricted Project, Remarkup
epriestley added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

PHI1224 describes a somewhat-adjacent situation: an install would like a way for external automated tooling to reference source files and generate editor links for them.

May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley claimed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley removed a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T7443: Include full link to Maniphest tasks in commit messages.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley removed a subtask for T7443: Include full link to Maniphest tasks in commit messages: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Diffusion, Arcanist
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 9 2019, 6:21 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1231 would like API access to coverage.

May 9 2019, 5:51 PM · Diffusion, Plans
epriestley moved T11372: Multiple coverage columns for different types of code coverage from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley edited projects for T11372: Multiple coverage columns for different types of code coverage, added: Diffusion; removed Feature Request.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley closed T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository as Resolved.

My expectation is that this is effectively resolved by T13277. Since "Autoclose" is no longer a separate permission from "Publish", commits should now always mention + close or never mention + close.

May 9 2019, 5:05 PM · Transactions, Diffusion
epriestley moved T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published from Backlog to "Track Only" on the Diffusion board.
May 9 2019, 5:03 PM · Diffusion
epriestley moved T9524: Show aggregate subdirectory coverage in Diffusion browse views from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Restricted Project
epriestley moved T13125: Plans: Code coverage reporting from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Plans

May 8 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 7:54 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

The actual facts Maniphest currently generates need to be adjusted to properly support stacked-area-by-reason: currently, when a task is closed, we don't have enough data to figure out whether it should be removed from the "created into this project" area, the "reopened work" area, or the "moved work" area.

May 8 2019, 7:14 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 4:35 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 3:55 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 3:44 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 2:22 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 8 2019, 1:55 PM · Plans, Facts
wppd edited the content of Organizations Using Phabricator.
May 8 2019, 10:13 AM

May 7 2019

epriestley added a comment to T13279: Build Charting for Facts.

One issue with model we're evolving toward is that if you view a chart in Klingon, then send the link to a user whose primary language is Kerbal, we'd prefer to relabel the chart in Kerbal, not restore serialized Klingon-language chart labels. That means label generation has to be at render time, not at chart construction time, and I'm serializing a data-structure which is slightly too low-level for common application cases.

May 7 2019, 2:07 PM · Plans, Facts

May 5 2019

epriestley added a comment to T13279: Build Charting for Facts.

This is a little ways out, but the actual facts Maniphest currently generates need to be adjusted to properly support stacked-area-by-reason: currently, when a task is closed, we don't have enough data to figure out whether it should be removed from the "created into this project" area, the "reopened work" area, or the "moved work" area. This is okay if we're summing the opens/closes but not precise enough if we're breaking them down.

May 5 2019, 2:48 PM · Plans, Facts

May 4 2019

epriestley added a comment to T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.

Probably, push another commit to Y

May 4 2019, 5:28 PM · Diffusion

May 3 2019

epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 10:44 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 10:15 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 7:16 PM · Plans, Facts
epriestley added a revision to T13279: Build Charting for Facts: Unknown Object (Differential Revision).
May 3 2019, 6:54 PM · Plans, Facts
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 3 2019, 5:37 PM · Diffusion
epriestley triaged T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published as Low priority.
May 3 2019, 5:35 PM · Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Unknown Object (Differential Revision).
May 3 2019, 5:11 PM · Plans, Diffusion
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Unknown Object (Differential Revision).
May 3 2019, 3:00 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13279: Build Charting for Facts.

Multiple Project Burnups Stacked in an Area Chart

May 3 2019, 2:56 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

See also PHI1226. An install has an environment where automatic rules (Herald/Owners) frequently trigger group reviewers (projects/packages), and some groups are not prompt about performing review.

May 3 2019, 2:35 PM · Plans, Facts
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to Next on the Herald board.
May 3 2019, 5:11 AM · Diffusion, Harbormaster, Herald, Audit
epriestley triaged T13283: When Herald acts, include the transaction group as part of the "state" it acts upon as Normal priority.
May 3 2019, 5:11 AM · Herald
epriestley added a comment to T6491: Herald rules based on age.

See PHI1107, which requests Auto-Abandon for old changes and also has a technical outline for this great and wholesome feature.

May 3 2019, 5:04 AM · Restricted Project, Herald
joshuaspence edited the content of Community Resources.
May 3 2019, 4:59 AM
joshuaspence edited the content of Community Resources.
May 3 2019, 4:58 AM
epriestley closed T5462: How do I publish Phabricator events into remote systems? as Resolved.

The answer here is now pretty unambiguously "Use Webhooks". feed.http-hooks is formally deprecated, Herald remains a terrible idea, and anyone brave enough to touch Doorkeeper can probably figure things out for themselves.

May 3 2019, 4:57 AM · Guides, Doorkeeper, Feed, Herald
epriestley closed T5547: Allow members of a project to add rules with project reviewers as Wontfix.

We don't have any current customer interest in this as far as I'm aware. We could revisit this in the future, but I'd like better / more modern use cases (e.g., that aren't addressed by an approach with Owners).

May 3 2019, 4:56 AM · Restricted Project, Herald
epriestley moved T6491: Herald rules based on age from Backlog to Next on the Herald board.
May 3 2019, 4:53 AM · Restricted Project, Herald
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T6183: Allow any user to watch projects, as Resolved.
May 3 2019, 4:53 AM · Wikimedia, Projects
epriestley closed T7703: Policy checks may execute incompletely for non-viewers as Resolved.

Although I'm not entirely confident that 100% of objects which should implement ExtendedPolicyInterface actually do today, I think we've gotten pretty much all of them. This approach also seems stable.

May 3 2019, 4:53 AM · Policy, Herald, Flags
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
May 3 2019, 4:53 AM · Spaces, Wikimedia, Policy