Page MenuHomePhabricator
Feed Advanced Search

Jan 4 2018

epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

Mercurial's protocol negotiation presumably considers the size of the change being transmitted in selecting the protocol format

Jan 4 2018, 10:28 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: Restricted Differential Revision.
Jan 4 2018, 10:13 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: Unknown Object (Differential Revision).
Jan 4 2018, 10:06 PM · Mercurial
epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

I think D18857 fixes the pipe issues. Here's the problem:

Jan 4 2018, 10:04 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: Unknown Object (Differential Revision).
Jan 4 2018, 8:50 PM · Mercurial
epriestley added a revision to T13036: Fix issues with recent Mercurial wire protocol versions: Unknown Object (Differential Revision).
Jan 4 2018, 8:27 PM · Mercurial
epriestley added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

Here's some evidence [that filtering bundle2] doesn't work:
we attempt to filter the protocol and tell the client that we don't support bundle2

Jan 4 2018, 8:20 PM · Mercurial
epriestley triaged T13036: Fix issues with recent Mercurial wire protocol versions as Normal priority.
Jan 4 2018, 7:59 PM · Mercurial
epriestley renamed T10900: Repository content search with `hg grep` returns matches found in old versions of files from Grep file content returns matches found in old versions of files to Repository content search with `hg grep` returns matches found in old versions of files.
Jan 4 2018, 7:40 PM · Mercurial, Diffusion
epriestley moved T10900: Repository content search with `hg grep` returns matches found in old versions of files from Backlog to Far Future on the Mercurial board.
Jan 4 2018, 7:40 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

Actually, this is less crazy than I thought.

Jan 4 2018, 7:39 PM · Mercurial, Diffusion
epriestley added a comment to T10900: Repository content search with `hg grep` returns matches found in old versions of files.

This appears to date back to the introduction of the feature in D5738, where I suggested we use ancestors() without a legitimate reason (or maybe very old Mercurial had weird behavior).

Jan 4 2018, 7:26 PM · Mercurial, Diffusion
epriestley moved T10753: Remove Mercurial daemon working copy operations from Backlog to Clustering on the Mercurial board.
Jan 4 2018, 7:19 PM · Infrastructure, Daemons, Diffusion, Mercurial
epriestley moved T6118: Support for Mercurial extensions in hosted repositories from Backlog to Far Future on the Mercurial board.
Jan 4 2018, 7:14 PM · Mercurial, Diffusion
epriestley merged T6112: Arcanist can not upload binaries when use Mercurial on Windows into T8298: Fix Windows Escaping.
Jan 4 2018, 7:14 PM · Windows
epriestley merged task T6112: Arcanist can not upload binaries when use Mercurial on Windows into T8298: Fix Windows Escaping.
Jan 4 2018, 7:14 PM · Mercurial, Arcanist
epriestley closed T7407: Problem with Mercurial 3.1.2 as Invalid.

We can't reproduce this, and can't fix issues we can't reproduce.

Jan 4 2018, 7:12 PM · Mercurial
epriestley closed T12521: "(Exception) Expected nonempty 'cmds' specification!" when trying to clone or pull mercurial repository as Invalid.

This is possibly connected to T9548 but we don't know how to reproduce this and can't fix issues we can't reproduce.

Jan 4 2018, 7:11 PM · Bug Report (Needs Information)
epriestley added a revision to T13020: Migrate Maniphest transactions to improve consistency: Unknown Object (Differential Revision).
Jan 4 2018, 6:22 PM · Transactions, Facts, Maniphest
epriestley closed T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default as Resolved by committing Restricted Diffusion Commit.
Jan 4 2018, 6:02 PM · Herald, Security, Diffusion
epriestley added a revision to T13020: Migrate Maniphest transactions to improve consistency: Unknown Object (Differential Revision).
Jan 4 2018, 5:43 PM · Transactions, Facts, Maniphest

Jan 3 2018

epriestley added a revision to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: Unknown Object (Differential Revision).
Jan 3 2018, 9:58 PM · Mail, Differential
epriestley added a revision to T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: Unknown Object (Differential Revision).
Jan 3 2018, 9:43 PM · Mail, Differential
epriestley added a subtask for T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured.
Jan 3 2018, 9:40 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added parent tasks for T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured: T13010: Upgrading: Differential Draft State, T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Jan 3 2018, 9:40 PM · Mail, Differential
epriestley added a subtask for T13010: Upgrading: Differential Draft State: T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured.
Jan 3 2018, 9:40 PM · Installing & Upgrading
epriestley triaged T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured as Normal priority.
Jan 3 2018, 9:40 PM · Mail, Differential
epriestley triaged T13034: Diffusion "Branches: None" should be more clear that it means "Branches: No Tracked Branches" as Normal priority.
Jan 3 2018, 4:45 PM · Diffusion

Dec 31 2017

epriestley edited the content of Changelog.
Dec 31 2017, 3:25 PM
epriestley created 2017 Week 52 (End of Year).
Dec 31 2017, 3:24 PM

Dec 26 2017

epriestley closed T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to as Resolved by committing Restricted Diffusion Commit.
Dec 26 2017, 11:59 PM · Differential, Herald, Bug Report
epriestley added a comment to T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.

T13023 provides an example of a synthetic "git-like" diff generated by some tool (dpkg-source?) which appears (?) to pretend to generate Git diffs (diff --git in the text).

Dec 26 2017, 7:29 PM · Arcanist, Differential
epriestley merged T13023: Non-standard patches lead to exceptions being generated into T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Dec 26 2017, 7:29 PM · Arcanist, Differential
epriestley merged task T13023: Non-standard patches lead to exceptions being generated into T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Dec 26 2017, 7:29 PM · Differential
epriestley added a comment to T13023: Non-standard patches lead to exceptions being generated.

I'll merge this into T12664, but realistically it's exceptionally unlikely that we'll add the ability to parse these diffs given one example and no idea how to generate them in the general case, and apparently only one install encounters these diffs, and they aren't generated with a legitimate VCS tool.

Dec 26 2017, 7:28 PM · Differential
epriestley added a revision to T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default: Unknown Object (Differential Revision).
Dec 26 2017, 7:10 PM · Herald, Security, Diffusion
epriestley added a comment to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.

The fix for T13031 may have made this worse by default, since we now extract all pushed changesets and hold them in memory by default, even if no Herald content-based rules which use them actually exist. This may create too much memory pressure if you push a very large number of commits.

Dec 26 2017, 7:03 PM · Restricted Project, Diffusion, Herald
epriestley added a comment to T8132: Webhook Support.

The chatbot was removed completely in D17756.

Dec 26 2017, 5:38 PM · Maniphest, Diffusion
epriestley edited the content of Changelog.
Dec 26 2017, 5:01 PM
epriestley created 2017 Week 51 (Very Late December).
Dec 26 2017, 4:49 PM

Dec 23 2017

epriestley closed T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal as Resolved by committing Restricted Diffusion Commit.
Dec 23 2017, 7:37 PM · Profile Menu Item, Projects
epriestley added a revision to T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal: Unknown Object (Differential Revision).
Dec 23 2017, 4:44 PM · Profile Menu Item, Projects
epriestley awarded T13033: Disabling both "Workboard" and "Project Details" causes project's /tag/ProjectName url to fatal a Hungry Hippo token.
Dec 23 2017, 4:32 PM · Profile Menu Item, Projects

Dec 22 2017

epriestley added a revision to T13024: Fix various session initialization order issues: Unknown Object (Differential Revision).
Dec 22 2017, 8:11 PM · Auth
epriestley added a revision to T12578: Herald rule for "Differential reviewers do not include" didn't fire when I expected it to: Unknown Object (Differential Revision).
Dec 22 2017, 6:19 PM · Differential, Herald, Bug Report
epriestley added a comment to T2312: Modifying PHP.

PHP allows and evaluates these constructions:

Dec 22 2017, 4:39 PM · Infrastructure
epriestley added a comment to T10667: Improve ambiguity when resolving commits that appear in multiple repositories.

With T13001, the commit page itself now gives you disambiguation options if the commits are in the same repository. This is a narrower case than ambiguous commits across multiple repositories, but related if we did pursue something like hovercards or a multi-repository disambiguation page.

Dec 22 2017, 3:01 PM · Diffusion (v3)
epriestley closed T13001: Ambiguous commits should prompt you to select from options as Resolved.

T13028 is a followup but I think everything else here is resolved.

Dec 22 2017, 2:58 PM · Diffusion

Dec 18 2017

epriestley edited the content of Changelog.
Dec 18 2017, 5:56 PM
epriestley created 2017 Week 50 (Late December).
Dec 18 2017, 5:55 PM
epriestley closed T7789: Support Git Large File Storage as Resolved.

T10604 and T4369 do not impact LFS (broadly, they apply only to POST requests, and LFS uses PUT to upload data).

Dec 18 2017, 5:47 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley removed subtasks for T7789: Support Git Large File Storage: T10604: Allow application code to stream request data, T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Dec 18 2017, 5:45 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley removed a parent task for T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: T7789: Support Git Large File Storage.
Dec 18 2017, 5:45 PM · Diffusion (v3), Restricted Project
epriestley removed a parent task for T10604: Allow application code to stream request data: T7789: Support Git Large File Storage.
Dec 18 2017, 5:45 PM · Diffusion (v3), Restricted Project
epriestley triaged T13032: Upgrading: Git LFS as Normal priority.
Dec 18 2017, 5:36 PM · Diffusion, Git, Installing & Upgrading
epriestley renamed T13019: Build Status is integrated into Diffusion in a hacky way from Build Status got dropped from Commit Details View to Build Status is integrated into Diffusion in a hacky way.
Dec 18 2017, 5:21 PM · Diffusion, Harbormaster
epriestley renamed T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews from Open Graph metadata for beautiful rendering of Phabricator URLs to Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews.
Dec 18 2017, 5:20 PM
epriestley added a comment to T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default.

Adjacently, some other parts of the UI currently use the word "enormous" (see https://discourse.phabricator-community.org/t/herald-enormous-check/822). They should be rewritten to use different language (like "Very Large"). We should use the term "Enormous" to mean only "too large to process completely", while the other UI uses it to mean "large enough to partially collapse for viewer convenience".

Dec 18 2017, 4:48 PM · Herald, Security, Diffusion
epriestley triaged T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default as Normal priority.
Dec 18 2017, 4:45 PM · Herald, Security, Diffusion
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

Also, while it's on my mind, all repositories should probably have this rule today:

Dec 18 2017, 4:37 PM · Restricted Project, Herald
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See T7789 and D18827. Block Git LFS in some repositories:

Dec 18 2017, 4:32 PM · Restricted Project, Herald
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See PHI242. SR Latch:

Dec 18 2017, 4:31 PM · Restricted Project, Herald

Dec 13 2017

epriestley edited the content of Changelog.
Dec 13 2017, 9:31 PM
epriestley created 2017 Week 49 (Mid December).
Dec 13 2017, 3:15 PM
epriestley renamed T13030: Accessing a submodule path directly in Diffusion has less than optimal UX from `git cat-file -t <commit>:<submodule>` fails to Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 13 2017, 3:10 PM · Git, Diffusion
epriestley lowered the priority of T13030: Accessing a submodule path directly in Diffusion has less than optimal UX from Normal to Wishlist.

D18831 should upgrade this from "horrible fatal" to "reasonable-but-not-ideal normal page". This could still be improved (providing the user more information and taking them into the submodule redirect workflow) but it's normally difficult to end up here without trying.

Dec 13 2017, 3:09 PM · Git, Diffusion
epriestley added a revision to T13030: Accessing a submodule path directly in Diffusion has less than optimal UX: Unknown Object (Differential Revision).
Dec 13 2017, 3:08 PM · Git, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

We have an outstanding support issue (PHI204) about timeouts with large files.

Dec 13 2017, 2:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 2:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

No.

Dec 13 2017, 2:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T7789: Support Git Large File Storage.

Per above, pushes to staging areas did not push LFS in the past. We should figure out what the state of the world is now and try to resolve it in the upstream, and document anything we can't work around or resolve.

Dec 13 2017, 2:14 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

@Grimeh, above, reports that this doesn't work over HTTP. I believe it does, but we should verify this.

Dec 13 2017, 2:08 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 2:04 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 1:59 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 1:46 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 1:43 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley triaged T13029: Provide some way for administrators to remove/reset a user's profile image as Wishlist priority.

As @avivey suggests, the remaining cache can be cleared with:

Dec 13 2017, 1:30 PM · Abuse, People
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

Anecdotally, Disqus uses Akismet and the hit rate isn't great (I've observed both a high false positive rate, and a high false negative rate).

Dec 13 2017, 1:26 PM · Abuse
epriestley archived Bug Report (Needs Information).
Dec 13 2017, 1:14 PM
epriestley archived Bug Report.
Dec 13 2017, 1:14 PM
epriestley archived Feature Request (Needs Information).
Dec 13 2017, 1:14 PM
epriestley archived Feature Request.
Dec 13 2017, 1:14 PM
epriestley edited projects for T13029: Provide some way for administrators to remove/reset a user's profile image, added: Abuse; removed Feature Request, Policy.
Dec 13 2017, 1:13 PM · Abuse, People
epriestley added a subtask for T10215: Provide tools to combat and recover from abuse: T13029: Provide some way for administrators to remove/reset a user's profile image.
Dec 13 2017, 1:13 PM · Abuse
epriestley added a parent task for T13029: Provide some way for administrators to remove/reset a user's profile image: T10215: Provide tools to combat and recover from abuse.
Dec 13 2017, 1:13 PM · Abuse, People
epriestley added projects to T13030: Accessing a submodule path directly in Diffusion has less than optimal UX: Diffusion, Git.
Dec 13 2017, 1:13 PM · Git, Diffusion

Dec 12 2017

epriestley merged T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception into T13030: Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 12 2017, 8:54 PM · Git, Diffusion
epriestley merged task T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception into T13030: Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 12 2017, 8:54 PM · Restricted Project, Diffusion, Bug Report
epriestley triaged T13030: Accessing a submodule path directly in Diffusion has less than optimal UX as Normal priority.
Dec 12 2017, 8:54 PM · Git, Diffusion

Dec 8 2017

epriestley added a member for Blessed Committers: timhirsh.
Dec 8 2017, 4:45 PM

Dec 5 2017

epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit, a subtask of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, as Resolved.
Dec 5 2017, 8:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Resolved by committing Restricted Diffusion Commit.
Dec 5 2017, 8:14 PM · Herald, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Dec 5 2017, 3:57 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit: Unknown Object (Differential Revision).
Dec 5 2017, 3:57 PM · Herald, Differential

Dec 1 2017

epriestley edited the content of Changelog.
Dec 1 2017, 9:29 PM
epriestley created 2017 Week 48 (Early December).
Dec 1 2017, 9:28 PM
epriestley triaged T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Normal priority.
Dec 1 2017, 7:32 PM · Herald, Differential

Nov 30 2017

epriestley closed T10233: arc error message unclear for accepted revision in "plan change" state as Resolved by committing Restricted Diffusion Commit.
Nov 30 2017, 9:51 PM · Restricted Project, Bug Report
epriestley added a revision to T10405: Phabricator should generally work properly even if "gd" is not installed: Unknown Object (Differential Revision).
Nov 30 2017, 9:47 PM · Setup, Restricted Project
epriestley renamed T10405: Phabricator should generally work properly even if "gd" is not installed from New Project flow assumes gd is installed to Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:46 PM · Setup, Restricted Project