Page MenuHomePhabricator
Feed Advanced Search

Mar 16 2017

epriestley closed T9789: Make it easier to write custom transaction types as Resolved.

The system described in this task became "ModularTransactions", which feel like they're in a good place.

Mar 16 2017, 3:11 PM · Modernization, Transactions
20after4 awarded T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier a Mountain of Wealth token.
Mar 16 2017, 2:54 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley closed T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier as Resolved.

That sounds reasonable to me. We remain open to more feedback here if it does turn up, but I think we don't have a clear set of next steps otherwise. Thanks for following up!

Mar 16 2017, 2:09 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T12406: Importing commits which name themselves as the auditor can cause stuck tasks.

(D17404 is an earlier fix for a similar issue, but for self-auditors added via Herald.)

Mar 16 2017, 5:19 AM · Bug Report
epriestley added a comment to T12405: Feed story failed to render.

To move forward, we need complete reproduction instructions which we can follow to reproduce this issue in a clean environment. See Contributing Bug Reports and Providing Reproduction Steps.

Mar 16 2017, 3:10 AM · Feed, Bug Report
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
Mar 16 2017, 1:55 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a revision to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: Unknown Object (Differential Revision).
Mar 16 2017, 1:10 AM · Mail, Bug Report
epriestley added a parent task for T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045]: T12404: Implement a first-party SMTP client.
Mar 16 2017, 1:06 AM · Mail, Security
epriestley added a parent task for T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: T12404: Implement a first-party SMTP client.
Mar 16 2017, 1:06 AM · Mail, Bug Report
epriestley added subtasks for T12404: Implement a first-party SMTP client: T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045], T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.
Mar 16 2017, 1:06 AM · Infrastructure, Mail
epriestley created T12404: Implement a first-party SMTP client.
Mar 16 2017, 1:06 AM · Infrastructure, Mail
epriestley closed T12400: Provide self-service methods for finding users with no MFA configured, a subtask of T7639: Figure out MFA in the cluster, as Resolved.
Mar 16 2017, 12:49 AM · Phacility
epriestley closed T12400: Provide self-service methods for finding users with no MFA configured as Resolved by committing Restricted Diffusion Commit.
Mar 16 2017, 12:49 AM · Auth, Phacility

Mar 15 2017

epriestley added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

@Taskle, if you're a Phacility SAAS customer can you ping me at support@phacility.com with your instance name? I can't immediately find it. We're working to formalize the SAAS/prioritization relationship a little better, but we can push more weight behind requests if they're coming from paying customers vs free self-installs.

Mar 15 2017, 11:01 PM · Customer Impact, Restricted Project, Mail
epriestley added a subtask for T1562: Build "Facts", an ETL pipeline and charting application: T12402: Report on team velocity.
Mar 15 2017, 10:30 PM · Restricted Project, Wikimedia, Facts
epriestley added a parent task for T12402: Report on team velocity: T1562: Build "Facts", an ETL pipeline and charting application.
Mar 15 2017, 10:30 PM · Feature Request
epriestley added a project to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc: Phacility.

This also has SAAS customer interest.

Mar 15 2017, 10:27 PM · Customer Impact, Restricted Project, Mail
epriestley added a comment to T9006: Allow users to pick which Badges show on Timeline.

This got a mention in D17499, but when rendering a timeline we currently need two awards for each user who is going to get a full-sized profile image rendered.

Mar 15 2017, 7:44 PM · Badges, Restricted Project
epriestley added a comment to T5267: Localize Phabricator.

My belief is that we've satisfied all the requirements for Translatewiki to move forward on their side.

Mar 15 2017, 7:19 PM · Prioritized, Localization
epriestley added a revision to T12400: Provide self-service methods for finding users with no MFA configured: Unknown Object (Differential Revision).
Mar 15 2017, 7:04 PM · Auth, Phacility
epriestley created T12400: Provide self-service methods for finding users with no MFA configured.
Mar 15 2017, 4:21 PM · Auth, Phacility
epriestley added a project to T12177: Provide time-to-review statistics and reporting in Facts: Phacility.

We have SAAS customer interest in this too, now.

Mar 15 2017, 4:11 PM · Customer Impact, Differential, Restricted Project, Facts, Feature Request
epriestley added a comment to T12399: Documentation for Conduit Phrequent seems to be missing.

Go to Conduit on your install.

Mar 15 2017, 3:58 PM · Conduit, Phrequent, Feature Request
epriestley closed T12399: Documentation for Conduit Phrequent seems to be missing as Invalid.

Phrequent is not installed on this server. Conduit only shows methods from installed applications.

Mar 15 2017, 3:45 PM · Conduit, Phrequent, Feature Request
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

Probably bump the version unconditionally now

Mar 15 2017, 1:10 AM · Bug Report, Clusters, Diffusion

Mar 14 2017

epriestley added a revision to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails: Unknown Object (Differential Revision).
Mar 14 2017, 10:37 PM · Bug Report, Clusters, Diffusion
epriestley added a revision to T12296: Improve Phacility repository import performance: Unknown Object (Differential Revision).
Mar 14 2017, 10:25 PM · Customer Impact, Diffusion, Ops
epriestley added a revision to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails: Unknown Object (Differential Revision).
Mar 14 2017, 10:25 PM · Bug Report, Clusters, Diffusion
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

(For example, if the goal was to very aggressively optimize for minimizing network traffic, we could read the entire repository history to figure out which refs were ancestors of other refs first? Then we could drop those and only ask for descendant refs. But this seems crazy, since it's saying that ~20 bytes of network traffic is more costly than like one hundred million disk I/O operations?)

Mar 14 2017, 9:04 PM · Bug Report, Clusters, Diffusion
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

it has to compare "What do I have" vs. "What do you have"

Mar 14 2017, 8:57 PM · Bug Report, Clusters, Diffusion
epriestley added a comment to T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.

I think T12393 and this probably have a similar set of root causes.

Mar 14 2017, 7:48 PM · Bug Report, Clusters, Diffusion
epriestley added a comment to T12373: Support macros in Phame.

Remarkup is cached, so you'll need to run bin/cache purge --purge-remarkup (or make an edit, or create a new post) to purge the cache.

Mar 14 2017, 6:20 PM · Macros, Phame, Bug Report
epriestley changed the status of T12396: Define custom sort order for panel results. from Duplicate to Resolved.

To define 6 pages yourself: use a text panel, then link to 6 pages in the text. For example, you might use text like this:

Mar 14 2017, 1:49 PM · Dashboards

Mar 13 2017

epriestley added a comment to T12394: Locations Scenario Errata.

The "Policy" task says "implement PolicyInterface", but the interface is already implemented so that Query works. The description should be adjusted to be more accurate.

Mar 13 2017, 11:31 PM · Phacility
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Great, thanks for testing it! We'll upstream that and I'll file something to put a longer-term fix in place.

Mar 13 2017, 10:44 PM · Mail, Bug Report
remusvrm awarded T7924: Unprototype Calendar (v1) a Like token.
Mar 13 2017, 10:20 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10967: Move Differential reviewers back to a dedicated database storage table.

Old-school resigns, accepts, and rejects are still using edges directly (can we get rid of these completely?).

Mar 13 2017, 8:12 PM · Restricted Project, Infrastructure, Differential
epriestley created T12395: Calendar events aren't sufficiently exhaustive during destruction.
Mar 13 2017, 8:01 PM · Calendar
epriestley added a comment to T10967: Move Differential reviewers back to a dedicated database storage table.

These pathways are still dodging ModularTransactions and thus not getting double writes after D17495:

Mar 13 2017, 7:58 PM · Restricted Project, Infrastructure, Differential
epriestley created T12394: Locations Scenario Errata.
Mar 13 2017, 7:23 PM · Phacility
epriestley added a revision to T10967: Move Differential reviewers back to a dedicated database storage table: Unknown Object (Differential Revision).
Mar 13 2017, 7:15 PM · Restricted Project, Infrastructure, Differential
epriestley added a comment to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies.

Specifically, from the error, since X and Y are consistent in the error part and the fetch part, it appears that this process has lost a race to another process which is doing the same fetch.

Mar 13 2017, 6:58 PM · Diffusion
epriestley created T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies.
Mar 13 2017, 6:57 PM · Diffusion
epriestley created T12392: Instance reporting that synchronizeWorkingCopyBeforeRead() effectively fails.
Mar 13 2017, 6:54 PM · Bug Report, Clusters, Diffusion
epriestley closed T12328: "Watching Projects" doc section seems wrong as Resolved.

(Presuming this is resolved since it's been open for a while without feedback.)

Mar 13 2017, 5:44 PM · Restricted Project, Documentation, Bug Report
epriestley closed T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task as Invalid.

Feel free to file a new report if you are able to come up with clear, working reproduction steps that reproduce this issue on a clean install.

Mar 13 2017, 5:40 PM · Bug Report, EditEngine
epriestley added a comment to T12375: Integrate Conduit API for Policy Object Creation.

Some workarounds in the short term:

Mar 13 2017, 5:38 PM · Policy, Feature Request
epriestley added a comment to T12380: Errors with Mercurial trust while browsing rHGTEST on this install.

This is likely just some of the secure hosts having different configuration. Ideally, we'd get the rCORE deployment stuff aligned to deploy them with it.

Mar 13 2017, 5:11 PM · Mercurial, Bug Report
epriestley closed T12383: Accumulate Phabricator changelogs applicable from a current install as Wontfix.

We may eventually build this for T7413 but I don't think it's a good use of our time without a strong, narrow motivating use case like that.

Mar 13 2017, 5:01 PM · Feature Request, Installing & Upgrading
epriestley closed T12388: Newly created Git repository main page is not shown up as Invalid.

This doesn't appear to be moving toward becoming an actionable report.

Mar 13 2017, 4:13 PM · Bug Report (Needs Information)
epriestley added a comment to T12390: `differential.querydiffs` is timing out for a revision with 20 diffs.

Any ideas on how we can move forward with this?

Mar 13 2017, 4:12 PM · Conduit, Differential, Bug Report
epriestley renamed T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence from Remakrup textbox missing most buttons in Mobile mode to Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence.
Mar 13 2017, 4:08 PM · Design, Conpherence, Bug Report
epriestley edited projects for T12391: Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence, added: Conpherence, Design; removed Remarkup.

These CSS rules:

Mar 13 2017, 4:08 PM · Design, Conpherence, Bug Report

Mar 12 2017

epriestley closed T12387: Typo in code. as Resolved by committing Restricted Diffusion Commit.
Mar 12 2017, 9:23 PM · Bug Report
epriestley added a revision to T12387: Typo in code.: Unknown Object (Differential Revision).
Mar 12 2017, 8:46 PM · Bug Report
epriestley renamed T12389: Pushing a Git repository immediately after creating it can fail because "git init" has not run yet from Pushing a repository immediately after creating it can fail to Pushing a Git repository immediately after creating it can fail because "git init" has not run yet.
Mar 12 2017, 7:22 PM · Diffusion
epriestley created T12389: Pushing a Git repository immediately after creating it can fail because "git init" has not run yet.
Mar 12 2017, 7:22 PM · Diffusion
epriestley closed T12238: Write a script to populate a Phacility instance with the "Locations" scenario as Resolved.

rLOCATIONS now has two branches:

Mar 12 2017, 7:05 PM · Phacility
epriestley claimed T12238: Write a script to populate a Phacility instance with the "Locations" scenario.
Mar 12 2017, 4:22 PM · Phacility
rafaelrabeloit awarded T3670: Add subprojects a Like token.
Mar 12 2017, 12:06 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
eliaspro awarded T731: Allow revisions to have alternate acceptance conditions a Love token.
Mar 12 2017, 9:40 AM · Restricted Project, Restricted Project, Differential

Mar 11 2017

epriestley edited projects for T12386: Delete this task, added: Bug Report (Needs Information); removed Setup.
Mar 11 2017, 11:19 PM · Bug Report (Needs Information)
epriestley added a comment to T12386: Delete this task.

Bug reports need complete reproduction instructions and complete version information. See Contributing Bug Reports, Providing Reproduction Steps, and Providing Version Information.

Mar 11 2017, 11:18 PM · Bug Report (Needs Information)
epriestley edited the content of Changelog.
Mar 11 2017, 7:28 PM
epriestley created 2017 Week 10 (Mid March).
Mar 11 2017, 7:27 PM
epriestley added a comment to T12373: Support macros in Phame.

Happy to accept a patch for this (deleting that one line of code) if someone wants to claim that they tested the scenario above and it worked correctly.

Mar 11 2017, 6:57 PM · Macros, Phame, Bug Report
epriestley renamed T12373: Support macros in Phame from Macro not displaying in Phame post to Support macros in Phame.
Mar 11 2017, 6:56 PM · Macros, Phame, Bug Report
epriestley merged T12385: Incorrect Chinese unicode character saving in translation config. into T8973: Encoding JSON for presentation could use more human-friendly escaping rules.
Mar 11 2017, 5:38 PM · Customer Impact
epriestley merged task T12385: Incorrect Chinese unicode character saving in translation config. into T8973: Encoding JSON for presentation could use more human-friendly escaping rules.
Mar 11 2017, 5:38 PM · libphutil, Localization, Bug Report
epriestley added a comment to T12385: Incorrect Chinese unicode character saving in translation config..

This behavior is not "incorrect", it just isn't the most human-readable format we could use. I'm going to merge this into T8973, which discusses this and other potential improvements to human-readability for JSON encoded for presentation.

Mar 11 2017, 5:38 PM · libphutil, Localization, Bug Report

Mar 10 2017

epriestley added a comment to T12383: Accumulate Phabricator changelogs applicable from a current install.

T7413 is security/usage data.

Mar 10 2017, 10:52 PM · Feature Request, Installing & Upgrading
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

After D17489 you should be able to do this:

Mar 10 2017, 10:50 PM · Mail, Bug Report
epriestley added a revision to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false: Unknown Object (Differential Revision).
Mar 10 2017, 10:48 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Hrrm -- I can adjust bin/mail send-test to accept raw email addresses, and then you can use it to send a message to test+00001@gmail.com, test+00002@gmail.com and similar. Shouldn't be too involved.

Mar 10 2017, 10:43 PM · Mail, Bug Report
epriestley created T12379: Instance reporting difficulty pushing the Linux kernel to a Phacility instance.
Mar 10 2017, 1:06 AM · Customer Impact, Diffusion, Ops

Mar 9 2017

Sohojoe awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 9 2017, 8:28 PM · Workboards (v3), Restricted Project
epriestley added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Mar 9 2017, 7:43 PM · Badges (v0)
epriestley merged T12376: Export workboard columns for reporting into T5024: Provide a dedicated page for viewing a single workboard column.
Mar 9 2017, 7:39 PM · Restricted Project, Workboards
epriestley merged task T12376: Export workboard columns for reporting into T5024: Provide a dedicated page for viewing a single workboard column.
Mar 9 2017, 7:39 PM · Feature Request
epriestley added a comment to T12376: Export workboard columns for reporting.

Here's a (not so great) workaround:

Mar 9 2017, 7:39 PM · Feature Request
epriestley added a comment to T12270: Unbeta Badges.

I'll send you some kind of something-or-other for dropping "Quality" from Conduit for the moment.

Mar 9 2017, 7:29 PM · Badges (v0)
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Internally, PHPMailer sends headers through two adjustment phases:

Mar 9 2017, 6:30 PM · Mail, Bug Report
epriestley added a comment to T12359: Registration does not accept valid email addresses.

I know someone who has a normalname@domain.horse address and frequently finds services which won't accept it (since they're hard-coded for 3-letter TLDs) so I'd guess users with ={^_^}=@nekoneko.com addresses run into more frequent problems. We should handle .horse, .technology, etc., properly.

Mar 9 2017, 6:18 PM · Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Can you test if this fixes the issue in your environment?

Mar 9 2017, 6:15 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

I think this is the controlling specification -- 2008 was a simpler time when no sequence of non-whitespace characters could ever be longer than 78 bytes, and a thousand bytes of memory was an untold wealth of riches:

Mar 9 2017, 6:09 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

I think the actual issue is that we're not wrapping the header. When I generate a synthetic message locally with a "To:" header with a length of ~50,000 bytes, the raw output is an unbroken line ~50,00 bytes long. I suspect this is RFC-violating and that whatever the mail gets handed to next gets upset by it.

Mar 9 2017, 5:57 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

Perfect, thanks!

Mar 9 2017, 5:28 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

What is metamta.mail-adapter set to?

Mar 9 2017, 5:26 PM · Mail, Bug Report
epriestley added a comment to T12372: Long list of reviewers breaks to: field when metamta.one-mail-per-recipient set to false.

See also T12046 for why all open source is sketchy voodoo and the eventual pathway forward here is likely replacing it with first-party code.

Mar 9 2017, 5:25 PM · Mail, Bug Report
epriestley updated subscribers of T12374: Saved Workboard Queries.

Two workarounds you could use here are:

Mar 9 2017, 5:15 PM · Workboards, Feature Request
epriestley added a comment to T12375: Integrate Conduit API for Policy Object Creation.

(Are you associated with WMF, or just noting that they have an extension for this?)

Mar 9 2017, 4:56 PM · Policy, Feature Request
epriestley added a comment to T12376: Export workboard columns for reporting.

Or maybe a better question is: @mrybczyn, are you asking on behalf of KDE, or a different project?

Mar 9 2017, 4:55 PM · Feature Request
epriestley updated subscribers of T12376: Export workboard columns for reporting.

@bcooksley, is this another one of yours?

Mar 9 2017, 4:53 PM · Feature Request
epriestley awarded T12378: "This task has been locked" on all logged out tasks a Pterodactyl token.
Mar 9 2017, 4:52 PM · Maniphest, EditEngine
epriestley added a comment to T12378: "This task has been locked" on all logged out tasks.

Thanks for catching this, and for the clear reproduction steps.

Mar 9 2017, 4:52 PM · Maniphest, EditEngine
epriestley closed T12378: "This task has been locked" on all logged out tasks as Resolved by committing Restricted Diffusion Commit.
Mar 9 2017, 4:51 PM · Maniphest, EditEngine
epriestley added a revision to T12378: "This task has been locked" on all logged out tasks: Unknown Object (Differential Revision).
Mar 9 2017, 4:46 PM · Maniphest, EditEngine
epriestley added a comment to T12369: Users sometimes prompted to "Edit Locked Task" when attempting to create a new task.

I have no idea either. We need reproduction steps. Reinstalling will not resolve this.

Mar 9 2017, 4:44 PM · Bug Report, EditEngine
epriestley added a comment to T12373: Support macros in Phame.

That is, the problem would be:

Mar 9 2017, 3:37 PM · Macros, Phame, Bug Report
epriestley added a comment to T12373: Support macros in Phame.

I guess we actually have to test this use case:

Mar 9 2017, 3:36 PM · Macros, Phame, Bug Report