Page MenuHomePhabricator

Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence
Closed, ResolvedPublic

Description

Most important button missing is probably the preview button:

pasted_file (106×377 px, 3 KB)

Current version of secure..

(Chrome 56 on Windows and Android, and the current Edge browser on Windows).

Event Timeline

avivey renamed this task from Markdown preview not loading on mobile and tablet view to Remakrup textbox missing most buttons in Mobile mode .Mar 13 2017, 2:57 PM
avivey updated the task description. (Show Details)
epriestley added a subscriber: epriestley.

These CSS rules:

.device .remarkup-assist-button,
.device .remarkup-assist-separator {
   display: none;
 }

...in webroot/rsrc/css/application/conpherence/message-pane.css are too broad. The Conpherence CSS is being pulled onto other pages (probably by the persistent chat popup) and these rules are applying everywhere. Here's the inspector in Safari:

Screen Shot 2017-03-13 at 9.05.32 AM.png (1×994 px, 244 KB)

I don't immediately see any recent change responsible for this, although I haven't tried to bisect; I suspect the culprit is something mundane and Celerity-related, not an actual CSS change. But we should fix the rules, since any CSS should be able to be included safely on any page without changing the display style.

epriestley renamed this task from Remakrup textbox missing most buttons in Mobile mode to Some remarkup textarea control actions, including Preview, are incorrectly hidden on mobile by an overbroad CSS rule from Conpherence.Mar 13 2017, 4:08 PM
epriestley triaged this task as Normal priority.