Page MenuHomePhabricator
Feed Advanced Search

Jun 4 2015

chad created initiative I3 Development of making callsigns optional / flexible.
Jun 4 2015, 9:33 PM · Diffusion
20after4 added a comment to T4245: Make repository URIs slightly prettier.

I would personally pony up a couple of hundred at least, just for all the times that @epriestley has helped me out with responses that were detailed and incredibly helpful, without any visible signs of annoyance. :)

Jun 4 2015, 8:55 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
cspeckmim added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

Our projects make use of mercurial tags, specifically for marking versions and for managing some repository dependencies (preventing commits being pushed upstream to repo A unless they already exist upstream in repo B).

Jun 4 2015, 6:32 PM · Mercurial, Diffusion
richardvanvelzen added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

At least Python and Mercurial itself use tags extensively, and there are many more projects that do.

Jun 4 2015, 5:43 PM · Mercurial, Diffusion
jarrod created T8423: Importing an external repository (branches not identified).
Jun 4 2015, 5:38 PM · Diffusion
epriestley added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

They're a function of an individual commit instead of being a function of the repository as a whole, so we'd have to do a lot more work to support them (it's not meaningful to, say, "list all tags in the repository", as it is with Git), and I suspect they're not used much in the wild because of how they work. I'm not sure if this is true or not.

Jun 4 2015, 5:29 PM · Mercurial, Diffusion
• harpyham added a comment to T7471: Unable to connect to SVN repo with invalid SSL cert.

Login as webuser , run svn checkout command and accept the certificate permanently .

Jun 4 2015, 6:05 AM · Subversion, Diffusion
cspeckmim added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

Repri to "basically never" now that I have learned more about Mercurial tags.

Jun 4 2015, 4:21 AM · Mercurial, Diffusion
epriestley closed T6367: Send email with recipient's language and access levels, not sender's, a subtask of T7047: Add user preference for diffs in emails, as Resolved.
Jun 4 2015, 2:31 AM · Restricted Project, Differential, Mail, Diffusion
spage created T8407: Control diffusion's syntax highlighting.
Jun 4 2015, 12:20 AM · Diffusion

Jun 3 2015

jhurwitz added a project to T4994: Support reporting code coverage information into Diffusion: Restricted Project.
Jun 3 2015, 9:29 PM · Restricted Project, Restricted Project, Diffusion
chad added a project to T8400: Details of files in diffusion browse view take long to load: Mercurial.
Jun 3 2015, 8:23 PM · Mercurial, Diffusion
richardvanvelzen created T8400: Details of files in diffusion browse view take long to load.
Jun 3 2015, 7:35 PM · Mercurial, Diffusion
kdz13 added a comment to T5839: Repository ref updates may fail after a branch is destroyed.

The newly added method removeMissingCommits was causing a lot of unneeded thrash on our mercurial repository. We have 140 branches, and phabricator was launching a process to check each revision every 15 seconds, and rather severely thrashing our disk. It seems to me that there's no need to call this method for mercurial branches, since the information contained in $branches was already obtained by running 'hg log' and should be up to date.

Jun 3 2015, 2:53 PM · Diffusion

Jun 2 2015

eadler added a project to T1731: Allow users to set their VCS names: FreeBSD.
Jun 2 2015, 10:39 PM · FreeBSD, Diffusion
0xseantasker added a comment to T7000: 404 when accessing repo via http.

I ran into a 404 repository not found after changing Diffusion from public to All users. The repository in question is set to read and editable by users of a specific project. I was able to re-access the repository by setting Diffusion back to public (the repository still has restricted access).

Jun 2 2015, 1:29 AM · Diffusion

Jun 1 2015

epriestley added a comment to T8370: Index "TODO" comments and other references present in source code.

Tracking moves and fixes of these things seems like the hard part: it would maybe be nicer to see "all places in the codebase a task is currently mentioned", not necessarily "all places a task has ever been mentioned". But maybe this isn't actually that important.

Jun 1 2015, 3:34 PM · Transactions, Diffusion
epriestley added a comment to T8370: Index "TODO" comments and other references present in source code.

Another (not necessarily good) attack on this would be to extract these with a linter (similar to the TODO linter), and then maybe, uh, let lint messages have an object PHID on them? I guess? This feels real sketchy but maybe there are some other reasonable things we could do which could justify it.

Jun 1 2015, 3:29 PM · Transactions, Diffusion
epriestley closed T8375: The "phabricator:20150503.repositorysymbols.2.php" migration triggers a notice as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 1:56 PM · Diffusion
epriestley added a revision to T8375: The "phabricator:20150503.repositorysymbols.2.php" migration triggers a notice: Restricted Differential Revision.
Jun 1 2015, 1:44 PM · Diffusion
aik099 created T8375: The "phabricator:20150503.repositorysymbols.2.php" migration triggers a notice.
Jun 1 2015, 1:41 PM · Diffusion
• agen added a comment to T7471: Unable to connect to SVN repo with invalid SSL cert.

I installed phabricator using the shell script ( http://www.phabricator.com/rsrc/install/install_rhel-derivs.sh ) and meet the same error. When I run the svn command like

Jun 1 2015, 7:32 AM · Subversion, Diffusion
• Karthik123 added a comment to T8365: Initialization Error .

Yes. I have assigned the credential into repo link. Please check the image.

Jun 1 2015, 5:51 AM · Diffusion
joshuaspence closed T7603: Remove the deprecated "Repositories" application as Resolved by committing Restricted Diffusion Commit.
Jun 1 2015, 5:40 AM · Repositories, Diffusion
Mnkras added a comment to T8365: Initialization Error .

And the credential was assigned to the repo?

Jun 1 2015, 5:39 AM · Diffusion
• Karthik123 added a comment to T8365: Initialization Error .

Hi Mnkras,

Jun 1 2015, 5:37 AM · Diffusion
• Karthik123 added a comment to T8365: Initialization Error .

Hi mnkras,

Jun 1 2015, 5:09 AM · Diffusion
Mnkras added a comment to T8365: Initialization Error .

When you setup the import there is a screen that has you add credentials. That would be the ssh key or the password, if you go to the repo in Diffusion you can add the credentials there as well.

Jun 1 2015, 4:56 AM · Diffusion
• Karthik123 added a comment to T8365: Initialization Error .

Yes. That repository server having authentication like as password and ssh public key, How to add this key or password into the Phabricator. Can you explain the procedure.

Jun 1 2015, 4:49 AM · Diffusion
Mnkras added a comment to T8365: Initialization Error .

Is the repo you are cloning public? or does it require authentication, if it requires authentication, you need to make sure that you have uploaded/generated/added the credentials to phabricator so that it can connect.

Jun 1 2015, 4:34 AM · Diffusion
• Karthik123 added a comment to T8365: Initialization Error .

Hi epriestley,

Jun 1 2015, 4:32 AM · Diffusion
joshuaspence created T8370: Index "TODO" comments and other references present in source code.
Jun 1 2015, 2:15 AM · Transactions, Diffusion

May 31 2015

chad renamed T8365: Initialization Error from Phabricator - Initialization Error to Initialization Error .
May 31 2015, 7:41 PM · Diffusion
chad closed T8354: Inline table cell text doesn't wrap in diff's timeline view as Resolved by committing Restricted Diffusion Commit.
May 31 2015, 3:37 PM · Diffusion, Remarkup
joshuaspence updated subscribers of T8238: Formally support side-band change handoff in external repositories.

@hach-que, this is what you were asking about in IRC.

May 31 2015, 3:42 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

May 30 2015

chad added a revision to T8354: Inline table cell text doesn't wrap in diff's timeline view: Restricted Differential Revision.
May 30 2015, 7:56 PM · Diffusion, Remarkup
eadler added a project to T2495: Improve whitespace expansion of tab literals: FreeBSD.
May 30 2015, 6:11 PM · Restricted Project, FreeBSD, Differential, Diffusion

May 29 2015

chad placed T8354: Inline table cell text doesn't wrap in diff's timeline view up for grabs.
May 29 2015, 3:56 PM · Diffusion, Remarkup
marceldegraaf closed T8353: Unhandled Exception when viewing a Diffusion commit as Resolved.

Yes, that solves it. Thanks!

May 29 2015, 2:23 PM · Diffusion
epriestley added a comment to T8353: Unhandled Exception when viewing a Diffusion commit.

Restart Apache (if you use Apache) or php-fpm (if you use nginx + php-fpm), and let me know if you still see the issue?

May 29 2015, 2:20 PM · Diffusion
marceldegraaf created T8353: Unhandled Exception when viewing a Diffusion commit.
May 29 2015, 12:27 PM · Diffusion
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

This happened again today (for my own future reference, see D20770 on our install).

May 29 2015, 12:16 PM · Differential, Diffusion

May 28 2015

epriestley closed T8344: `arc land` Exception; null passed to `idx()`, a subtask of T7604: Remove "Arcanist Projects", as Resolved.
May 28 2015, 11:11 PM · Diffusion
btrahan closed T8121: JS errors when browsing commits in Diffusion as Wontfix.

Going with the T8202 resolution plan.

May 28 2015, 10:40 PM · Diffusion, Quicksand
epriestley added a subtask for T7604: Remove "Arcanist Projects": T8344: `arc land` Exception; null passed to `idx()`.
May 28 2015, 7:52 PM · Diffusion
cspeckmim added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

I turned off auto-close on the main repository, and revisions pushed to 'A' no longer associate with the main repository. However none of the revisions for the main repository auto-close.

May 28 2015, 3:07 PM · Diffusion
joshuaspence claimed T5406: Offer read-only copy of a externally hosted repository via Diffusion clone url (https/ssh).
May 28 2015, 1:05 PM · Diffusion (v3)
joshuaspence claimed T5581: Diffusion does not render Phabricator-hosted readonly mirror URIs.
May 28 2015, 12:54 PM · Diffusion
joshuaspence claimed T5687: trait X in "use Xl" in PHP doesn't link to the definition of the trait in diffusion.
May 28 2015, 12:41 PM · Diffusion
cburroughs added a comment to T8238: Formally support side-band change handoff in external repositories.

"You need to cron some stuff syncing master or it will sometimes be kind of slow" is acceptable from my point of view. Things I can solve with code is preferable to 'please debug my snowflake workstation where I did strange where I did strange things with arc and git'.

May 28 2015, 1:19 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster
avivey added a comment to T8238: Formally support side-band change handoff in external repositories.

(Not sure if my comment in T8090 should actually be here).

May 28 2015, 12:13 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

May 27 2015

epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

We could really push two refs: phabricator/diff/12345 and phabricator/base/12345. To phabricator/base/12345, we push the first parent of the last thing that pops out of git log HEAD --not --remotes -- (that is, the first ancestor of the diff which is also present in any remote)?

May 27 2015, 10:59 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

From D13041, it looks like the first time git does a push to a totally separate staging area it pushes a lot of extra data, probably because none of the heads in the remote are ancestors of the head being pushed, so it can't detect that their ancestries are 99.9% identical.

May 27 2015, 10:51 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
• sshannin added a comment to T6997: Show prefix or project for commits in feeds.

As a note, the title tagging you did in {D13040}, is basically how I've been having users do this in my install. We've been putting the logical project/branch like [branch_name] in a lot of titles to get that info into the major panels so that diffs don't require a clickthrough for context.

May 27 2015, 9:05 PM · Diffusion, Audit, Differential, Subversion
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I configured this for our repos; only hiccup so far is that there's no way to disable "Commit Hook" Herald rules right now so the first pushes (which pushed the entire repo history) took a little while. Normal "arc diff" staging pushes only take about a second.

May 27 2015, 7:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
avivey added a comment to T8238: Formally support side-band change handoff in external repositories.

We were discussing GH magic branches lately, and it turns out you can do this:

git fetch origin refs/pull/33/head:pr33
May 27 2015, 5:54 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

May 26 2015

joshuaspence closed T6897: Diffusion commit email notification does not specify branch as Resolved.
May 26 2015, 10:00 PM · Diffusion
joshuaspence added a revision to T6897: Diffusion commit email notification does not specify branch: Restricted Differential Revision.
May 26 2015, 9:59 PM · Diffusion
20after4 added a comment to T8318: Diffusion closes tasks when commit message has a line ending in "fixes" followed by a line beginning with a Txxx task reference.

@epriestley: Ok, thanks for clarification. I will refer people here if it comes up again :)

May 26 2015, 9:26 PM · Diffusion
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Yep, that's right. My plan for the upstream to move forward in the short term (until we build virtual refs) is:

May 26 2015, 6:46 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
cburroughs added a comment to T8238: Formally support side-band change handoff in external repositories.

If I'm reading this right, with the tag approach & staging != main-repo, unless someone has specified things manually in .git/config they (well arc) can do git push to arbitrary places but since the staging repo isn't a configured remote none of {fetch,pull,clone} will know anything about it. I think that is a satisfactory level of cleanliness for both the main & local repos.

May 26 2015, 6:27 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T8318: Diffusion closes tasks when commit message has a line ending in "fixes" followed by a line beginning with a Txxx task reference as Wontfix.

In the general case, this is working as intended. Specifically, it's intentional that we accept linebreaks in the middle of a "Fixes X, Y" statement, because linebreaks aren't always added explicitly by users.

May 26 2015, 5:53 PM · Diffusion
epriestley added a revision to T8238: Formally support side-band change handoff in external repositories: Restricted Differential Revision.
May 26 2015, 5:42 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a revision to T8238: Formally support side-band change handoff in external repositories: Restricted Differential Revision.
May 26 2015, 5:39 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

It looks like we can push to some secret place:

May 26 2015, 5:31 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
20after4 created T8318: Diffusion closes tasks when commit message has a line ending in "fixes" followed by a line beginning with a Txxx task reference.
May 26 2015, 5:25 PM · Diffusion
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I have this working, but pushing to tags in the same repo is pretty leaky. The docs say this of git fetch:

May 26 2015, 5:19 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
cspeckmim added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

Yes that is a more succinct description. Using that same description, repository 'B' would be where primary development happens, and hence more Differential revisions are created. Ideally revisions on repository 'B' would still auto-close. I was hoping for an option that had similar behavior but was a little inverse -> instead of configuring auto-close for repositories 'B', 'C', etc. there would be some option on 'A' to ignore commits on 'B', 'C', etc.

May 26 2015, 1:43 PM · Diffusion

May 25 2015

joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 10:13 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 9:22 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 9:16 PM · Diffusion
razik added a comment to T8303: Mercurial hooks.

Wow, thanks a lot for that insightful feedback.
I understand that some of these actions we are taking are definitely not conventional and should not be integrated as is.

May 25 2015, 8:51 PM · Mercurial, Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 12:49 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 12:48 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 12:29 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 12:29 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 12:29 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 12:18 PM · Diffusion
epriestley closed T8225: Permission denied error when pushing to hosted Git repository as Invalid.

Presuming this is a Bitnami issue.

May 25 2015, 11:28 AM · Diffusion
mbrgm added a comment to T4245: Make repository URIs slightly prettier.

From my side, I'm playing around with Phabricator for my personal/private repo hosting (not even having settled on it). As with most FOSS projects, this means I'd be contributing fixes or enhancements I encounter (and am able to work on in terms of complexity), but don't have monetary budget to spend. However, @techdragon's suggestion sounds fair for everyone using this in a professional/work environment.

May 25 2015, 11:16 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence added a revision to T7603: Remove the deprecated "Repositories" application: Restricted Differential Revision.
May 25 2015, 10:58 AM · Repositories, Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 25 2015, 8:59 AM · Diffusion
techdragon added a comment to T4245: Make repository URIs slightly prettier.

If the estimate is 20 hours, then perhaps those of us still looking for this more earnestly can pass around the collection plate and collectively pay for it. 18 people are subscribed to this issue, if even 3 of us are willing to pony up the dough, then this goes from ~$3000 to ~$1000, and suddenly I can say "look finance guy, we spend $100 a month on private github repos, this $1000 eliminates that year over year cost".

May 25 2015, 8:27 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to T8303: Mercurial hooks.

Ah, thanks! That's helpful.

May 25 2015, 1:01 AM · Mercurial, Diffusion

May 24 2015

razik added a comment to T8303: Mercurial hooks.

Most of the rules we are implementing are directly related to Differential.
We are for example, reporting or blocking pushes to the repositories based on:

  • the number of open revisions (blocking others or action required) the author has.
  • the last update and/or creation dates of any open item for that author.
  • the existence of a revision for all the commits being pushed (which I believe Herald already supports).
  • the status of the revisions associated to the commits.

Any of these items can be activated of de-activated based on the author.

May 24 2015, 8:09 PM · Mercurial, Diffusion
epriestley added a comment to T4245: Make repository URIs slightly prettier.

You can pay us to prioritize this; see Paid Prioritization for details. I've previously quoted this as about 20 hours of work, and I think that's still accurate.

May 24 2015, 3:38 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley placed T8303: Mercurial hooks up for grabs.

Can you provide some examples of what you want the rules to do? There are probably three general ways forward here:

May 24 2015, 3:19 PM · Mercurial, Diffusion
epriestley added a comment to T7604: Remove "Arcanist Projects".

You shouldn't, no. arc uses other information (mostly working copy path on disk, IIRC) in that case.

May 24 2015, 3:13 PM · Diffusion
• sshannin added a comment to T7604: Remove "Arcanist Projects".

For SVN, how will this differ from current workflow when we have two working diffs from same repo but different "projects"? Will we now need to specify --update and --revision for arc diff and arc commit where we wouldn't need to previously? That would be sad.

May 24 2015, 2:51 PM · Diffusion
epriestley updated the task description for T7604: Remove "Arcanist Projects".
May 24 2015, 2:23 PM · Diffusion
mbrgm added a comment to T4245: Make repository URIs slightly prettier.

Is there anything I can do to help you on this or is it already taking its course?

May 24 2015, 8:29 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
razik updated subscribers of T8303: Mercurial hooks.
May 24 2015, 3:20 AM · Mercurial, Diffusion
razik created T8303: Mercurial hooks.
May 24 2015, 3:19 AM · Mercurial, Diffusion
joshuaspence added a project to T8276: Diffusion shows no author information if it was associated with a deleted user: Diffusion.
May 24 2015, 1:00 AM · Restricted Project, Diffusion

May 23 2015

epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

I may be misunderstanding, but here's what I think is happening from your description:

May 23 2015, 4:24 PM · Diffusion
cspeckmim added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

I can try this, but wouldn't I want to disable auto-close on the current-version branch? The majority of work is being done on the current-version, but a significant amount of work is being done on prior-version in-tandem. Or are you referring to the prior-version having it's Auto-close turned off, or both? Unfortunately I won't be able test any of this till next week.

May 23 2015, 3:36 PM · Diffusion
epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

Right -- can you disable Autoclose on the version-branch repository to work around this? Disabling it should stop commits to it that repository from associating with revisions, so the repository will never "steal" the revision (basically, Differential will just ignore the commit, even though it will still show up in Diffusion).

May 23 2015, 12:20 PM · Diffusion
cspeckmim added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

Commits from all version repositories appear to associate correctly. When the change is first developed it is on the prior version repository and creation of the revision properly associates it (through arc diff). But when doing our land process, it looks like since the repository which receives the commit first is the current version branch instead of the prior version branch, the revision's repository field is automatically changed to the current version's repository and closed before the commit makes it up to the prior version branch.

May 23 2015, 12:22 AM · Diffusion
chad added a project to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository: Diffusion.
May 23 2015, 12:00 AM · Diffusion

May 22 2015

epriestley added a comment to T8170: Diffusion -> show raw file doesn't always render text.

The MIME type of these files is detected differently (text/plain vs text/x-php). We can probably force these to text/plain safely in all cases, but this has some security implications.

May 22 2015, 5:44 PM · Diffusion