Page MenuHomePhabricator

JS errors when browsing commits in Diffusion
Closed, WontfixPublic

Description

I have noticed this a few times, Ill click on a commit with the durable column open and the file contents for all the files is in the "Loading" state, when I inspect the console I see the following js errors:

core.pkg.js:188 Uncaught Error: JX.initBehavior(map): behavior(s) not registered: differential-toggle-files, differential-dropdown-menus, differential-populate, differential-comment-jump, differential-edit-inline-comments, differential-keyboard-navigation, differential-add-reviewers-and-ccs, differential-feedback-preview, aphront-drag-and-drop-textarea
core.pkg.js:214 Uncaught Error: JX.$('transaction-preview') call matched no nodes.

Related Objects

Event Timeline

Mnkras raised the priority of this task from to Needs Triage.
Mnkras updated the task description. (Show Details)
Mnkras added projects: Quicksand, Diffusion.
Mnkras added a subscriber: Mnkras.

There's one JS error I can get consistently from diffusion. To reproduce - locally or on this install - simply toggle on the durable column and visit any revision:

Resource interpreted as Image but transferred with MIME type text/html: "http://phalanx.dev/rPMFPa940e6a32d9ac1234795bef840a4847d02325e47".

JX.install.statics.scrollToPosition @ core.pkg.js:3989
JX.install.statics._draw @ core.pkg.js:13237
JX.install.statics._onresponse @ core.pkg.js:13186
JX.install.members._onload @ core.pkg.js:4626
(anonymous function) @ core.pkg.js:740
JX.install.statics.pass @ core.pkg.js:1608
JX.install.statics._dispatchProxy @ core.pkg.js:1573
JX.install.statics.invoke @ core.pkg.js:1249
proto.invoke @ core.pkg.js:721
JX.install.members._done @ core.pkg.js:2421
(anonymous function) @ core.pkg.js:2469
JX.install.statics._complete @ core.pkg.js:2054

This is from inside Quicksand's _draw method, where it calls JX.DOM.scrollTo(0,0) and the ultimate window.scrollTo(); call triggers this error.

I have not been able to trigger the initially reported issue.

While I can't seem to get it to reproduce, I think the first error from the initial report is from a failure to download differential.pkg.js:

core.pkg.js:188 Uncaught Error: JX.initBehavior(map): behavior(s) not registered: differential-toggle-files, differential-dropdown-menus, differential-populate, differential-comment-jump, differential-edit-inline-comments, differential-keyboard-navigation, differential-add-reviewers-and-ccs, differential-feedback-preview, aphront-drag-and-drop-textarea

(These files are all part of differential.pkg.js.)

Under the missing package theory, if I try a page like /p/btrahan/ with the durable column closed, differential.pkg.js does not download. However, once I toggled the durable column open that package downloads. There's no way for me to get to a commit with the durable column open and not get the package. At least as far as I know.

The second error seems to come from the ManiphestTaskDetailController somehow:

core.pkg.js:214 Uncaught Error: JX.$('transaction-preview') call matched no nodes.

The behavior 'maniphest-transaction-preview is the place causing this via grep-based deduction. Maybe this error requires going from task page (Txxx) to a commit? That said, trying various combinations of that navigation and toggling durable column doesn't get the error to reproduce for me.

iiam

@Mnkras - is this something you are still seeing? And / or figure out steps to reproduce? At somewhat of a dead end here I am afraid. :/

@btrahan Iv been busy lately so I haven't been playing with phab :(

I guess leave this open for a while and ill post back if I see it again in the next week

I just had it happen again, but for some reason the only JS errors I see are these: T8202

Going with the T8202 resolution plan.