I think this was tricky because we don't know what kind of credential to add (the user could put either an HTTP or SSH URI into the box) and the "add credential" dialog workflow needs (or needed?) a type. There's no reason we can't ask the user for a credential type.

No, we shouldn't. All of the changes that I have been making should be backwards compatible. Older arcanist clients will still submit arcanistProject as part of a diff, but it will be silently ignored server-side. We will need to wait a while before landing D12899 because this diff removes the arcanist.projectinfo Conduit endpoint (which is still in use until after D12962 and D12971).

will we need to break compatibility with users of existing arc versions?

Thanks @epriestley, just deployed this and can confirm that it's fixed.

Addition: the error disappears when we disable syntax highlighting in the file browser.

Previous discussions about this:

• T6414: Ability to put comments on current code - Some discussion about an almost-identical feature
• T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool - In the wishlist, more-or-less depending on tools that are very long away down the line. Answers the same general desire.
• T5722: Support meta-audit of arbitrary baskets of nonadjacent commits - more general ticket, which is also wishlist. Talks about a related use-case.

https://secure.phabricator.com/book/phabcontrib/article/bug_reports/

Restart Apache or PHP-FPM: Phabricator uses caches which don't get reset until you restart Apache or PHP-FPM. After updating, make sure you restart.

Basic questions:

We want to start a discussion about an existing piece of code, and how it could be improved. It would be very helpful to have the kind of inline comments and the usual discussion format available for that.

I dont believe such functionality exists at the moment. Can you describe the problem that you are trying to solve? see Contributing Feature Requests.

With both saved search and project tagging, this is reasonably solved.

Ah nice.

We have logic to determine the repository already (you can see it at the user-facing level in arc which, for example). You should just be able to remove projects completely, I believe.

@epriestley, do you have any idea how Differential would work without Arcanist Projects? My only thought is that we could do some sort of Conduit call to determine the repository. Probably this should happen server-side I guess.

I notice /opt/bitnami in your path. If you're using a Bitnami image, you should seek support from them. We do not offer support for third-party packages. See T4200 for some discussion.

I just had it happen again, but for some reason the only JS errors I see are these: T8202

It's not actually the same repository, they just have common history (3 of the repos are actually archived...)

Out of curiosity, why do you have the same repository imported multiple times?

Seems fair enough. I'll take a crack at this seeing as I implemented a lot of the revert stuff.

@btrahan Iv been busy lately so I haven't been playing with phab :(

@Mnkras - is this something you are still seeing? And / or figure out steps to reproduce? At somewhat of a dead end here I am afraid. :/

@epriestley, @chad : I solved it by myself so Im gonna close it.
It was basicaly that it used /usr/bin/git-receive instead of /usr/lib/git-core/git-receive.
Could you please include a hint in troubleshoting ( ssh | http ) :

If you get a message like sudo : a password is required, you can tail -f /var/log/auth.log (debian based..) or tail -f /var/log/secure (redhat, fedora, centos..) while trying to connect to get the path of the command used.

Something like a debug flag in the hook and debug log in ssh in ./bin/ssh-* could indeed help a lot of user.
With a little help I could make a Diff.

This might be nice to move to the new-ish help dropdown.

TYVM! I searched for a while for this and couldn't find it in the phab docs.

See T5132#69200 for the full list of options.

The second error seems to come from the ManiphestTaskDetailController somehow:

While I can't seem to get it to reproduce, I think the first error from the initial report is from a failure to download differential.pkg.js:

There's one JS error I can get consistently from diffusion. To reproduce - locally or on this install - simply toggle on the durable column and visit any revision:

Awesome, thanks!!

Yep, @avivey's got it.

T5462 is the general ticket, and feed.http-hooks is probably what you're after.

Because I wasted enough time on this, I went ahead and reproduced it so hopefully no one else does. Proof in P1779.

We can potentially detect this by looking for --enable-sigchild in phpinfo() or running an empirical test, but I'd want to wait until at least one other person runs into it.

I think this is due to the fact that I had --enable-sigchild in my compiled php, but I can't confirm. Finally configured with the following and I am gtg.

Reproducible with P1777. Any chance you guys compile php from source and I could get the output of php -i | grep configure?

Thanks for the report!

Things that still use Arcanist Projects: