Page MenuHomePhabricator
Create Task
Maniphest T8215

Revert detection in Diffusion crosses repositories
Closed, ResolvedPublic
Actions

Description

I just imported (yet another) copy of Phabricator's source code into my Phabricator, and I'm seeing commits like this:

pasted_file (561×1 px, 93 KB)

Now technically the commit being reverted does exist in all 4 of those repositories, but it doesn't make much sense for it to show it reverted like this (since each copy of the repository is standalone).

Revisions and Commits

rP Phabricator
D12875rP79e8d9fc2db1 Only revert commits in the same repository

Event Timeline

hach-que created this task.May 16 2015, 1:07 AM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Diffusion.
hach-que added subscribers: hach-que, epriestley.
joshuaspence claimed this task.May 16 2015, 5:22 AM
joshuaspence added a subscriber: joshuaspence.

Seems fair enough. I'll take a crack at this seeing as I implemented a lot of the revert stuff.

joshuaspence added a comment.May 16 2015, 5:23 AM

Out of curiosity, why do you have the same repository imported multiple times?

hach-que added a comment.May 16 2015, 5:25 AM

It's not actually the same repository, they just have common history (3 of the repos are actually archived...)

joshuaspence added a revision: D12875: Only revert commits in the same repository.May 16 2015, 7:13 AM
joshuaspence closed this task as Resolved by committing rP79e8d9fc2db1: Only revert commits in the same repository.May 17 2015, 11:40 PM
joshuaspence added a commit: rP79e8d9fc2db1: Only revert commits in the same repository.
Phabricator · Built by Phacility