Page MenuHomePhabricator

fabe (Fabian Stelzer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 29 2014, 3:12 PM (234 w, 21 h)
Availability
Available

Recent Activity

Jul 19 2017

fabe added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

We've been experiencing this problem from time to time as well.
In our case between two Phabricator installations.
The internal one observing a repository from a central dev server which always works fine.
Then the internal phabricator has a "mirror" URI configured for the repository to push any changes to an external phabricator installation.
This mirroring fails from time to time with the same error others have posted before (Unable to identify the reftype of 'refs/remotes/... in src/applications/diffusion/engine/DiffusionCommitHookEngine.php:404). Sometimes i could fix it by simply deleting a remote branch that was no longer needed anyway.
I've added a dirty fix now by inserting a "continue;" at line 404 so that the parser in findGitRefUpdates() simply skips unknown ref types and still imports the changes instead of failing completely with an exception.
Though i'm not sure what kind of side effects i might have introduced with this.

Jul 19 2017, 11:49 AM · Diffusion

Jan 11 2017

fabe added a comment to T12097: Object Herald Rules for Commits on Projects no longer working as expected.

I tested the patch on my install and it restores the old behaviour!

Jan 11 2017, 6:17 PM · Bug Report
fabe added a comment to T12097: Object Herald Rules for Commits on Projects no longer working as expected.

Unfortunately i'm not quite sure from exactly which version we've upgraded from. But you're probably right and it was a version before Aug 17.
I regularly read the release logs and in the ones i checked before upgrading (which was about 2-3 months worth of em) the latest Modernisation seemed the only thing touching something related to the problem.
D16413 probably didn't make it into any changelog or was just such a minor note that i didn't see it.

Jan 11 2017, 6:09 PM · Bug Report
fabe updated the task description for T12097: Object Herald Rules for Commits on Projects no longer working as expected.
Jan 11 2017, 5:47 PM · Bug Report
fabe created T12097: Object Herald Rules for Commits on Projects no longer working as expected.
Jan 11 2017, 5:45 PM · Bug Report
fabe added a comment to T11114: Move Differential to EditEngine.

I think this might have broken one of our Herald rules. The rule in question is an Object rule for Commits on a Project and will open an Audit whenever a commit is made to a repository that's tagged with this project.
At least it did ~2 month ago and after the upgrade it just won't fire. Just using the test console on a new commit in a repo tagged with the project simply says "Rule failed".
To make sure i already removed all the other conditions from it so it only states "always".

Jan 11 2017, 5:27 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential

Aug 2 2016

fabe added a comment to T5055: Distribution mechanism for arc extensions.

The whole "identify the packager problem" with composer is indeed a big one and i'm not suggesting you use composer in any way for the arcanist/phabricator packages! Generally i agree that i want to primarily trust the packager and not the developer. This is the way this is handled with os packages (rpm/deb) and companies are used to the workflow: Getting new packages from a somewhat trusted/signed source (e.g. redhat/canonical), testing them yourself, signing them with your own key as well and then distributing to the internal repositories and "end users" only trust your own internal key.

Aug 2 2016, 4:18 PM · Arcanist
fabe added a comment to T5055: Distribution mechanism for arc extensions.

It might be beneficial to generally support gpg signed commits / tags in phabricators git repos and then use the same mechanism for the arcanist packages.
Since github recently started pushing this feature a bit (https://github.com/blog/2144-gpg-signature-verification) quite a few library maintainers started signing their release tags.
And i just recently spoke to a lib maintainer about extending composer to verify all packages (on install or upgrade) against a list of authors trusted by the user (or an enterprise wide list).

Aug 2 2016, 1:46 PM · Arcanist

May 4 2016

fabe added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

I've run into this problem with my puppet repositories. A common puppet workflow is to use every branch as a puppet environment.
This way you can test a large change on a subset of production servers before applying it to the production branch itself.

May 4 2016, 3:37 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Jan 7 2016

fabe awarded D10600: Implement a git blame cache a Love token.
Jan 7 2016, 8:15 AM

Jan 6 2016

fabe added a comment to D10600: Implement a git blame cache.

Sure :)
I remember that the biggest performance gain was coming from using PHIDs when selecting all the commit info in the FileController instead of the commit identifiers.
Showing the blame info on the library_map file was a good benchmark.

Jan 6 2016, 12:28 PM

Dec 20 2015

fabe added a comment to T10010: Implement Subprojects.

Ok, i misunderstood the withMemberPHIDs reference. I thought you wanted to get all the members of a parent project including it's childs.

Dec 20 2015, 9:14 PM · Projects (v3)
fabe added a comment to T10010: Implement Subprojects.

Have you considered using a nested set for the project hierarchies and build them dynamically?
I've used it in the past for hierarchy stuff and it performs very well for things like "get the sum of value X from this Entity and all of it's children"

Dec 20 2015, 3:15 PM · Projects (v3)

Dec 18 2015

fabe added a comment to T10010: Implement Subprojects.

I think sth like the following would be quite common:

Sales
     -> Milestone 1
     -> Milestone 2
Engineering 
      -> Backend Team
            -> Sprint 1
            -> Sprint 2
      -> Security Team
            -> Milestone 1
            -> Milestone 2
Dec 18 2015, 11:45 AM · Projects (v3)
fabe added a comment to T3670: Add subprojects.

Regarding the two use cases Engineering -> Backend && TeamX -> Sprint2:
I think you could treat them equally by having the parent project members be those of all the subprojects in both cases. I think it would be a valid usecase to change members from one sprint to the next (retaining the information about old sprints members).
All that's needed would be some magic upon project creation that uses the members from another project as a template (the last sprint or maybe the parent project as default).

Dec 18 2015, 8:15 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia

Oct 9 2015

fabe added a comment to T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.

@d.maznekov Here's my (working) config for an ActiveDirectory:
Hostname: IP of the DC
Port: 389
Base distinguished name: dc=company,dc=net
Search attributes: sAMAccountName
anonymous username: ldap
anonymous password: ***
username attribute: sAMAccountName
realname attribute: displayName
LDAP version: 3
No Referrals
No TLS
ActiveDirectoryDomain: DOM (domain name in short form)

Oct 9 2015, 7:10 AM · Auth

Jul 28 2015

fabe created T8979: Herald rule "Edit Log" leads to 404.
Jul 28 2015, 9:06 AM · Herald

Jun 17 2015

fabe added a comment to T8575: Reap easy performance improvements.

Maybe take a look @ D10600: Implement a git blame cache

Jun 17 2015, 2:51 PM · Performance

Jun 5 2015

fabe abandoned D11281: Do not send email notifications to users without view permissions.
Jun 5 2015, 9:09 AM
fabe abandoned D11329: Refactor email rendering into worker tasks.

The more gradual implementation is probably best. This diff spiralled a bit out of control.
However i'd still vote for the separate Editor / Publisher classes just for the sake of read/maintainability.
The automatic state save/load to transfer it to the workers feels quite dirty.

Jun 5 2015, 9:09 AM

May 29 2015

fabe added a comment to T8351: There is no way in Harbormaster to delete a Build plan.

Most phabricator object cannot be deleted through the webui; only archived/disabled.
You can use the phabricator/bin/remove utility to remove most of them permanently if you want to.
I'm not sure if it works for build plans already though...

May 29 2015, 11:57 AM · Harbormaster

May 27 2015

fabe created T8325: Treat functions with parameters defined in other functions in XHPASTLinter correctly.
May 27 2015, 10:01 AM · XHPAST, Lint

May 25 2015

fabe accepted D13006: Improve UX for Diffusion mail fields.

Nice :)

May 25 2015, 2:09 PM
fabe abandoned D10907: try to find duplicates using an analyzed elasticsearch field.

Elasticsearch mapping is part of head now. So the rest is quite obsolete.

May 25 2015, 12:44 PM
fabe planned changes to D11329: Refactor email rendering into worker tasks.

This needs a major rebase.
Let me know when/if you are interested to move on this and if you think refactoring the stuff into workers is the right approach.

May 25 2015, 12:41 PM
fabe abandoned D10661: skip over already existing users when displying ldap import search results. Ref T6267.
May 25 2015, 12:38 PM
fabe accepted D13000: Make "Tags" and "Branches" custom fields work properly in Diffusion.
May 25 2015, 12:30 PM
fabe added a comment to D12997: Add repository to audit emails.

I think you need to use updateTransactionMailBody instead of buildApplicationTransactionMailBody.

May 25 2015, 12:08 PM
fabe closed T8295: Show which commits were included in a merge commit in Herald emails as Resolved.

Thanks! :)

May 25 2015, 11:53 AM · Herald
fabe updated the diff for D12993: show merged commits in herald emails for merge commits.
  • fix inlines
May 25 2015, 11:47 AM
fabe updated the diff for D12993: show merged commits in herald emails for merge commits.
  • add diffusion.fields config and disable mergedcommits by default & celerity map fix
May 25 2015, 10:59 AM
fabe added a comment to T8295: Show which commits were included in a merge commit in Herald emails.

attached revision adds the feature as a customfield to diffusion (like branches & tags). However diffusion has no diffusion.fields config yet so currently i can't disable it by default.
Additional configurability for the customfields would be nice but would in this case only allow to set the max no. of commits shown.

May 25 2015, 10:35 AM · Herald
fabe abandoned D10542: Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name.
May 25 2015, 10:31 AM
fabe retitled D12993: show merged commits in herald emails for merge commits from to show merged commits in herald emails for merge commits.
May 25 2015, 10:31 AM
fabe added a revision to T8295: Show which commits were included in a merge commit in Herald emails: D12993: show merged commits in herald emails for merge commits.
May 25 2015, 10:31 AM · Herald

May 22 2015

fabe created T8296: Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown.
May 22 2015, 11:25 AM · Passphrase, Diffusion
fabe updated the diff for D10586: Minor workflow improvements for tasks.

rebase

May 22 2015, 7:58 AM
fabe updated the diff for D10600: Implement a git blame cache.

rebase and fix visibility

May 22 2015, 7:55 AM
fabe added a revision to T8295: Show which commits were included in a merge commit in Herald emails: D10542: Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name.
May 22 2015, 7:44 AM · Herald
fabe added a task to D10542: Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name: T8295: Show which commits were included in a merge commit in Herald emails.
May 22 2015, 7:44 AM
fabe created T8295: Show which commits were included in a merge commit in Herald emails.
May 22 2015, 7:44 AM · Herald
fabe updated the diff for D10542: Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name.

rebase

May 22 2015, 7:37 AM

May 21 2015

fabe added a comment to D12967: elasticsearch host quick fix.

just wasn't sure if there was a bette place to actually call setURI/Index.

May 21 2015, 3:59 PM
fabe updated the diff for D12967: elasticsearch host quick fix.

just use a constructor

May 21 2015, 3:59 PM
fabe retitled D12967: elasticsearch host quick fix from to elasticsearch host quick fix.
May 21 2015, 3:44 PM
fabe added a revision to T8274: Misconfigured Elasticsearch can fatal the setup issue process: D12967: elasticsearch host quick fix.
May 21 2015, 3:44 PM · Setup, Search
fabe reopened T8274: Misconfigured Elasticsearch can fatal the setup issue process as "Open".
May 21 2015, 3:44 PM · Setup, Search
fabe added a comment to T8274: Misconfigured Elasticsearch can fatal the setup issue process.

Attached diff would be a quick fix. Probably not the right place to put it though. There seems to be no good place to actually call the new setURI/setIndex

May 21 2015, 3:43 PM · Setup, Search
fabe added a comment to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty.

Didn't look at the code yet but it seems like the offset is somehow counted double (try playing with the offset parameter). Decreasing/Increasing it by one will add/remove two results each.
To get the remaining 14 tasks you can do a offset=50 (which will skip the first 100 tasks).

May 21 2015, 12:51 PM · Search

Apr 21 2015

fabe abandoned D11000: simple batch edit for workboard columns.
Apr 21 2015, 12:10 PM

Jan 27 2015

fabe awarded T7057: gethostbyname() allows some set of horrible things, up to arbitrary remote execution a The World Burns token.
Jan 27 2015, 4:46 PM · Security
fabe added a comment to T7047: Add user preference for diffs in emails.

I remember having to do something else for this to work. Unfortunately i can't remember what :(
The feature works fine for me.

Jan 27 2015, 8:43 AM · Restricted Project, Differential, Mail, Diffusion

Jan 26 2015

fabe added a comment to T7047: Add user preference for diffs in emails.

Yep. try setting both.

Jan 26 2015, 9:42 PM · Restricted Project, Differential, Mail, Diffusion
fabe added a comment to T7047: Add user preference for diffs in emails.

There are config settings for this already. Take a look at metamta.diffusion.inline-patches (which sets the maximum patch length inlined).

Jan 26 2015, 9:33 PM · Restricted Project, Differential, Mail, Diffusion

Jan 25 2015

fabe accepted rPc40bc0c8bf75: Replace the primary scrollbar with a fake one to prepare for a persistent….

Feels good on iOS too.
Thanks guys

Jan 25 2015, 9:38 AM

Jan 24 2015

fabe raised a concern with rPc40bc0c8bf75: Replace the primary scrollbar with a fake one to prepare for a persistent….

This feels very broken on mobile/iOS.
Not only am i unable to fast scroll to the bottom (fast swipe down won't work, it will always scroll just a little bit) it will also randomly stop scrolling down as if there was no more content. I was only able to comment on this commit by clicking on the last file and scrolling down a little bit. Simply scrolling over the diff to the bottom didn't work.(got stuck somewhere during the first file and wouldn't let me scroll down further)

Jan 24 2015, 1:02 AM

Jan 23 2015

fabe updated the diff for D11329: Refactor email rendering into worker tasks.

rebase

Jan 23 2015, 12:42 PM
fabe updated the diff for D10661: skip over already existing users when displying ldap import search results. Ref T6267.

rebasing

Jan 23 2015, 12:41 PM
fabe updated the diff for D10542: Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name.

rebasing

Jan 23 2015, 12:40 PM
fabe added a reviewer for D11329: Refactor email rendering into worker tasks: epriestley.
Jan 23 2015, 12:38 PM

Jan 21 2015

fabe added a comment to T7004: Don't send email whilst online.

I agree for the typical developer use-case. But currently people reporting bugs/suggesting features use maniphest as well and for them the email notification is crucial. So always sending them is probably best for now.

Jan 21 2015, 10:18 PM · Notifications, Mail
fabe added a comment to T7004: Don't send email whilst online.

I like the idea, but i think it's a tricky thing to get right. On most sites that do this i always had occasional problems not getting email notifications when opening/closing the site repeatedly during the day (which also is a common thing for me with tools like pahbricator).
I think notifying a user via email if he doesen't act on a web notification in a certain amount of time would be best. But that might make it way more tricky to implement.

Jan 21 2015, 9:12 PM · Notifications, Mail
fabe closed T7001: ParameterQueryException in Chatlogs as Wontfix.

Ah ok. I see.
Guess it's not worth fixing this then.

Jan 21 2015, 8:31 PM · Chatlog
fabe added a comment to T7001: ParameterQueryException in Chatlogs.

I guess if needed the links would then be just handled by the conpherence controller.
If not just showing a "deprecated" message would be nice.

Jan 21 2015, 4:47 PM · Chatlog
fabe created T7001: ParameterQueryException in Chatlogs.
Jan 21 2015, 9:02 AM · Chatlog

Jan 16 2015

fabe updated the diff for D10661: skip over already existing users when displying ldap import search results. Ref T6267.

rebasing

Jan 16 2015, 1:53 PM
fabe updated the diff for D11329: Refactor email rendering into worker tasks.
  • just remove some lint warnings. makes the diff easier to read
Jan 16 2015, 12:58 PM
fabe updated the diff for D11329: Refactor email rendering into worker tasks.
  • further refactoring. adding feeds to workers and a lot of cleanup.
  • provide a migration path for the other applications
Jan 16 2015, 12:51 PM
fabe updated the diff for D10600: Implement a git blame cache.
  • add new db schema config
  • populate blame cache on reparse
  • replaced some code with an already existing conduit call
  • rebasing and fix db validity issues
  • reabsing
Jan 16 2015, 8:58 AM

Jan 15 2015

fabe added a comment to T6973: Associating Diffusion commits to Projects.

I think the object herald rule would be reasonable. I can also imagine a use-case like the 'cowboy commits' rule on this install, bur where i don't wanna go as far as triggering an audit for every commit. Or grouping commits to project by the files touched for example.
Using project inheritance from the repo automatically would probably be wrong in a lot of cases.

Jan 15 2015, 6:39 PM · Feed, Projects, Diffusion
fabe added a comment to T6973: Associating Diffusion commits to Projects.

I suppose what he's trying to achieve is to see all commits related to a project in the projects feed. (we spoke in irc)
And in some cases this might be all commits made to a specific branch.

Jan 15 2015, 4:33 PM · Feed, Projects, Diffusion

Jan 12 2015

fabe added a comment to T6936: Call to undefined function _phutil_date_format().

Did you upgrade phabricator and maybe forgot libphutil ?
This function was renamed on 05.01.15 by 15e0669609d3f2a24d4212b69c02990ea19c510d

Jan 12 2015, 8:15 AM

Jan 11 2015

fabe added inline comments to D11329: Refactor email rendering into worker tasks.
Jan 11 2015, 5:12 PM
fabe added a comment to D11329: Refactor email rendering into worker tasks.

Basically i've just moved some code around. (I've just added comments to the old stuff so you can see where it comes from)

Jan 11 2015, 5:07 PM
fabe planned changes to D11329: Refactor email rendering into worker tasks.
Jan 11 2015, 5:01 PM
fabe retitled D11329: Refactor email rendering into worker tasks from to Refactor email rendering into worker tasks.
Jan 11 2015, 5:01 PM
fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: D11329: Refactor email rendering into worker tasks.
Jan 11 2015, 5:01 PM · Wikimedia, Policy
fabe added a revision to T6367: Send email with recipient's language and access levels, not sender's: D11329: Refactor email rendering into worker tasks.
Jan 11 2015, 5:01 PM · Wikimedia, Security, Localization, Mail

Jan 10 2015

fabe updated the test plan for D11281: Do not send email notifications to users without view permissions.
Jan 10 2015, 1:17 PM
fabe updated the diff for D11281: Do not send email notifications to users without view permissions.

move check into reply handler where phids are already expanded

Jan 10 2015, 1:16 PM
fabe added a comment to D11281: Do not send email notifications to users without view permissions.

Ok yeah you're right. The expansion happens later. it actually happens twice. In the MailReplyHandler and in the MetaMTAMail class again - removing the expansion in the replyhandler seems to have no noticable effect. i still get emails if i'm just a project member.
Sending the email in the right locale would be very messy to resolve right now and i think your idea in T6367 (moving the whole rendering of emails for transactions into a worker) is the right choice. I'll take a look at this in more detail tomorrow.
Fixing the permissions problem for now could go into the ReplyHandler as it already knows about the object it is sending email about. So adding a policy check there should be easy.
I'll attach a diff.

Jan 10 2015, 1:01 PM

Jan 8 2015

fabe added inline comments to D11281: Do not send email notifications to users without view permissions.
Jan 8 2015, 1:21 PM
fabe retitled D11281: Do not send email notifications to users without view permissions from to do not send email notifications to users without view permissions.
Jan 8 2015, 1:20 PM
fabe added a revision to T6367: Send email with recipient's language and access levels, not sender's: D11281: Do not send email notifications to users without view permissions.
Jan 8 2015, 1:20 PM · Wikimedia, Security, Localization, Mail
fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: D11281: Do not send email notifications to users without view permissions.
Jan 8 2015, 1:20 PM · Wikimedia, Policy
fabe added a comment to T6894: Add option to feature: Option of "completed" in Status list of task..

The maniphest.status config option allows you to specify any status as being treated as "closed".
Actually there is no single "closed" status. But resolved, invalid, spite & wontfix are all treated as closed.
Feel free to rename / change this properties to your liking and your preferred workflow.
What you describe would be somethink like:

{
  "open": {
    "name": "Open",
    "special": "default"
  },
  "resolved": {
    "name": "Resolved",
    "name.full": "Resolved",
    "closed": false,
    "prefixes": [
      "fix",
      "fixes",
      "fixed",
      "resolve",
      "resolves",
      "resolved"
    ],
    "suffixes": [
      "as resolved",
      "as fixed"
    ]
  },
  "closeresolved": {
    "name": "Resolved & Closed",
    "name.full": "Closed, Resolved",
    "closed": true,
    "special": "closed",
    "prefixes": [
      "closed",
      "closes",
      "close"
    ]
  },
  "wontfix": {
    "name": "Wontfix",
    "name.full": "Closed, Wontfix",
    "closed": true,
    "prefixes": [
      "wontfix",
      "wontfixes",
      "wontfixed"
    ],
    "suffixes": [
      "as wontfix"
    ]
  },
  "invalid": {
    "name": "Invalid",
    "name.full": "Closed, Invalid",
    "closed": true,
    "prefixes": [
      "invalidate",
      "invalidates",
      "invalidated"
    ],
    "suffixes": [
      "as invalid"
    ]
  },
  "duplicate": {
    "name": "Duplicate",
    "name.full": "Closed, Duplicate",
    "transaction.icon": "fa-times",
    "special": "duplicate",
    "closed": true
  },
  "spite": {
    "name": "Spite",
    "name.full": "Closed, Spite",
    "name.action": "Spited",
    "transaction.icon": "fa-thumbs-o-down",
    "silly": true,
    "closed": true,
    "prefixes": [
      "spite",
      "spites",
      "spited"
    ],
    "suffixes": [
      "out of spite",
      "as spite"
    ]
  }
}
Jan 8 2015, 12:17 PM · User Preferences, Maniphest
fabe accepted rP8b7561776f3f: Rename `PhabricatorPolicyRule` subclasses for consistency.
Jan 8 2015, 11:46 AM · Blessed Reviewers
fabe added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

just run

./bin/search init

first.
This will create the needed elasticsearch index.

Jan 8 2015, 10:19 AM · Search

Jan 7 2015

fabe added a comment to D11143: Rewrite Aphlict to use Websockets.

Just some personal experience with ws vs. wss:
In our websites we've noticed that a few Anti-Virus programs which tend to proxy http sessions (e.g. Kaspersky) are unable to do the websocket upgrade.
Sometimes the HTTP polling fallback (don't know if you use something like that) works, sometimes it'll break completely.

Jan 7 2015, 8:55 PM

Jan 6 2015

fabe accepted D11251: Continue after rejecting commits from a commit query.

I've reproduced it locally and this fixes it. Before the patch these were two separate foreaches.

Jan 6 2015, 3:55 PM

Jan 2 2015

fabe raised a concern with rP8b7561776f3f: Rename `PhabricatorPolicyRule` subclasses for consistency.

Ref T6849

Jan 2 2015, 1:28 PM · Blessed Reviewers
fabe retitled D11146: remove unused FeedStory object in getTitleForFeed functions from to remove unused FeedStory object in getTitleForFeed functions.
Jan 2 2015, 1:17 PM
fabe added a revision to T6545: Show unified config edit log in Config web UI: D11146: remove unused FeedStory object in getTitleForFeed functions.
Jan 2 2015, 1:17 PM · Setup

Jan 1 2015

fabe added a comment to D11050: make repo callsigns optional.

Thanks for tracking this down!

Jan 1 2015, 4:03 PM
fabe updated the test plan for D11050: make repo callsigns optional.
Jan 1 2015, 4:03 PM
fabe updated the diff for D11050: make repo callsigns optional.
  • enforce order of markup rules by setting priority (now works as expected)
  • initialize identifierMap only once loadPage() instead of willFilterPage()
  • %Ld instead of %Ls
Jan 1 2015, 4:01 PM
fabe updated the diff for D11049: Do not CC users without permissions to view an object.

simplify maniphest transaction fix

Jan 1 2015, 3:50 PM
fabe added a comment to D11050: make repo callsigns optional.

rPHUba927e22f98477e8a8aed28459391dd8ff512ae0
rPHUba927
rPHU:ba927e22f98477e8a8aed28459391dd8ff512ae0
rPHU:ba927
R2:ba927e22f98477e8a8aed28459391dd8ff512ae0
R2:ba927
R2
rPHU

Jan 1 2015, 2:24 PM
fabe updated the diff for D11050: make repo callsigns optional.

now only allow R123 R123:commit rTEST rTEST:1234
lowercase r for callsigns and uppercase for IDs

Jan 1 2015, 2:20 PM
fabe added a comment to D11088: Settings History.

Ok, i've checked all the implementations of getTitleForFeed and getApplicationTransactionTitleForFeed which get $story passed and it is never used anywhere...
Want me to submit a diff removing it?

Jan 1 2015, 1:19 PM