Page MenuHomePhabricator

fabe (Fabian Stelzer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 29 2014, 3:12 PM (634 w, 2 d)
Availability
Available

Recent Activity

Aug 7 2019

fabe added a comment to T13358: Generate PDFs for Phortune invoices.

you can add libreoffice/soffice to your list. last time we had to do sth like this we used soffice --headless --convert-to pdf
not really better than running a browser though... in our use case we needed to use merchant uploaded doc/docx templates in combination with our data. so even less options.
but yeah most options around pdf generation are clunky.

Aug 7 2019, 4:30 PM · Phortune, Phacility

Jul 19 2017

fabe added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

We've been experiencing this problem from time to time as well.
In our case between two Phabricator installations.
The internal one observing a repository from a central dev server which always works fine.
Then the internal phabricator has a "mirror" URI configured for the repository to push any changes to an external phabricator installation.
This mirroring fails from time to time with the same error others have posted before (Unable to identify the reftype of 'refs/remotes/... in src/applications/diffusion/engine/DiffusionCommitHookEngine.php:404). Sometimes i could fix it by simply deleting a remote branch that was no longer needed anyway.
I've added a dirty fix now by inserting a "continue;" at line 404 so that the parser in findGitRefUpdates() simply skips unknown ref types and still imports the changes instead of failing completely with an exception.
Though i'm not sure what kind of side effects i might have introduced with this.

Jul 19 2017, 11:49 AM · Diffusion

Jan 11 2017

fabe added a comment to T12097: Object Herald Rules for Commits on Projects no longer working as expected.

I tested the patch on my install and it restores the old behaviour!

Jan 11 2017, 6:17 PM · Bug Report
fabe added a comment to T12097: Object Herald Rules for Commits on Projects no longer working as expected.

Unfortunately i'm not quite sure from exactly which version we've upgraded from. But you're probably right and it was a version before Aug 17.
I regularly read the release logs and in the ones i checked before upgrading (which was about 2-3 months worth of em) the latest Modernisation seemed the only thing touching something related to the problem.
D16413 probably didn't make it into any changelog or was just such a minor note that i didn't see it.

Jan 11 2017, 6:09 PM · Bug Report
fabe updated the task description for T12097: Object Herald Rules for Commits on Projects no longer working as expected.
Jan 11 2017, 5:47 PM · Bug Report
fabe created T12097: Object Herald Rules for Commits on Projects no longer working as expected.
Jan 11 2017, 5:45 PM · Bug Report
fabe added a comment to T11114: Move Differential to EditEngine.

I think this might have broken one of our Herald rules. The rule in question is an Object rule for Commits on a Project and will open an Audit whenever a commit is made to a repository that's tagged with this project.
At least it did ~2 month ago and after the upgrade it just won't fire. Just using the test console on a new commit in a repo tagged with the project simply says "Rule failed".
To make sure i already removed all the other conditions from it so it only states "always".

Jan 11 2017, 5:27 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential

Aug 2 2016

fabe added a comment to T5055: Distribution mechanism for arc extensions.

The whole "identify the packager problem" with composer is indeed a big one and i'm not suggesting you use composer in any way for the arcanist/phabricator packages! Generally i agree that i want to primarily trust the packager and not the developer. This is the way this is handled with os packages (rpm/deb) and companies are used to the workflow: Getting new packages from a somewhat trusted/signed source (e.g. redhat/canonical), testing them yourself, signing them with your own key as well and then distributing to the internal repositories and "end users" only trust your own internal key.

Aug 2 2016, 4:18 PM · Arcanist
fabe added a comment to T5055: Distribution mechanism for arc extensions.

It might be beneficial to generally support gpg signed commits / tags in phabricators git repos and then use the same mechanism for the arcanist packages.
Since github recently started pushing this feature a bit (https://github.com/blog/2144-gpg-signature-verification) quite a few library maintainers started signing their release tags.
And i just recently spoke to a lib maintainer about extending composer to verify all packages (on install or upgrade) against a list of authors trusted by the user (or an enterprise wide list).

Aug 2 2016, 1:46 PM · Arcanist

May 4 2016

fabe added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

I've run into this problem with my puppet repositories. A common puppet workflow is to use every branch as a puppet environment.
This way you can test a large change on a subset of production servers before applying it to the production branch itself.

May 4 2016, 3:37 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Dec 20 2015

fabe added a comment to T10010: Implement Subprojects.

Ok, i misunderstood the withMemberPHIDs reference. I thought you wanted to get all the members of a parent project including it's childs.

Dec 20 2015, 9:14 PM · Projects (v3)
fabe added a comment to T10010: Implement Subprojects.

Have you considered using a nested set for the project hierarchies and build them dynamically?
I've used it in the past for hierarchy stuff and it performs very well for things like "get the sum of value X from this Entity and all of it's children"

Dec 20 2015, 3:15 PM · Projects (v3)

Dec 18 2015

fabe added a comment to T10010: Implement Subprojects.

I think sth like the following would be quite common:

Sales
     -> Milestone 1
     -> Milestone 2
Engineering 
      -> Backend Team
            -> Sprint 1
            -> Sprint 2
      -> Security Team
            -> Milestone 1
            -> Milestone 2
Dec 18 2015, 11:45 AM · Projects (v3)
fabe added a comment to T3670: Add subprojects.

Regarding the two use cases Engineering -> Backend && TeamX -> Sprint2:
I think you could treat them equally by having the parent project members be those of all the subprojects in both cases. I think it would be a valid usecase to change members from one sprint to the next (retaining the information about old sprints members).
All that's needed would be some magic upon project creation that uses the members from another project as a template (the last sprint or maybe the parent project as default).

Dec 18 2015, 8:15 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia

Oct 9 2015

fabe added a comment to T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.

@d.maznekov Here's my (working) config for an ActiveDirectory:
Hostname: IP of the DC
Port: 389
Base distinguished name: dc=company,dc=net
Search attributes: sAMAccountName
anonymous username: ldap
anonymous password: ***
username attribute: sAMAccountName
realname attribute: displayName
LDAP version: 3
No Referrals
No TLS
ActiveDirectoryDomain: DOM (domain name in short form)

Oct 9 2015, 7:10 AM · Auth

Jul 28 2015

fabe created T8979: Herald rule "Edit Log" leads to 404.
Jul 28 2015, 9:06 AM · Herald

Jun 17 2015

fabe added a comment to T8575: Reap easy performance improvements.

Maybe take a look @ {D10600}

Jun 17 2015, 2:51 PM · Performance

May 29 2015

fabe added a comment to T8351: There is no way in Harbormaster to delete a Build plan.

Most phabricator object cannot be deleted through the webui; only archived/disabled.
You can use the phabricator/bin/remove utility to remove most of them permanently if you want to.
I'm not sure if it works for build plans already though...

May 29 2015, 11:57 AM · Harbormaster

May 27 2015

fabe created T8325: XHPASTLinter does not scope parameters to closures correctly.
May 27 2015, 10:01 AM · XHPAST, Lint

May 25 2015

fabe closed T8295: Show which commits were included in a merge commit in Herald emails as Resolved.

Thanks! :)

May 25 2015, 11:53 AM · Herald
fabe added a comment to T8295: Show which commits were included in a merge commit in Herald emails.

attached revision adds the feature as a customfield to diffusion (like branches & tags). However diffusion has no diffusion.fields config yet so currently i can't disable it by default.
Additional configurability for the customfields would be nice but would in this case only allow to set the max no. of commits shown.

May 25 2015, 10:35 AM · Herald
fabe added a revision to T8295: Show which commits were included in a merge commit in Herald emails: Unknown Object (Differential Revision).
May 25 2015, 10:31 AM · Herald

May 22 2015

fabe created T8296: Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown.
May 22 2015, 11:25 AM · Passphrase, Diffusion
fabe added a revision to T8295: Show which commits were included in a merge commit in Herald emails: Unknown Object (Differential Revision).
May 22 2015, 7:44 AM · Herald
fabe created T8295: Show which commits were included in a merge commit in Herald emails.
May 22 2015, 7:44 AM · Herald

May 21 2015

fabe added a revision to T8274: Misconfigured Elasticsearch can fatal the setup issue process: Unknown Object (Differential Revision).
May 21 2015, 3:44 PM · Setup, Search
fabe reopened T8274: Misconfigured Elasticsearch can fatal the setup issue process as "Open".
May 21 2015, 3:44 PM · Setup, Search
fabe added a comment to T8274: Misconfigured Elasticsearch can fatal the setup issue process.

Attached diff would be a quick fix. Probably not the right place to put it though. There seems to be no good place to actually call the new setURI/setIndex

May 21 2015, 3:43 PM · Setup, Search
fabe added a comment to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty.

Didn't look at the code yet but it seems like the offset is somehow counted double (try playing with the offset parameter). Decreasing/Increasing it by one will add/remove two results each.
To get the remaining 14 tasks you can do a offset=50 (which will skip the first 100 tasks).

May 21 2015, 12:51 PM · Search

Jan 27 2015

fabe awarded T7057: gethostbyname() allows some set of horrible things, up to arbitrary remote execution a The World Burns token.
Jan 27 2015, 4:46 PM · Security
fabe added a comment to T7047: Add user preference for diffs in emails.

I remember having to do something else for this to work. Unfortunately i can't remember what :(
The feature works fine for me.

Jan 27 2015, 8:43 AM · Restricted Project, Differential, Mail, Diffusion

Jan 26 2015

fabe added a comment to T7047: Add user preference for diffs in emails.

Yep. try setting both.

Jan 26 2015, 9:42 PM · Restricted Project, Differential, Mail, Diffusion
fabe added a comment to T7047: Add user preference for diffs in emails.

There are config settings for this already. Take a look at metamta.diffusion.inline-patches (which sets the maximum patch length inlined).

Jan 26 2015, 9:33 PM · Restricted Project, Differential, Mail, Diffusion

Jan 21 2015

fabe added a comment to T7004: Don't send email whilst online.

I agree for the typical developer use-case. But currently people reporting bugs/suggesting features use maniphest as well and for them the email notification is crucial. So always sending them is probably best for now.

Jan 21 2015, 10:18 PM · Notifications, Mail
fabe added a comment to T7004: Don't send email whilst online.

I like the idea, but i think it's a tricky thing to get right. On most sites that do this i always had occasional problems not getting email notifications when opening/closing the site repeatedly during the day (which also is a common thing for me with tools like pahbricator).
I think notifying a user via email if he doesen't act on a web notification in a certain amount of time would be best. But that might make it way more tricky to implement.

Jan 21 2015, 9:12 PM · Notifications, Mail
fabe closed T7001: ParameterQueryException in Chatlogs as Wontfix.

Ah ok. I see.
Guess it's not worth fixing this then.

Jan 21 2015, 8:31 PM · Chatlog
fabe added a comment to T7001: ParameterQueryException in Chatlogs.

I guess if needed the links would then be just handled by the conpherence controller.
If not just showing a "deprecated" message would be nice.

Jan 21 2015, 4:47 PM · Chatlog
fabe created T7001: ParameterQueryException in Chatlogs.
Jan 21 2015, 9:02 AM · Chatlog

Jan 15 2015

fabe added a comment to T6973: Associating Diffusion commits to Projects.

I think the object herald rule would be reasonable. I can also imagine a use-case like the 'cowboy commits' rule on this install, bur where i don't wanna go as far as triggering an audit for every commit. Or grouping commits to project by the files touched for example.
Using project inheritance from the repo automatically would probably be wrong in a lot of cases.

Jan 15 2015, 6:39 PM · Feed, Projects, Diffusion
fabe added a comment to T6973: Associating Diffusion commits to Projects.

I suppose what he's trying to achieve is to see all commits related to a project in the projects feed. (we spoke in irc)
And in some cases this might be all commits made to a specific branch.

Jan 15 2015, 4:33 PM · Feed, Projects, Diffusion

Jan 12 2015

fabe added a comment to T6936: Call to undefined function _phutil_date_format().

Did you upgrade phabricator and maybe forgot libphutil ?
This function was renamed on 05.01.15 by 15e0669609d3f2a24d4212b69c02990ea19c510d

Jan 12 2015, 8:15 AM

Jan 11 2015

fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Unknown Object (Differential Revision).
Jan 11 2015, 5:01 PM · Wikimedia, Policy
fabe added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jan 11 2015, 5:01 PM · Wikimedia, Security, Localization, Mail

Jan 8 2015

fabe added a revision to T6367: Send email with recipient's language and access levels, not sender's: Unknown Object (Differential Revision).
Jan 8 2015, 1:20 PM · Wikimedia, Security, Localization, Mail
fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Unknown Object (Differential Revision).
Jan 8 2015, 1:20 PM · Wikimedia, Policy
fabe added a comment to T6894: Add option to feature: Option of "completed" in Status list of task..

The maniphest.status config option allows you to specify any status as being treated as "closed".
Actually there is no single "closed" status. But resolved, invalid, spite & wontfix are all treated as closed.
Feel free to rename / change this properties to your liking and your preferred workflow.
What you describe would be somethink like:

{
  "open": {
    "name": "Open",
    "special": "default"
  },
  "resolved": {
    "name": "Resolved",
    "name.full": "Resolved",
    "closed": false,
    "prefixes": [
      "fix",
      "fixes",
      "fixed",
      "resolve",
      "resolves",
      "resolved"
    ],
    "suffixes": [
      "as resolved",
      "as fixed"
    ]
  },
  "closeresolved": {
    "name": "Resolved & Closed",
    "name.full": "Closed, Resolved",
    "closed": true,
    "special": "closed",
    "prefixes": [
      "closed",
      "closes",
      "close"
    ]
  },
  "wontfix": {
    "name": "Wontfix",
    "name.full": "Closed, Wontfix",
    "closed": true,
    "prefixes": [
      "wontfix",
      "wontfixes",
      "wontfixed"
    ],
    "suffixes": [
      "as wontfix"
    ]
  },
  "invalid": {
    "name": "Invalid",
    "name.full": "Closed, Invalid",
    "closed": true,
    "prefixes": [
      "invalidate",
      "invalidates",
      "invalidated"
    ],
    "suffixes": [
      "as invalid"
    ]
  },
  "duplicate": {
    "name": "Duplicate",
    "name.full": "Closed, Duplicate",
    "transaction.icon": "fa-times",
    "special": "duplicate",
    "closed": true
  },
  "spite": {
    "name": "Spite",
    "name.full": "Closed, Spite",
    "name.action": "Spited",
    "transaction.icon": "fa-thumbs-o-down",
    "silly": true,
    "closed": true,
    "prefixes": [
      "spite",
      "spites",
      "spited"
    ],
    "suffixes": [
      "out of spite",
      "as spite"
    ]
  }
}
Jan 8 2015, 12:17 PM · User Preferences, Maniphest
fabe added a comment to T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.

just run

./bin/search init

first.
This will create the needed elasticsearch index.

Jan 8 2015, 10:19 AM · Search

Jan 2 2015

fabe added a revision to T6545: Show unified config edit log in Config web UI: Restricted Differential Revision.
Jan 2 2015, 1:17 PM · Setup

Dec 30 2014

fabe added a revision to T6545: Show unified config edit log in Config web UI: Unknown Object (Differential Revision).
Dec 30 2014, 4:18 PM · Setup
fabe added a comment to T6833: Maniphest Reports by Project throws "PhabricatorDataNotAttachedException".

yep you were right. just missed a case.

Dec 30 2014, 2:56 PM · Maniphest
fabe added a revision to T6833: Maniphest Reports by Project throws "PhabricatorDataNotAttachedException": Unknown Object (Differential Revision).
Dec 30 2014, 2:55 PM · Maniphest
fabe created T6833: Maniphest Reports by Project throws "PhabricatorDataNotAttachedException".
Dec 30 2014, 1:18 PM · Maniphest

Dec 29 2014

fabe added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Dec 29 2014, 3:32 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
fabe added a revision to T4411: Adding a CC to a Maniphest Task should give View rights for that user: Unknown Object (Differential Revision).
Dec 29 2014, 11:22 AM · Wikimedia, Policy
fabe added a revision to T6533: Add a setup warning for pygments not being installed/configured: Unknown Object (Differential Revision).
Dec 29 2014, 9:48 AM · Setup

Dec 23 2014

fabe added a comment to T6806: Raise severity of "phd.user" warning eventually.

I should add that the current setup check only alerts if there's a mismatch between config and running daemon.
If phd.user is not configured at all (default) it will not trigger.

Dec 23 2014, 4:15 PM · Daemons
fabe added a revision to T5196: Enforce that phd is run as the phd.user daemon user: Unknown Object (Differential Revision).
Dec 23 2014, 12:49 PM · Support Impact, Daemons

Dec 22 2014

fabe added a revision to T6663: Friendly message when exceeding file upload size limit: Unknown Object (Differential Revision).
Dec 22 2014, 3:14 PM · Files
fabe added a revision to T6747: Add setup warning for ft_boolean_syntax for installs using MySQL search : Unknown Object (Differential Revision).
Dec 22 2014, 2:55 PM · Maniphest, Search

Dec 19 2014

fabe removed a revision from T6656: Maniphest Reports break when you have 75k tasks: Unknown Object (Differential Revision).
Dec 19 2014, 4:14 PM · Wikimedia, Maniphest
fabe added a revision to T6656: Maniphest Reports break when you have 75k tasks: Unknown Object (Differential Revision).
Dec 19 2014, 1:03 PM · Wikimedia, Maniphest

Dec 17 2014

fabe added a comment to T5523: Make bulk moves easier on Workboards.

Attached diff allows for batch edits of all tasks in a workboard column (only all, no selection possible). And please note that you have to reload the board when you make column moves and want to batch edit afterwards!
Very handy to close all tasks in a column or add/remove a project.

Dec 17 2014, 10:20 AM · Restricted Project, Workboards
fabe added a revision to T5523: Make bulk moves easier on Workboards: Unknown Object (Differential Revision).
Dec 17 2014, 10:18 AM · Restricted Project, Workboards

Dec 4 2014

fabe added a comment to T6552: Implement partial / wildcard searching (Elasticsearch).

One way of doing this is by adjusting the mapping for the elasticsearch index (actually way more powerful than a wildcard search).
I currently switched to the mapping below (added as a template expecting the index to be named 'phabricator' and with an english language setting).
Feel free to change the min/max ngrams setting (e.g. 4 instead of 3 letter ngrams) if you get too many / few results.
If you like to switch to another language the docs to do so are here: http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/analysis-lang-analyzer.html
For it to take effect you have to delete the index and then reindex all objects (bin/index --all).

Dec 4 2014, 12:17 PM · Elasticsearch, Search

Dec 2 2014

fabe added a revision to T6656: Maniphest Reports break when you have 75k tasks: Unknown Object (Differential Revision).
Dec 2 2014, 12:57 PM · Wikimedia, Maniphest
fabe added a comment to T6656: Maniphest Reports break when you have 75k tasks.

My dev env is up2date.
But you're right that all the tasks are assigned to one user and that causes the problem within loadStatus on every page.
However as far as i can see in the reports the getDestinationPHIDs is called for every user there is and therefore causes the same problem there.
I've rearranged the way getDestinationPHIDs works a bit and it went from 60s to a 2s load time (for loadStatus as well). Which is still not great but might be acceptable for a reports page or a user who has 10k assigned tasks.

Dec 2 2014, 12:54 PM · Wikimedia, Maniphest
fabe added a comment to T6656: Maniphest Reports break when you have 75k tasks.

Ok, i've created ~10k tasks in my dev installation to test this more thoroughly.
I still see the full table scan on the edge table (tested on mysql 5.1 & 5.6). E.g.:

Dec 2 2014, 10:26 AM · Wikimedia, Maniphest

Dec 1 2014

fabe added a comment to T6656: Maniphest Reports break when you have 75k tasks.

If the reports feature is what the user expects to find or is helpful is a whole different question.

Dec 1 2014, 3:30 PM · Wikimedia, Maniphest

Nov 28 2014

fabe removed a revision from T6656: Maniphest Reports break when you have 75k tasks: Unknown Object (Differential Revision).
Nov 28 2014, 1:59 PM · Wikimedia, Maniphest
fabe added a revision to T4828: Suggest/propose possible duplicates when creating a new task: Unknown Object (Differential Revision).
Nov 28 2014, 1:59 PM · Wikimedia, Maniphest
fabe added a comment to T4828: Suggest/propose possible duplicates when creating a new task.

The attached revision will get all tasks marked as duplicate in the maniphest db and then tries to find the task it was merged into in the elasticsearch just using the title.
By default it will use the standard analyzed field in elasticsearch as it is right now.
If you run installmapping and reindex the tasks the results should get better because it will utilize english stopwords and stemming.
Let's see what this yields. If it still find too less results we can try to combine an ngrams / edge_ngrams analyzer into it.

Nov 28 2014, 1:58 PM · Wikimedia, Maniphest
fabe added a comment to T6656: Maniphest Reports break when you have 75k tasks.
Nov 28 2014, 1:06 PM · Wikimedia, Maniphest
fabe added a revision to T6656: Maniphest Reports break when you have 75k tasks: Unknown Object (Differential Revision).
Nov 28 2014, 1:03 PM · Wikimedia, Maniphest

Nov 27 2014

fabe added a comment to T6656: Maniphest Reports break when you have 75k tasks.

In ManiphestTaskQuery it says:

// TODO: Eventually, we should make this optional and introduce a
// needProjectPHIDs() method, but for now there's a lot of code which
// assumes the data is always populated.
Nov 27 2014, 9:49 AM · Wikimedia, Maniphest

Nov 25 2014

fabe added a comment to T4828: Suggest/propose possible duplicates when creating a new task.

We have the same problem with more casual submitters.
I could think of a fairly easy but powerful implementation of this when elasticsearch as a backend is used.
The custom scoring and basic language processing stuff is really nice and would allow for things like listing bugs within the same project before others quite easily.

Nov 25 2014, 1:14 PM · Wikimedia, Maniphest

Nov 12 2014

fabe added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

We had a similar problem (tracking feature branches and triggering a herald rule when a commit shows up in master) and solved it by specifically looking for the merge commit in the master/production branch.
Depending on what your herald rule does it might be necessary to apply an action to every commit contained in a merge commit. I'm not sure what happens if you trigger an audit on the merge commit. It might include more commits than what you want.

Nov 12 2014, 9:01 AM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Oct 8 2014

fabe added a revision to T6267: Ignore already existing phabricator users when listing ldap results: Unknown Object (Differential Revision).
Oct 8 2014, 9:10 AM · Auth, LDAP
fabe created T6267: Ignore already existing phabricator users when listing ldap results.
Oct 8 2014, 9:08 AM · Auth, LDAP

Oct 3 2014

fabe added a revision to T2453: Populate the blame cache when parsing commits: Unknown Object (Differential Revision).
Oct 3 2014, 5:49 PM · Diffusion, OS Students 2013

Oct 2 2014

fabe added a comment to T1191: Comments are truncated at first non-base-plane character.

there seems to be some major changes between the mysql versions with the charsets and the syntax.
When running the adjust script against a mysql 5.1 i get:
#1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'binary NULL' at line 1

Oct 2 2014, 4:53 PM · Wikimedia, Support Impact, High Support Impact, Differential
fabe added a comment to T6228: Error log spew after failing to set utf8mb4 charset.

as mentioned this is a dev install just for me. i'd be happy to test with a mysql 5.1 if you like. doesen't matter if it completely breaks ;)

Oct 2 2014, 4:29 PM · Infrastructure
fabe added a comment to T6228: Error log spew after failing to set utf8mb4 charset.

Ah i see. I thought the changes were already merged. My dev installation i've made earlier today still has utf8_general_ci.

Oct 2 2014, 4:25 PM · Infrastructure
fabe added a comment to T6228: Error log spew after failing to set utf8mb4 charset.

Upon importing the phabricator repo the import will stop at 99% because the last commit containing the unicode char can't be imported.
Error is the same that initially triggered the whole problem:

Oct 2 2014, 4:16 PM · Infrastructure
fabe added a comment to T6228: Error log spew after failing to set utf8mb4 charset.

I've just set up a new dev phabricator today using a mysql 5.1.41
Error logs are flooded with (for every query): ERROR 2: mysqli::set_charset(): Error executing query at [.....libphutil/src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:70]

Oct 2 2014, 3:45 PM · Infrastructure

Sep 28 2014

fabe added a revision to T2450: Build a blame cache: Unknown Object (Differential Revision).
Sep 28 2014, 3:59 PM · Diffusion
fabe added a comment to T2450: Build a blame cache.

Had some free time today and implemented this. The improvement however is not as big as i expected.
Doing a blame on phabricators __phutil_library_map__.php will take ~20sec without and ~15sec with the cache on my dev vm.

Sep 28 2014, 3:58 PM · Diffusion

Sep 27 2014

fabe added a comment to T2928: "arc start" / "arc feature" / "arc push" Discussion.

D10586 implements the "arc feature T123". It will assign the task if it's free and tell you who owns it otherwise. (Creating the branch in both cases)

Sep 27 2014, 9:07 PM · Arcanist, Maniphest, Phrequent
fabe created T6202: maniphest.update conduit api does not allow to unset the ownerPHID.
Sep 27 2014, 2:21 PM · Maniphest, Conduit