- move language and dependencies config to Repositories (Default All and None, respectively)
- change controller and storage to use repositoryID instead of arcanistProjectID
- delete all mention of arcanistProjectID in Symbols.
Description
Description
Revisions and Commits
Revisions and Commits
| rPHU libphutil | |||
| D12666 | rPHUaa016bffbb60 Remove PhutilTestCase class | ||
| rARC Arcanist | |||
| D12665 | rARC753705b2c5b5 Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase | ||
| D12664 | rARC399f0400185f Improve getLink method for unit tests | ||
| rP Phabricator | |||
| D12667 | rP69940f2b9ee4 Replace ArcanistPhutilTestCase refs with PhutilTestCase | ||
| D12687 | rP898ce6bace59 Search Symbols by Repository, not Project | ||
| D12688 | rPec22df5e171a Update symbols docs | ||
| D12663 | rP2cc898a63f00 Add repository parameter to `diffusion.findsymbols` method | ||
| D12668 | rP1dfe1f49f780 Fix a few issues with the "import symbols" script | ||
| D12608 | rP2483f6f120a4 Move symbols to be repository-based | ||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | joshuaspence | T7603 Remove the deprecated "Repositories" application | ||
| Resolved | joshuaspence | T7604 Remove "Arcanist Projects" | ||
| Resolved | avivey | T7977 Associate Symbols with Repositories directly (Instead of arc projects) |
Event Timeline
Comment Actions
I can sorta understand symbol sources, but why do we need to manually mark symbol languages? Can't we just use whatever languages have been indexed?
Comment Actions
@joshuaspence - I think we've discussed this in private already, but just for completeness:
saying a file have symbol links adds the underlined-by-dots-link-like behavior; When it was first introduced, they were more link-like, and prevented double-click-to-select-word, which is even more useful when the reviewer knows the file is in a language we don't even index. I think that off-by-default configuration is a relic of that push-back.
Today, the link-like feature lets you double-click to select, albeit it might not be obvious to new users.
There's also the general issue that symbol detection is actually in shambles for many languages (Including Python and Java).
I'd vote to remove the language selection (Possibly adding a "disable all symbols everywhere" flag), because:
- I think the "like a link, but you can double click it" is good enough for everybody; New users will have to be told once they can do that.
- Product-wise, I think having linked symbols, in reviews and in diffusion, is very valuable. I use it constantly where it's available, and miss it when it's not.
- Having it more exposed might help improve it's quality, eventually.