I'm not sure that is the issue. I'll have a further look from the NodeJS side and see what is happening.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 17 2014
Jul 17 2014
joshuaspence added a revision to T5651: "400 Bad Request" errors from Aphlict server: Restricted Differential Revision.
joshuaspence edited this Maniphest Task.
Ok, I managed to grab some of the data that is causing the 400:
joshuaspence triaged T5648: Add a linter rule for parentheses being used with PHP language constructs as Wishlist priority.
This may be a wider issue with Remarkup... I'm not too sure.
Jul 16 2014
Jul 16 2014
joshuaspence edited this Maniphest Task.
joshuaspence edited this Maniphest Task.
joshuaspence edited this Maniphest Task.
joshuaspence edited this Maniphest Task.
Oh wow... I have literally never noticed this. Thanks
With .arclint, this inconsistency is hidden from the API, in that there is only one engine, and it's implicit; In theory, the word "engine" isn't used in the lint flow any more.
By analogy, a ConfigurationDrivenUnit<something> would not be exposed, and the .arcunit file will hold test "engines" in the current meaning ("uniter"? "runner"? "tester"?).
I guess I'm suggesting is to make the lint code be more like the unit code (By removing the Engine layer from it). This will still break stuff, but mostly stuff we were trying to get rid of anyway, instead of just rename.
What's that exactly?
I think that Aphront should probably be in it's own module, rather than being added to libphutil. Celerity would also be in that module.
I can see at some point in the far future phutil being used as a module and package system for building sites or command line tools (which only need libphutil and don't want a full web stack).
In T1806#11, @epriestley wrote:For example, require_celerity_resource() and javelin_tag() are defined in Phabricator, but a lot of the moved code depends on them (I'm surprised arc lint didn't complain about this).
Thanks for the feedback. I figured that it was probably-not-quite-right but wasn't sure how to tackle this exactly (you're feedback now provides a better understanding of the work involved.
I've attached two diffs (D9941 and D9942) which I think close this task, although it seemed too simple? Let me know if anything is missing.
joshuaspence edited this Maniphest Task.
joshuaspence edited this Maniphest Task.
Jul 15 2014
Jul 15 2014
joshuaspence renamed T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data from 'arc land' should provide a mechanism to land revisions by other authors while preserving authorship meta-data to `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.
joshuaspence renamed T4701: Linter for <?hh code from Lint Engine for <?hh code to Linter for <?hh code.
Jul 14 2014
Jul 14 2014
joshuaspence updated the task description for T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jul 13 2014
Jul 13 2014
Ah whoops, yeah you're right.
joshuaspence renamed T5228: Perhaps remove the commit hook mode from linters from arc lint cpplint linter doesn't correctly match all output to Perhaps remove the commit hook mode from linters.
joshuaspence updated the task description for T5228: Perhaps remove the commit hook mode from linters.
Sure, sounds reasonable and it seems that T4420 isnt far away from being resolved (fixed in D9903).
Jul 11 2014
Jul 11 2014
I guess I'm primarily talking about maniphest. You (@epriestley) commented on two tickets (T5604 and T5602) and I had two notifications: one update subscribers and one commented.
joshuaspence added a comment to T5602: Consider flags to disable project features (can tag, can have members, can be reviewer...) .
Yeah that all sounds reasonable.
joshuaspence added a comment to T5602: Consider flags to disable project features (can tag, can have members, can be reviewer...) .
I suppose that differentials has a stronger case than maniphests. As in, there are some projects which don't make any sense to be specified as code reviewers.
joshuaspence added a comment to T5602: Consider flags to disable project features (can tag, can have members, can be reviewer...) .
Being a member of Blessed Reviewers doesnt imply that you can add new members. We have an "Access" project for this purpose.
joshuaspence updated the task description for T5602: Consider flags to disable project features (can tag, can have members, can be reviewer...) .
joshuaspence renamed T5306: Don't show archived projects in global typeahead by default from Don't show archived projects in global typeahead by defualt to Don't show archived projects in global typeahead by default.
Closed by commit rP9a679bf3746c.
joshuaspence edited this Maniphest Task.
joshuaspence renamed T4887: Extend the blocking reviewers functionality universally from Extend the blocking reviewers functionality universally. to Extend the blocking reviewers functionality universally.
Jul 10 2014
Jul 10 2014
joshuaspence renamed T4932: Items on user profile feed do not get updated from Items on user profile feed do not get updated. to Items on user profile feed do not get updated.
joshuaspence renamed T4948: Support checkstyle as an output format from Support checkstyle as an output format. to Support checkstyle as an output format.
joshuaspence renamed T4949: Support JUnit as an output format for unit test results from Support JUnit as an output format for unit test results. to Support JUnit as an output format for unit test results.
joshuaspence renamed T4950: Support outputting unit test coverage as Clover XML from Support outputting unit test coverage as Clover XML. to Support outputting unit test coverage as Clover XML.
joshuaspence renamed T4951: Automatically build XHPAST when possible from Automatically build XHPAST when possible. to Automatically build XHPAST when possible.
joshuaspence renamed T4965: Enable lint cache by default from Enable lint cache by default. to Enable lint cache by default.
joshuaspence renamed T4966: `arc lint --cache` is inconsistent in handling parameters from `arc lint --cache` is inconsistent in handling parameters. to `arc lint --cache` is inconsistent in handling parameters.
joshuaspence renamed T4991: Object of class PassphraseCredentialTypeSSHPrivateKeyFile could not be converted to string from Object of class PassphraseCredentialTypeSSHPrivateKeyFile could not be converted to string. to Object of class PassphraseCredentialTypeSSHPrivateKeyFile could not be converted to string.
joshuaspence renamed T5063: Debugging performance issues from Debugging performance issues. to Debugging performance issues.
joshuaspence renamed T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories from `arc lint --everything` uses a large amount of memory in when executed in large repositories. to `arc lint --everything` uses a large amount of memory in when executed in large repositories.
joshuaspence renamed T5121: Shell completion can be improved from Shell completion can be improved. to Shell completion can be improved.
joshuaspence renamed T5122: Running `arc shell-complete` without any arguments throws an error from Running `arc shell-complete` without any arguments throws an error. to Running `arc shell-complete` without any arguments throws an error.
joshuaspence renamed T5123: `arc inlines` appears to be broken from `arc inlines` appears to be broken. to `arc inlines` appears to be broken.
joshuaspence renamed T5128: Shell completion for the `--engine` flag from Shell completion for the `--engine` flag. to Shell completion for the `--engine` flag.
joshuaspence renamed T5129: Shell completion for output format from Shell completion for output format. to Shell completion for output format.
joshuaspence renamed T5130: Shell completion for `arc todo` is incorrect from Shell completion for `arc todo` is incorrect. to Shell completion for `arc todo` is incorrect.
joshuaspence renamed T5136: Allow default severity to be set in `.arclint` from Allow default severity to be set in `.arclint`. to Allow default severity to be set in `.arclint`.
joshuaspence renamed T5171: Create an `arc log` workflow from Create an `arc log` workflow. to Create an `arc log` workflow.
joshuaspence renamed T5172: Create an `arc status` workflow from Create an `arc status` workflow. to Create an `arc status` workflow.
joshuaspence renamed T5173: Provide man pages for Arcanist from Provide man pages for Arcanist. to Provide man pages for Arcanist.
I guess maybe that would get us half-way there. As in, it would allow us to say that upgrading might solve the problem, whereas a Conduit call could allow us to say whether upgrading would solve the problem. Just not sure if its worth the effort.
Actually, if this seems reasonable then I should be able to work on it.
joshuaspence renamed T5209: Add a version number to `ArcanistXHPASTLinter` from Add a version number to `ArcanistXHPASTLinter`. to Add a version number to `ArcanistXHPASTLinter`.
joshuaspence renamed T5226: `./bin/repository parents` fails with `AphrontQueryDuplicateKeyException` from `./bin/repository parents` fails with `AphrontQueryDuplicateKeyException`. to `./bin/repository parents` fails with `AphrontQueryDuplicateKeyException`.
joshuaspence renamed T5236: Allow projects to be deleted by `./bin/remove` if the project hasn't yet been used from Allow projects to be deleted by `./bin/remove` if the project hasn't yet been used. to Allow projects to be deleted by `./bin/remove` if the project hasn't yet been used.
joshuaspence renamed T5237: Formalize the concept of "Blessed Reviewers" from Formalize the concept of "Blessed Reviewers". to Formalize the concept of "Blessed Reviewers".
joshuaspence renamed T5238: Treat "Accepted" and "Accepted but Blocked" differentials differently within the UI from Treat "Accepted" and "Accepted but Blocked" differentials differently within the UI. to Treat "Accepted" and "Accepted but Blocked" differentials differently within the UI.
joshuaspence renamed T5255: Batch up SQL operations in the `./bin/repository parents` script from Batch up SQL operations in the `./bin/repository parents` script. to Batch up SQL operations in the `./bin/repository parents` script.
joshuaspence renamed T5258: Memes use older image transform code without modern error handling from `CommandException` when trying to create a thumbnail. to `CommandException` when trying to create a thumbnail.
joshuaspence renamed T5256: Separate project membership from project subscription from Separate project membership from project subscription. to Separate project membership from project subscription.
joshuaspence renamed T5261: Unhandled exception when trying to unsubscribe from a project from Unhandled exception when trying to unsubscribe from a project. to Unhandled exception when trying to unsubscribe from a project.
joshuaspence renamed T5264: Quoting a code block does not work as expected from Quoting a code block does not work as expected. to Quoting a code block does not work as expected.
joshuaspence renamed T5284: Allow users to receive Aphlict notifications for an object they are viewing from Allow users to receive Aphlict notifications for an object they are viewing. to Allow users to receive Aphlict notifications for an object they are viewing.
joshuaspence renamed T5324: Tweak Aphlict magic constants from Tweak Aphlict magic constants. to Tweak Aphlict magic constants.
joshuaspence renamed T5326: Provide a mechanism to filter daemon logs from Provide a mechanism to filter daemon logs. to Provide a mechanism to filter daemon logs.
joshuaspence renamed T5327: Provide a `./bin/lookup` script from Provide a `./bin/lookup` script. to Provide a `./bin/lookup` script.
joshuaspence renamed T5466: `ArcanistChmodLinter` does not raise an error on images that are executable from `ArcanistChmodLinter` does not raise an error on images that are executable. to `ArcanistChmodLinter` does not raise an error on images that are executable.
joshuaspence added a comment to T5587: Changing the orientation of the device causes the list view to appear too small.
I think that this is related (but possibly not). If I navigate to Diffusion > A repository > A commit and then hit the back button, I get this:
joshuaspence renamed T5344: Multiplex AJAX calls from Aphlict clients through the JX.Leader from Aphlict Server should transmit notifications instead of clients making an AJAX call to Multiplex AJAX calls from Aphlict clients through the `AphlictMaster`.
I'll just leave it as is.
(Does it make more sense for a lower number to represent a higher priority?)