Page MenuHomePhabricator
Create Task
Maniphest T5640

Detect the use of undefined classes/functions during linting
Closed, ResolvedPublic
Actions

Description

Previously we had the functionality to detect and raise warnings when undefined classes/functions were used in libphutil modules. This functionality was broken in D9864. Previously, $symbols was the raw output of phutil_symbols.php. After D9864, it's the processed output of PhutilLibraryMapBuilder, which no longer has the need key.

This issue was identified in T1806 (see T1806#11 and T1806#13).

Revisions and Commits

rPHU libphutil
D9953rPHU859c41d4fb07 Expose the file symbol map from PhutilLibraryMapBuilder
rARC Arcanist
D9954rARCc6e6227ef9bf Use have/need data in ArcanistPhutilLibraryLinter

Event Timeline

joshuaspence created this task.Jul 16 2014, 11:04 PM
joshuaspence assigned this task to epriestley.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Arcanist.
joshuaspence added a subscriber: joshuaspence.
joshuaspence edited this Maniphest Task.Jul 16 2014, 11:05 PM
joshuaspence edited this Maniphest Task.
epriestley edited this Maniphest Task.Jul 17 2014, 9:34 PM
epriestley edited this Maniphest Task.
epriestley closed this task as Resolved.Jul 17 2014, 9:35 PM
Phabricator · Built by Phacility