Page MenuHomePhabricator
Create Task
Maniphest T5264

Quoting a code block does not work as expected
Closed, ResolvedPublic
Actions

Description

I'm not sure what the expected behaviour here is, but quoting a comment which contains a code block does not function as I would expect.

{F163415}

The comment in question is D9343#7.

Revisions and Commits

rPHU libphutil
D9388rPHU120a050b9251 Allow triple backticks to be preceded by whitespace.

Event Timeline

joshuaspence created this task.Jun 4 2014, 11:09 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Remarkup.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Jun 4 2014, 11:16 PM

When we quote, we add > to the beginning of the text (that is: "greater than", "space"). For most rules this is fine, but the triple-backtick rule is sensitive to leading whitespace.

The best fix is probably to allow whitespace on a line before opening or closing triple backticks. Then "space space tick tick tick" would be a codeblock, but that seems reasonable, and will fix this issue.

joshuaspence edited this Maniphest Task.Jun 5 2014, 8:11 AM
joshuaspence edited this Maniphest Task.Jun 5 2014, 4:49 PM
joshuaspence closed this task as Resolved.Jun 5 2014, 4:49 PM

Closed by commit rPHU120a050b9251.

joshuaspence renamed this task from Quoting a code block does not work as expected. to Quoting a code block does not work as expected.Jul 10 2014, 7:28 PM
Phabricator · Built by Phacility