| epriestley | |
| Jun 10 2014, 4:34 PM |
| F165700: yMOdO6f.gif | |
| Jun 12 2014, 7:08 PM |
| F165686: 1187196_555668734470936_338267620_n.jpg | |
| Jun 12 2014, 6:46 PM |
In the global search typeahead, archived projects should either be omitted from the result list or shown with the same lower matching priority that they are in other interfaces.
Particularly, on this install, we have "Dashboard" (random user created project) and "Dashboards" (real project).
btw i poked around and tried to figure out where the typeahead sources come in, I wanted to add app-icons. Any hints on where to find that?
Yeah, I've wanted those forever. Let me see how easily fixable it is right now, and I can either point you in the right direction or shoot you a diff...
It's rendered in webroot/rsrc/js/core/behavior-search-typeahead.js, but it's hard-coded as a background image:
if (object[6]) {
attr.style = {backgroundImage: 'url('+object[6]+')'};
}The actual object[6] is sourced by calling setImageURI() on the PhabricatorTypeaheadResult object the server builds.
However, we need to turn that into a sprite thing / icon view so I think this is a bit involved.
Do you have a thought on what to show for "jump" results (that is, application documents, like D50)? I guess we can just throw the app icon on there as first approximation, they only show up if you type an object name explicitly.
I'd lean towards not having an icon for those, and no icon "space" either (would have to retouch the CSS a little).
