One call to for-each-ref comes from resolving a list of commit hashes, to test if they still exist. This is accomplished with DiffusionLowLevelResolveRefsQuery, which calls git for-each-ref first and falls back to git cat-file --batch-check.

Mar 28 2021, 5:44 PM · Diffusion

epriestley added a comment to T13647: Reduce repository update cost for repositories with large numbers of refs.

Has this repository changed?

Mar 28 2021, 5:25 PM · Diffusion

Mar 27 2021

epriestley committed rP33c847e667b6: (stable) Correct issue with "bindings" conduit attachment (authored by epriestley).

(stable) Correct issue with "bindings" conduit attachment

Mar 27 2021, 4:26 PM

epriestley committed rP5b8b5f214148: Correct issue with "bindings" conduit attachment (authored by epriestley).

Correct issue with "bindings" conduit attachment

Mar 27 2021, 4:26 PM

epriestley closed D21657: Correct issue with "bindings" conduit attachment.

Mar 27 2021, 4:26 PM

epriestley requested review of D21657: Correct issue with "bindings" conduit attachment.

Mar 27 2021, 4:26 PM

epriestley added a revision to T13641: Support "Disabled" devices in Almanac: D21657: Correct issue with "bindings" conduit attachment.

Mar 27 2021, 4:25 PM · Almanac

epriestley triaged T13648: Transaction publishing may stall during mail expansion of package recipients as Wishlist priority.

Mar 27 2021, 2:57 PM · Transactions

Mar 26 2021

epriestley triaged T13647: Reduce repository update cost for repositories with large numbers of refs as Normal priority.

Mar 26 2021, 11:09 PM · Diffusion

epriestley closed T13639: Allow revisions to be queried by affected path via the API as Resolved.

This is now in stable; presuming it works until evidence to the contrary emerges.

Mar 26 2021, 6:08 PM · Conduit, Differential

epriestley edited the content of Changelog.

Mar 26 2021, 6:07 PM

epriestley created an object: 2021 Week 13 (Late March).

Mar 26 2021, 6:06 PM

epriestley committed rARC7af9846f994a: (stable) Promote 2021 Week 13 (authored by epriestley).

(stable) Promote 2021 Week 13

Mar 26 2021, 6:05 PM

epriestley committed rPda8a579600c0: (stable) Promote 2021 Week 13 (authored by epriestley).

(stable) Promote 2021 Week 13

Mar 26 2021, 6:05 PM

epriestley added a comment to T13646: Add "E" to "variables_order" in Phacility environments.

D21656 fixes variables_order.

Mar 26 2021, 5:52 PM · Phacility, Infrastructure

epriestley added a revision to T13646: Add "E" to "variables_order" in Phacility environments: Unknown Object (Differential Revision).

Mar 26 2021, 5:19 PM · Phacility, Infrastructure

epriestley added a revision to T13641: Support "Disabled" devices in Almanac: Unknown Object (Differential Revision).

Mar 26 2021, 5:15 PM · Almanac

epriestley updated the test plan for D21654: Update client logic for inline comment "Save" and "Cancel" actions.

Mar 26 2021, 3:48 PM

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 26 2021, 3:48 PM · Accessibility, Differential

Mar 25 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 25 2021, 9:14 PM · Accessibility, Differential

epriestley requested review of D21654: Update client logic for inline comment "Save" and "Cancel" actions.

Mar 25 2021, 9:13 PM

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 25 2021, 9:13 PM · Accessibility, Differential

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21654: Update client logic for inline comment "Save" and "Cancel" actions.

Mar 25 2021, 9:12 PM · Accessibility, Differential

epriestley requested review of D21653: Formally track "initial", "committed", and "active" states for inline comments.

Mar 25 2021, 9:11 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21653: Formally track "initial", "committed", and "active" states for inline comments.

Mar 25 2021, 9:10 PM · Accessibility, Differential

epriestley requested review of D21652: When creating an inline comment, populate the content state with the default suggestion text.

Mar 25 2021, 9:08 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21652: When creating an inline comment, populate the content state with the default suggestion text.

Mar 25 2021, 9:07 PM · Accessibility, Differential

epriestley requested review of D21651: On inline comments, track an explicit "committed" content state.

Mar 25 2021, 9:06 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21651: On inline comments, track an explicit "committed" content state.

Mar 25 2021, 9:05 PM · Accessibility, Differential

epriestley requested review of D21650: Fix an issue when undoing mutiple inline comment deletions.

Mar 25 2021, 9:04 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21650: Fix an issue when undoing mutiple inline comment deletions.

Mar 25 2021, 9:03 PM · Accessibility, Differential

epriestley requested review of D21649: Make the client authoritative for "Cancel" actions.

Mar 25 2021, 9:01 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21649: Make the client authoritative for "Cancel" actions.

Mar 25 2021, 9:00 PM · Accessibility, Differential

epriestley requested review of D21648: Make the client authoritative for "Save" actions.

Mar 25 2021, 8:59 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21648: Make the client authoritative for "Save" actions.

Mar 25 2021, 8:58 PM · Accessibility, Differential

epriestley requested review of D21647: Remove direct reads of form state from main Inline client code.

Mar 25 2021, 8:57 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21647: Remove direct reads of form state from main Inline client code.

Mar 25 2021, 8:56 PM · Accessibility, Differential

epriestley requested review of D21646: Make client inlines track an "active" state.

Mar 25 2021, 8:55 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21646: Make client inlines track an "active" state.

Mar 25 2021, 8:54 PM · Accessibility, Differential

epriestley requested review of D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.

Mar 25 2021, 8:52 PM

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it.

Mar 25 2021, 8:51 PM · Accessibility, Differential

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

The "Cancel" button should mean "Delete" if...

Mar 25 2021, 8:21 PM · Accessibility, Differential

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 25 2021, 6:16 PM · Accessibility, Differential

epriestley triaged T13646: Add "E" to "variables_order" in Phacility environments as Low priority.

Mar 25 2021, 3:31 PM · Phacility, Infrastructure

Mar 24 2021

epriestley committed rP61272e7ac31a: Correct "getActiveBindings()" method name (authored by epriestley).

Correct "getActiveBindings()" method name

Mar 24 2021, 5:15 PM

epriestley closed D21644: Correct "getActiveBindings()" method name.

Mar 24 2021, 5:15 PM

epriestley requested review of D21644: Correct "getActiveBindings()" method name.

Mar 24 2021, 5:13 PM

Mar 23 2021

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Currently, the inline code partially conflates four separate content states:

Mar 23 2021, 5:57 PM · Accessibility, Differential

Mar 22 2021

epriestley committed rARCf0f95e5b2612: On Windows, implement "Filesystem::copyFile()" with "copy()" (authored by epriestley).

On Windows, implement "Filesystem::copyFile()" with "copy()"

Mar 22 2021, 7:00 PM

epriestley closed D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".

Mar 22 2021, 7:00 PM

epriestley renamed T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions from Filesystem class invokes "copy" command on Windows, which fails after "bypass_shell" changes to Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

Mar 22 2021, 7:00 PM · Windows, Arcanist

epriestley added a comment to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

D21643 "fixes" this by using copy(). However:

Mar 22 2021, 6:59 PM · Windows, Arcanist

epriestley requested review of D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".

Mar 22 2021, 6:43 PM

epriestley added a revision to T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions: D21643: On Windows, implement "Filesystem::copyFile()" with "copy()".

Mar 22 2021, 6:43 PM · Windows, Arcanist

epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.

Mar 22 2021, 6:14 PM · Windows, Arcanist

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 22 2021, 6:13 PM · Accessibility, Differential

epriestley added a comment to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

When you "Quote" a comment, then cancel, the comment disappears from the UI.

Mar 22 2021, 5:36 PM · Accessibility, Differential

epriestley updated the task description for T13534: Inline Comment errata after editing persistence.

Mar 22 2021, 5:32 PM · Differential

epriestley added a comment to T13534: Inline Comment errata after editing persistence.

When you are viewing a change under engine X, and comments made under engine Y are present, they are not handled specially.

Mar 22 2021, 5:32 PM · Differential

epriestley updated the task description for T13642: Inline comment line numbers on DocumentEngine block diffs may be clamped to raw lines in the source file.

Mar 22 2021, 5:31 PM · Differential

Mar 20 2021

epriestley added a comment to D21624: Remove or correct various "phabricator/" references to "libphutil".

Diviner updates based on the deployed software version on secure, and I just haven't deployed this yet. Stuff usually gets deployed in about a day, this has been on the slower side since I've been moving furniture.

Mar 20 2021, 3:55 PM

Mar 18 2021

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 18 2021, 6:45 PM · Accessibility, Differential

epriestley requested review of D21642: Fix an issue where inlines could be duplicated in the client list.

Mar 18 2021, 6:40 PM

epriestley updated the task description for T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.

Mar 18 2021, 6:39 PM · Accessibility, Differential

epriestley added a revision to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: D21642: Fix an issue where inlines could be duplicated in the client list.

Mar 18 2021, 6:33 PM · Accessibility, Differential

Mar 17 2021

epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

A general concern with "batch processing" is that it's quite bad if one commit failing to import can stall the entire repository forever.

Mar 17 2021, 11:18 PM · Diffusion, Differential

epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

See also T13552, which modifies the above discussion. The "Update" steps now happen after the "Publish" step.

Mar 17 2021, 11:12 PM · Diffusion, Differential

epriestley closed T13425: Support diffs between abstract block lists in the UI as Resolved.

The bulk of this work is done and I think there's nothing unique and actionable left here. This is survived by T13642 and other issues.

Mar 17 2021, 11:07 PM · Differential

epriestley closed T13515: Differential: Inlines and View Options as Resolved.

Survived by T13534, etc.

Mar 17 2021, 11:01 PM · Differential

epriestley updated the task description for T13534: Inline Comment errata after editing persistence.

Mar 17 2021, 11:00 PM · Differential

epriestley updated the task description for T13515: Differential: Inlines and View Options.

Mar 17 2021, 11:00 PM · Differential

epriestley closed T13513: Make schema changes to inlines to prepare for new inline features as Resolved.

When you are viewing a document with engine X, and comments originally made with engine Y are present, this should be indicated ("This comment was made while looking at this change as a Q document."). They should probably also be moved to the top/bottom of the file, at least by default, since "Jupyter line number 9 = raw source line number 9" is an exceptionally bad and confusing guess at how to map line numbers.

Mar 17 2021, 10:59 PM · Inline Comments, Diffusion, Differential

epriestley closed T13513: Make schema changes to inlines to prepare for new inline features, a subtask of T13515: Differential: Inlines and View Options, as Resolved.

Mar 17 2021, 10:59 PM · Differential

epriestley updated the task description for T13534: Inline Comment errata after editing persistence.

Mar 17 2021, 10:59 PM · Differential

epriestley closed T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch as Resolved.

Some tag stuff ended up here; I moved it to T13645.

Mar 17 2021, 10:47 PM · Differential

epriestley updated the task description for T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

Mar 17 2021, 10:46 PM · Differential

epriestley triaged T13645: In Diffusion "Tags" view, improve behavior for tags that point at tag objects as Low priority.

Mar 17 2021, 10:45 PM · Diffusion