Page MenuHomePhabricator

Correct issue with "bindings" conduit attachment
ClosedPublic

Authored by epriestley on Mar 27 2021, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 5:02 PM
Unknown Object (File)
Wed, Feb 21, 6:29 AM
Unknown Object (File)
Wed, Feb 21, 6:29 AM
Unknown Object (File)
Wed, Feb 21, 6:29 AM
Unknown Object (File)
Feb 11 2024, 6:34 AM
Unknown Object (File)
Feb 9 2024, 7:48 PM
Unknown Object (File)
Jan 9 2024, 7:51 AM
Unknown Object (File)
Dec 24 2023, 4:53 PM
Subscribers
None

Details

Summary

Ref T13641. These conditions are swapped, and "activeBindings" loads more data than necessary while "bindings" doesn't load enough.

Test Plan

Called method with each attachment, got good results instead of an exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2021, 4:26 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.