Page MenuHomePhabricator

Correct issue with "bindings" conduit attachment
ClosedPublic

Authored by epriestley on Mar 27 2021, 4:25 PM.
Tags
None
Referenced Files
F15450961: D21657.id51532.diff
Fri, Mar 28, 7:18 PM
F15446213: D21657.id.diff
Thu, Mar 27, 5:45 PM
F15439301: D21657.diff
Wed, Mar 26, 6:51 AM
F15344518: D21657.diff
Mon, Mar 10, 5:01 AM
F15333225: D21657.diff
Sat, Mar 8, 1:01 AM
Unknown Object (File)
Mon, Mar 3, 12:25 PM
Unknown Object (File)
Feb 22 2025, 9:38 AM
Unknown Object (File)
Feb 22 2025, 5:35 AM
Subscribers
None

Details

Summary

Ref T13641. These conditions are swapped, and "activeBindings" loads more data than necessary while "bindings" doesn't load enough.

Test Plan

Called method with each attachment, got good results instead of an exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2021, 4:26 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.