Page MenuHomePhabricator
Create Task
Maniphest T13648

Transaction publishing may stall during mail expansion of package recipients
Closed, ResolvedPublic
Actions

Description

Caught this stuck in the daemon queue on secure:

$ /core/lib/phabricator/bin/worker execute --id 22218543
 EXECUTE  Executing Task 22218543 (PhabricatorApplicationTransactionPublishWorker)...
[2021-03-27 14:55:42] EXCEPTION: (RuntimeException) Undefined index: PHID-OPKG-mvkqudcgslb7dysivu3z at [<arcanist>/src/error/PhutilErrorHandler.php:252]
arcanist(head=master, ref.master=f0f95e5b2612), libcore(), phabricator(head=master, ref.master=61272e7ac31a, custom=1), secure(head=master, ref.master=988cf9bd7958), services(head=master, ref.master=0f2518e7c8f9)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php:302]
  #1 PhabricatorMailReplyHandler::expandRecipientPHIDs(array, array) called at [<phabricator>/src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php:207]
  #2 PhabricatorMailReplyHandler::getMailTargets(array, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:3068]
  #3 PhabricatorApplicationTransactionEditor::buildMailWithRecipients(DifferentialRevision, array, array, array, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:3052]
  #4 PhabricatorApplicationTransactionEditor::buildMail(DifferentialRevision, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1494]
  #5 PhabricatorApplicationTransactionEditor::publishTransactions(DifferentialRevision, array) called at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:21]
  #6 PhabricatorApplicationTransactionPublishWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:124]
  #7 PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:160]
  #8 PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementExecuteWorkflow.php:97]
  #9 PhabricatorWorkerManagementExecuteWorkflow::execute(PhutilArgumentParser) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:492]
  #10 PhutilArgumentParser::parseWorkflowsFull(array) called at [<arcanist>/src/parser/argument/PhutilArgumentParser.php:377]
  #11 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/setup/manage_worker.php:21]

Revisions and Commits

rP Phabricator
D21707rP387d3b4983d7 Resolve deleted packages properly as having no mailable members

Event Timeline

epriestley triaged this task as Wishlist priority.Mar 27 2021, 2:57 PM
epriestley created this task.
epriestley added a comment.Jul 21 2021, 1:03 AM

This happens when a recipient list includes an Owners package which has been destroyed. Specifically, we'll exit this section of PhabricatorMetaMTAMemberQuery with out the PHID in $package_map, and then fail to return it:

PhabricatorMetaMTAMemberQuery.php:46
$package_map = array();
if ($package_phids) {
  $packages = id(new PhabricatorOwnersPackageQuery())
    ->setViewer($viewer)
    ->withPHIDs($package_phids)
    ->execute();

  foreach ($packages as $package) {
    $package_owners = array();
    foreach ($package->getOwners() as $owner) {
      $owner_phid = $owner->getUserPHID();
      $owner_type = phid_get_type($owner_phid);
      $type_map[$owner_type][] = $owner_phid;
      $package_owners[] = $owner_phid;
    }
    $package_map[$package->getPHID()] = $package_owners;
  }
}

The remedy is to guarantee that all PHIDs in $package_phids are present in $package_map, but with a value of array() if they fail to load.

epriestley added a revision: D21707: Resolve deleted packages properly as having no mailable members.Jul 21 2021, 9:22 PM
epriestley closed this task as Resolved by committing rP387d3b4983d7: Resolve deleted packages properly as having no mailable members.Jul 21 2021, 9:50 PM
epriestley claimed this task.
epriestley added a commit: rP387d3b4983d7: Resolve deleted packages properly as having no mailable members.
epriestley added a comment.Jul 21 2021, 11:39 PM

The stalled transactions on this host published after I deployed the update.

Phabricator · Built by Phacility